Official Codebase of 3DCodeVerse
Python
urdf: model.py is linted by the blender language's rules plus the link-script rules
gaoypeng3d83064bb5dd
diff --git a/harness/codeverse3d/languages/urdf/__init__.py b/harness/codeverse3d/languages/urdf/__init__.pyindex b7f8833c..0fa442b0 100644--- a/harness/codeverse3d/languages/urdf/__init__.py+++ b/harness/codeverse3d/languages/urdf/__init__.py@@ -22,16 +22,10 @@ from codeverse3d.contracts.artifacts import BuildResult, GateFinding, GateReportfrom codeverse3d.contracts.common import ENTRY_FILE, Language, MimicSpec, mimic_issuesfrom codeverse3d.contracts.plan import ArticulatedPlan, JointPlan, PartPlan, Planfrom codeverse3d.conventions import to_snake-from codeverse3d.languages._ast_lint import (- BASE_FORBIDDEN_IMPORTS,- ImportCollector,- check_imports,- describe_parse_failure,- dotted,- safe_parse,-)+from codeverse3d.languages._ast_lint import dotted, safe_parsefrom codeverse3d.languages._common import compose_build_result, missing_entry, strip_blender_noisefrom codeverse3d.languages.base import RuntimeLayout+from codeverse3d.languages.blender import lint_blender_sourcefrom codeverse3d.proc import ProcResult, run_subprocessfrom codeverse3d.spatial.joints_export import urdf_to_glbfrom codeverse3d.spatial.joints_model import (@@ -112,35 +106,15 @@ _STATE_WORDS = ("open", "closed", "opened", "extended", "retracted", "raised", "#: identifiers only (``door``, ``handle_left``, ``DoorHandle``) — never ``Door.001`` / spaces._IDENT = re.compile(r"^[A-Za-z][A-Za-z0-9_]*$")-#: attribute chains that must not appear in model.py (harness owns these)-FORBIDDEN_BPY_PREFIXES: tuple[tuple[str, str], ...] = (- ("bpy.ops.wm.", "file/session operators (open/save/quit/read_factory_settings) — the harness owns the session"),- ("bpy.ops.render.", "rendering — the harness renders"),- ("bpy.ops.export_scene.", "exporting — the harness exports meshes/<link>.glb"),- ("bpy.ops.export_mesh.", "exporting — the harness exports"),- ("bpy.ops.import_scene.", "importing external files — build geometry procedurally"),- ("bpy.ops.import_mesh.", "importing external files — build geometry procedurally"),-)-#: the shared floor (subprocess/network/pickle/threading/importlib …): the wrapper execs-#: model.py inside the same Blender interpreter as the blender language, so no looser list-FORBIDDEN_IMPORTS: frozenset[str] = frozenset(BASE_FORBIDDEN_IMPORTS)-#: model.py runs inside the SAME Blender python as blender/model.py, so the pure-computation-#: stdlib it allows is allowed here too; anything else is an "unexpected" WARN (os/sys stay out:-#: a link-mesh script has no business in the filesystem, and FORBIDDEN_CALLS catches the uses)-ALLOWED_IMPORTS: frozenset[str] = frozenset({- "bpy", "bmesh", "mathutils", "math", "random", "numpy", "np", "bpy_extras", "__future__",- "typing", "dataclasses", "itertools", "functools", "collections", "enum", "copy",- "colorsys", "statistics", "operator",-})-FORBIDDEN_CALLS: dict[str, str] = {- "os.system": "shell access", "os.remove": "file deletion", "os.unlink": "file deletion", "os.rmdir": "file deletion",- "sys.exit": "exits Blender before the export — just return/raise instead", "exit": "exits Blender", "quit": "exits Blender",- "input": "blocks headless Blender forever",-}-WARN_CALLS: dict[str, str] = {- "bpy.ops.object.camera_add": "cameras are ignored (and stripped) by the wrapper",- "bpy.ops.object.light_add": "lights are ignored (and stripped) by the wrapper",- "time.sleep": "pointless in a build script",+#: model.py runs in the SAME Blender python as the blender language's model.py, so it is linted+#: by that language's rules (``lint_blender_source``: imports, harness-owned and removed bpy APIs,+#: file IO); these are the few a link script adds on top. Until 2026-09-24 this module kept its+#: own looser lists: one source gave 7 ERRORs as blender and 2 WARNs as urdf.+LINK_SCRIPT_CALLS: dict[str, tuple[Severity, str]] = {+ "exit": (Severity.ERROR, "exits Blender before the links are exported"),+ "quit": (Severity.ERROR, "exits Blender before the links are exported"),+ "input": (Severity.ERROR, "blocks headless Blender forever"),+ "time.sleep": (Severity.WARN, "pointless in a build script"),}@@ -403,62 +377,27 @@ def _lint_joint(el: ET.Element, jname: str, link_names: list[str], parent_of: di# ------------------------------------------------------------------ model.py-class _Visitor(ImportCollector):- def __init__(self) -> None:- super().__init__()- self.findings: list[GateFinding] = []- self.strings: set[str] = set()-- def visit_Call(self, node: ast.Call) -> None:- chain = dotted(node.func)- for prefix, why in FORBIDDEN_BPY_PREFIXES:- if chain.startswith(prefix):- self.findings.append(_f(Severity.ERROR, f"line {node.lineno}: {chain}() is forbidden: {why}", target=MODEL_REL,- fix="Delete this call; the harness owns sessions/exports/renders.", line=node.lineno))- if chain in FORBIDDEN_CALLS:- self.findings.append(_f(Severity.ERROR, f"line {node.lineno}: {chain}() is forbidden: {FORBIDDEN_CALLS[chain]}",- target=MODEL_REL, fix="Remove the call.", line=node.lineno))- if chain in WARN_CALLS:- self.findings.append(_f(Severity.WARN, f"line {node.lineno}: {chain}(): {WARN_CALLS[chain]}", target=MODEL_REL, line=node.lineno))- if chain == "open" and len(node.args) > 1 and isinstance(node.args[1], ast.Constant) and "w" in str(node.args[1].value):- self.findings.append(_f(Severity.WARN, f"line {node.lineno}: writing files from model.py is ignored by the harness",- target=MODEL_REL, line=node.lineno))- self.generic_visit(node)-- def visit_While(self, node: ast.While) -> None:- if isinstance(node.test, ast.Constant) and node.test.value is True:- self.findings.append(_f(Severity.WARN, f"line {node.lineno}: 'while True' in a build script risks a hang", target=MODEL_REL, line=node.lineno))- self.generic_visit(node)-- def visit_Constant(self, node: ast.Constant) -> None:- if isinstance(node.value, str):- self.strings.add(node.value)--def lint_model_text(text: str, link_names: list[str], *, label: str = MODEL_REL) -> list[GateFinding]:- """AST lint of model.py: forbidden APIs + every URDF link name appears as a string literal."""- tree, exc = safe_parse(text, label)+ """model.py: the blender language's lint + LINK_SCRIPT_CALLS, ``while True`` and every URDF+ link name appearing as a string literal (the wrapper looks objects up by exact name)."""+ out = [f.model_copy(update={"gate": GATE})+ for f in lint_blender_source(text, target=label, expect_names=False).findings]+ tree, _ = safe_parse(text, label)if tree is None:- msg, hint, line = describe_parse_failure(exc) # type: ignore[arg-type]- return [_f(Severity.ERROR, f"{label}:{line or '?'}: {msg}", target=label, fix=hint, line=line)]- v = _Visitor()- v.visit(tree)- out = v.findings-- def _import_finding(kind: str, mod: str, line: int) -> GateFinding:- if mod == "codeverse3d":- return _f(Severity.ERROR, f"line {line}: model.py must not import the harness", target=label, fix="Raw bpy only.", line=line)- if kind == "forbidden":- return _f(Severity.ERROR, f"line {line}: import of '{mod}' is not allowed in model.py", target=label,- fix="Build geometry with bpy/bmesh/mathutils/math only.", line=line)- return _f(Severity.WARN, f"line {line}: import of '{mod}' is unexpected in model.py (outside the contract's list)",- target=label, fix="Build geometry with bpy/bmesh/mathutils/math only.", line=line)-- out.extend(check_imports(v.imports, forbidden=FORBIDDEN_IMPORTS, allowed=ALLOWED_IMPORTS, make_finding=_import_finding))- if "bpy" not in v.imports:- out.append(_f(Severity.ERROR, f"{label} never imports bpy", target=label, fix="import bpy"))+ return out # the blender lint already reported the parse failure+ strings: set[str] = set()+ for node in ast.walk(tree):+ if isinstance(node, ast.Constant) and isinstance(node.value, str):+ strings.add(node.value)+ elif isinstance(node, ast.Call) and (rule := LINK_SCRIPT_CALLS.get(dotted(node.func))):+ sev, why = rule+ out.append(_f(sev, f"line {node.lineno}: {dotted(node.func)}(): {why}", target=label,+ fix="Remove the call." if sev == Severity.ERROR else "", line=node.lineno))+ elif isinstance(node, ast.While) and isinstance(node.test, ast.Constant) and node.test.value is True:+ out.append(_f(Severity.WARN, f"line {node.lineno}: 'while True' in a build script risks a hang",+ target=label, line=node.lineno))for link in link_names:- if link not in v.strings and not any(link in s for s in v.strings):+ if not any(link in s for s in strings):out.append(_f(Severity.WARN, f"link '{link}' never appears as a string in {label} — the wrapper looks for an object named exactly '{link}'",target=link, fix=f'obj.name = "{link}"'))return outdiff --git a/harness/tests/languages/test_ast_lint.py b/harness/tests/languages/test_ast_lint.pyindex 8109cc0d..5cc34754 100644--- a/harness/tests/languages/test_ast_lint.py+++ b/harness/tests/languages/test_ast_lint.py@@ -14,7 +14,6 @@ def test_language_forbidden_sets_are_supersets_of_base() -> None:assert BASE_FORBIDDEN_IMPORTS <= blender_lint.FORBIDDEN_IMPORTSassert BASE_FORBIDDEN_IMPORTS <= cadquery_lint.FORBIDDEN_IMPORTSassert BASE_FORBIDDEN_IMPORTS <= opengl_lint.DANGEROUS_MODULES- assert BASE_FORBIDDEN_IMPORTS <= urdf_lint.FORBIDDEN_IMPORTSassert "pathlib" in blender_lint.FORBIDDEN_IMPORTSassert {"os", "sys", "OCP", "build123d"} <= cadquery_lint.FORBIDDEN_IMPORTSassert {"os", "sys", "time", "datetime", "io", "tempfile", "signal"} <= opengl_lint.DANGEROUS_MODULES@@ -41,7 +40,7 @@ def test_base_modules_error_in_every_language_lint() -> None:findings = urdf_lint.lint_model_text("import bpy\nimport webbrowser\nimport os\n", [])assert any(f.severity == Severity.ERROR and "webbrowser" in f.message for f in findings)- assert any(f.severity == Severity.WARN and "'os'" in f.message for f in findings)+ assert not [f for f in findings if "`os`" in f.message] # the blender language's policy: os/sys alloweddef test_every_python_lint_survives_a_parser_crash(monkeypatch):diff --git a/harness/tests/urdf_joints/test_lint.py b/harness/tests/urdf_joints/test_lint.pyindex c501f694..66da4d19 100644--- a/harness/tests/urdf_joints/test_lint.py+++ b/harness/tests/urdf_joints/test_lint.py@@ -112,14 +112,29 @@ def test_model_lint():f = lint_model_text("import bpy, subprocess\nbpy.ops.wm.save_mainfile()\nbpy.ops.render.render()\nsys.exit()\nbpy.ops.object.camera_add()\n", [])msgs = _msgs(f, Severity.ERROR)assert any("subprocess" in m for m in msgs) and any("bpy.ops.wm.save_mainfile" in m for m in msgs)- assert any("render" in m for m in msgs) and any("sys.exit" in m for m in msgs)- assert any("camera" in m for m in _msgs(f, Severity.WARN))+ assert any("render" in m for m in msgs)+ assert any("camera" in m for m in _msgs(f, Severity.WARN)) and any("sys.exit" in m for m in _msgs(f, Severity.WARN))+ assert any("quit()" in m for m in _msgs(lint_model_text("import bpy\nquit()\n", []), Severity.ERROR))f = lint_model_text("x = (1,\n", [])assert f[0].severity == Severity.ERROR and "SyntaxError" in f[0].message and f[0].data["line"] == 1f = lint_model_text("import math\n", [])assert any("never imports bpy" in m for m in _msgs(f, Severity.ERROR))f = lint_model_text("import bpy\nfrom codeverse3d.x import y\n", [])- assert any("harness" in m for m in _msgs(f, Severity.ERROR))+ assert any("codeverse3d" in m for m in _msgs(f, Severity.WARN))+++def test_model_py_is_linted_by_the_blender_rules():+ """Regression (audit 2026-09-24 N19): model.py runs in the blender language's interpreter and+ gets that lint; the URDF copy caught 2 WARNs where blender found 7 ERRORs on this source."""+ from codeverse3d.languages.blender import lint_blender_source++ src = ("import bpy\nimport pathlib\nimport os\ncfg = open('/etc/passwd').read()\nos.makedirs('/tmp/x')\n"+ "bpy.data.libraries.load('/tmp/a.blend')\nbpy.ops.image.save_as()\n"+ "bsdf = bpy.data.materials.new('m').node_tree.nodes['Principled BSDF']\n"+ "bsdf.inputs['Specular'].default_value = 0.5\nbpy.ops.object.join({'object': None})\n"+ "o = bpy.context.active_object\no.name = 'base'\n")+ blender = _msgs(lint_blender_source(src).findings, Severity.ERROR)+ assert len(blender) == 7 and _msgs(lint_model_text(src, ["base"]), Severity.ERROR) == blenderdef test_lint_workspace(tmp_path):