Official Codebase of 3DCodeVerse
Python
eval/llm: score and render_views read their jsonl through read_rows — a torn line no longer crashes the stage (B13)
gaoypeng9fd34bc72568
diff --git a/eval/llm/render_views.py b/eval/llm/render_views.pyindex c4ded924..5545e3bb 100644--- a/eval/llm/render_views.py+++ b/eval/llm/render_views.py@@ -19,6 +19,7 @@ from concurrent.futures import ThreadPoolExecutor, as_completedfrom pathlib import Pathfrom . import config+from ._jsonl import read_rowsVIEWS = ["Image_005.png", "Image_015.png", "Image_025.png", "Image_035.png"]@@ -138,7 +139,7 @@ def render_glb_views(glb: str | Path, out_dir: str | Path, samples: int = 64, redef render_dir(gen_dir: Path, workers: int = 2, samples: int = 64, resolution: int = 512, engine: str = "CYCLES") -> dict[str, dict]:"""Render every task whose exec_results status is OK; returns {id: render_log}."""gen_dir = Path(gen_dir)- ex = {json.loads(l)["id"]: json.loads(l) for l in (gen_dir / "exec_results.jsonl").open() if l.strip()}+ ex = {r["id"]: r for r in read_rows(gen_dir / "exec_results.jsonl")}jobs = [(tid, e["mesh"]) for tid, e in ex.items() if e.get("status") == "OK" and e.get("mesh") and str(e["mesh"]).endswith(".glb")]print(f"[render] {gen_dir.name}: {len(jobs)} GLBs, {workers} workers, {engine} {samples}spp {resolution}px", flush=True)out: dict[str, dict] = {}diff --git a/eval/llm/score.py b/eval/llm/score.pyindex 527775c2..f3d4f8b1 100644--- a/eval/llm/score.py+++ b/eval/llm/score.py@@ -19,6 +19,7 @@ from concurrent.futures import ProcessPoolExecutorfrom pathlib import Pathfrom . import metrics+from ._jsonl import read_rowsfrom .suites import get_suite, load_prompts, resolve@@ -74,10 +75,10 @@ def score_dir(gen_dir: Path, suite: str, ref: str = "executed", workers: int = 4rows = {r["id"]: r for r in load_prompts(suite)}ex = {}if (gen_dir / "exec_results.jsonl").exists():- ex = {json.loads(l)["id"]: json.loads(l) for l in (gen_dir / "exec_results.jsonl").open() if l.strip()}+ ex = {r["id"]: r for r in read_rows(gen_dir / "exec_results.jsonl")}gens = {}if (gen_dir / "gens.jsonl").exists():- gens = {json.loads(l)["id"]: json.loads(l) for l in (gen_dir / "gens.jsonl").open() if l.strip()}+ gens = {r["id"]: r for r in read_rows(gen_dir / "gens.jsonl")}gen_stats = json.loads((gen_dir / "gen_stats.json").read_text()) if (gen_dir / "gen_stats.json").exists() else {}n_prompts_total = len(rows)if gens: # a --limit run: score only what was generated, but say so in the summary@@ -126,7 +127,7 @@ def score_dir(gen_dir: Path, suite: str, ref: str = "executed", workers: int = 4for enc in image_encoders:try:image_summ[enc] = image_sim.score_gen_dir(gen_dir, rows, resolve, enc, device, text_sim=(enc.startswith("siglip") and not any(r.get("images") for r in rows.values())))- per = {json.loads(l)["id"]: json.loads(l) for l in (gen_dir / f"image_sim_{enc}.jsonl").open()}+ per = {r["id"]: r for r in read_rows(gen_dir / f"image_sim_{enc}.jsonl")}for r in out_rows:p = per.get(r["id"], {})r[f"{enc}_paired"], r[f"{enc}_assigned"] = p.get("view_paired"), p.get("best_assignment")diff --git a/eval/llm/tests/test_smoke.py b/eval/llm/tests/test_smoke.pyindex 56e5b25b..ed7a7e92 100644--- a/eval/llm/tests/test_smoke.py+++ b/eval/llm/tests/test_smoke.py@@ -93,3 +93,11 @@ def test_a_torn_results_line_does_not_crash_a_resume():res = execute.execute_dir(Path(d), "blender")assert [r["id"] for r in res] == ["a"]assert out.read_text() == '{"id": "a", "status": "OK"}\n'+++def test_a_torn_results_line_does_not_crash_the_render_stage():+ """render_views / score read exec_results.jsonl strictly: one torn line crashed the stage."""+ render_views = importlib.import_module(f"{PKG}.render_views")+ with tempfile.TemporaryDirectory() as d:+ (Path(d) / "exec_results.jsonl").write_text('{"id": "a", "status": "FAIL"}\n{"id": "b", "sta')+ assert render_views.render_dir(Path(d)) == {}