Official Codebase of 3DCodeVerse
Python
scene: density gate — the layout's dressing counts are binding
gaoypenga68a7e677d7c
diff --git a/harness/codeverse/spatial/scene_placement.py b/harness/codeverse/spatial/scene_placement.pyindex 22209aae..91934b33 100644--- a/harness/codeverse/spatial/scene_placement.py+++ b/harness/codeverse/spatial/scene_placement.py@@ -259,6 +259,13 @@ def placement_findings(table: dict[str, Any] | PlacementTable, *, indoor: bool =#: census + the plan; their ERRORs route into refine with the zone as the target.SCALE_WARN, SCALE_ERROR = 2.5, 4.0BOUNDS_MARGIN_MIN_M = 2.0+#: a zone whose census instance count is under this fraction of its L2 layout budget is+#: underdressed. Measured on scene_final_v1 (n=19): flat_ground 12 / undressed 11 /+#: monotonous 10 were the top standing defects while every zone had a layout with binding+#: mid/small/ground-cover counts nobody enforced. Half is deliberately generous — the+#: budget mixes props with instanced tufts, and only a gross shortfall should gate.+DENSITY_FRACTION = 0.5+DENSITY_MIN_BUDGET = 20def _plan_zones(plan: Any) -> list[tuple[str, list[str]]]:@@ -302,12 +309,46 @@ def _plan_bounds(plan: Any) -> tuple[tuple[float, ...], tuple[float, ...]] | Nonreturn None-def contract_findings(census: dict[str, Any] | None, plan: Any) -> list[GateFinding]:+def _layout_budget(layout: Any) -> int:+ """Total things the L2 layout put in the zone: placements + dressing counts."""+ if layout is None:+ return 0+ get = layout.get if isinstance(layout, dict) else lambda k, d=0: getattr(layout, k, d)+ placements = get("placements", []) or []+ n = 0+ for pl in placements:+ n += int((pl.get("count", 1) if isinstance(pl, dict) else getattr(pl, "count", 1)) or 1)+ for k in ("mid_props", "small_props", "ground_cover"):+ n += int(get(k, 0) or 0)+ return n+++def contract_findings(census: dict[str, Any] | None, plan: Any,+ layouts: dict[str, Any] | None = None) -> list[GateFinding]:"""Deterministic plan-vs-census checks: env atmosphere present, every zone dressed- with its planned contents, plausible scale, content inside the world bounds."""+ with its planned contents, plausible scale, content inside the world bounds — and,+ when the zone has an L2 layout, its density budget actually met."""if not isinstance(census, dict) or plan is None:return []out: list[GateFinding] = []+ # -- density: the layout's counts are binding, and the census counts every instance+ groups = {to_snake(g.get("name", "")): g for g in (census.get("groups") or [])+ if isinstance(g, dict)}+ for zone_name, layout in (layouts or {}).items():+ budget = _layout_budget(layout)+ if budget < DENSITY_MIN_BUDGET:+ continue+ g = groups.get(to_snake(zone_name))+ if g is None:+ continue # zone_empty below covers a missing group+ have = int(g.get("instances") or 0)+ if have < DENSITY_FRACTION * budget:+ out.append(_f(Severity.ERROR,+ f"zone {zone_name} holds ~{have} instances but its layout budgeted {budget} "+ f"(placements + mid/small props + ground cover)",+ target=zone_name, kind="underdressed", have=have, budget=budget,+ hint="the layout's dressing counts are binding: add the missing props and the "+ "instanced ground cover (tufts/pebbles count via InstancedMesh.count)"))# -- atmosphere: the two env facts the census measures on every bootif "fog" in census and census.get("fog") is None:out.append(_f(Severity.ERROR, "scene.fog is not set — frames read as thin_atmosphere (32/48 measured runs)",@@ -415,7 +456,8 @@ def check_placement(ws: Workspace, *, indoor: bool | None = None, force_probe: breturn placement_findings(census.get("placement") or {}, indoor=indoor, duration_ms=int((time.time() - t0) * 1000))-def placement_gate_safe(census: dict[str, Any] | None, *, plan: Any = None) -> GateReport | None:+def placement_gate_safe(census: dict[str, Any] | None, *, plan: Any = None,+ layouts: dict[str, Any] | None = None) -> GateReport | None:"""Round-gate entry: ``None`` when the census has no placement table (scene did notboot, or an older driver), a WARN-only report when anything raises — never anexception, so the placement check cannot kill a round."""@@ -424,7 +466,7 @@ def placement_gate_safe(census: dict[str, Any] | None, *, plan: Any = None) -> Gif not isinstance(table, dict):return Nonereport = placement_findings(table, indoor=infer_indoor(setting_text(plan)))- extra = _cap_per_kind(contract_findings(census, plan))+ extra = _cap_per_kind(contract_findings(census, plan, layouts=layouts))if extra:findings = report.findings + extrapassed = not any(f.severity == Severity.ERROR for f in findings)diff --git a/harness/codeverse/tracks/scene.py b/harness/codeverse/tracks/scene.pyindex 2838a91c..afb71c52 100644--- a/harness/codeverse/tracks/scene.py+++ b/harness/codeverse/tracks/scene.py@@ -112,7 +112,7 @@ class ScenePipeline:try:from codeverse.spatial.scene_placement import placement_gate_safe- placement = placement_gate_safe(build.census, plan=ctx.plan)+ placement = placement_gate_safe(build.census, plan=ctx.plan, layouts=ctx.extra.get("layouts"))except Exception as e: # noqa: BLE001log.warning("scene placement gate unavailable: %s", e)placement = GateReport(gate="scene_placement", passed=True, findings=[GateFinding(diff --git a/harness/tests/scene_gates/test_placement.py b/harness/tests/scene_gates/test_placement.pyindex 62929f47..da254c17 100644--- a/harness/tests/scene_gates/test_placement.py+++ b/harness/tests/scene_gates/test_placement.py@@ -142,7 +142,7 @@ def _plan():def test_error_findings_become_zone_routed_refine_tasks_one_per_asset():plan = _plan()r = placement_findings(_table(_row("Lantern", gap=0.3), _row("Bench", gap=0.4), _row("Vase", zone="House", gap=0.5)))- ctx = SimpleNamespace(runtime=SimpleNamespace(), plan=plan, language=Language.SCENE_THREEJS)+ ctx = SimpleNamespace(runtime=SimpleNamespace(), plan=plan, language=Language.SCENE_THREEJS, extra={})tasks = build_refine_instructions(None, [r], [], plan, file_for_target=file_for_target_factory(ctx))assert sorted((t.target, tuple(t.files)) for t in tasks) == [("House/Vase", ("src/zones/house.js",)), ("Yard/Bench", ("src/zones/yard.js",)),("Yard/Lantern", ("src/zones/yard.js",))]@@ -151,7 +151,7 @@ def test_error_findings_become_zone_routed_refine_tasks_one_per_asset():def test_pipeline_gates_append_placement_after_census_and_never_raise():plan = _plan()- ctx = SimpleNamespace(runtime=SimpleNamespace(), plan=plan)+ ctx = SimpleNamespace(runtime=SimpleNamespace(), plan=plan, extra={})build = BuildResult(ok=True, language="scene_threejs", census={"totals": {"meshes": 3}, "placement": _table(_row("Lantern", gap=0.3))})gates = ScenePipeline().gates(ctx, 0, build, None)assert [g.gate for g in gates] == ["scene_census", GATE] and not gates[-1].passed@@ -226,3 +226,24 @@ def test_interpenetration_pairs_report_once_at_worst_overlap():{**pair, "aabb_overlap": 0.5, "inside_frac": 0.4}]))inter = _by_kind(r, "interpenetration")assert len(inter) == 1 and "70%" in inter[0].message and inter[0].severity == Severity.ERROR+++def test_density_gate_fires_on_a_zone_far_under_its_layout_budget():+ """scene_final_v1's top standing defects (flat_ground 12 / undressed 11 / monotonous 10)+ while every zone had a BINDING layout budget nobody enforced. The census counts every+ instance (InstancedMesh.count included), so the check is pure arithmetic."""+ layouts = {"Yard": {"placements": [{"asset": "Lantern", "count": 6}],+ "mid_props": 20, "small_props": 40, "ground_cover": 400},+ "House": {"placements": [], "mid_props": 2}} # budget 2 < threshold: ignored+ census = {"fog": {"type": "Fog"}, "background": "#aabbcc",+ "groups": [{"name": "Yard", "instances": 30}, {"name": "House", "instances": 1}],+ "placement": _table(_row("Lantern", h=0.6))}+ rep = placement_gate_safe(census, plan=_contract_plan(), layouts=layouts)+ under = [f for f in rep.findings if f.data.get("kind") == "underdressed"]+ assert len(under) == 1 and under[0].target == "Yard"+ assert "466" in under[0].message and "~30" in under[0].message+ # the same zone with the budget met is quiet+ census["groups"][0]["instances"] = 240 # >= half of 466+ rep = placement_gate_safe(census, plan=_contract_plan(), layouts=layouts)+ assert not [f for f in rep.findings if f.data.get("kind") == "underdressed"]+