Skip to content

Official Codebase of 3DCodeVerse

Python

Drop the unread views.json judge stamp and the vacuous judge filter in the slow-frame gate

gaoypengcc69c1e20f50
diff --git a/harness/codeverse3d/spatial/frame_metrics.py b/harness/codeverse3d/spatial/frame_metrics.py
index d898264b..beff9941 100644
--- a/harness/codeverse3d/spatial/frame_metrics.py
+++ b/harness/codeverse3d/spatial/frame_metrics.py
@@ -427,12 +427,12 @@ def _hero_findings(checks: list[dict[str, Any]], census: dict[str, Any]) -> list
def _render_time_findings(metrics: dict[str, Any]) -> list[GateFinding]:
- """WARN when the median judged Blender frame took longer than ``SLOW_FRAME_S``, naming the heaviest zone; silent for three.js."""
+ """WARN when the median rendered Blender frame took longer than ``SLOW_FRAME_S``, naming the heaviest zone; silent for three.js."""
b = metrics.get("blender")
if not isinstance(b, dict):
return []
ms = sorted(float(v["render_ms"]) for v in metrics.get("views") or []
- if isinstance(v, dict) and v.get("judge", True) and isinstance(v.get("render_ms"), int | float))
+ if isinstance(v, dict) and isinstance(v.get("render_ms"), int | float))
if not ms:
return []
median_s = ms[len(ms) // 2] / 1000.0
diff --git a/harness/codeverse3d/spatial/render_scene.py b/harness/codeverse3d/spatial/render_scene.py
index e2cd4c9d..1b37f343 100644
--- a/harness/codeverse3d/spatial/render_scene.py
+++ b/harness/codeverse3d/spatial/render_scene.py
@@ -2,7 +2,7 @@
``render_scene`` drives ``runtime_js/render_scene.mjs``: authored cameras + a fitted orbit rig at one or more
times, with deterministic instruments left in ``out_dir/metrics.json`` and a contact sheet of the judge subset.
-Each view carries ``judge: true|false``, stamped once from ``select_judge_views``.
+Each ``RenderView`` carries ``judge: true|false``, stamped once from ``select_judge_views``.
"""
from __future__ import annotations
@@ -243,7 +243,6 @@ def render_set_from_metrics(out_dir: Path, metrics: dict[str, Any], *, width: in
keep = {id(v) for v in chosen.views}
for v in rs.views:
v.judge = id(v) in keep
- _mark_judge_views(out_dir / "views.json", rs.views)
if sheet and views:
labelled = [(f"{v.name} t={v.time_s:g}", Path(v.path)) for v in rs.views if v.judge]
rs.contact_sheet = build_sheet(labelled, out_dir / "sheet.png")
@@ -294,20 +293,6 @@ def select_judge_views(rs: RenderSet, max_n: int = JUDGE_MAX_VIEWS, *, orbit_nam
return rs.model_copy(update={"views": [v for v in views if id(v) in keep]}) # disk order
-def _mark_judge_views(views_json: Path, views: Sequence[RenderView]) -> None:
- """Write each view's ``judge`` flag into views.json."""
- if not views_json.is_file():
- return
- try:
- entries = json.loads(views_json.read_text())
- except (OSError, ValueError):
- return
- flags = {(v.name, v.time_s): bool(v.judge) for v in views}
- for e in entries:
- e["judge"] = flags.get((e.get("name"), e.get("time_s")), False)
- views_json.write_text(json.dumps(entries, indent=1))
-
-
def metrics_path_for(rs: RenderSet) -> Path | None:
"""``metrics.json`` of a RenderSet: in ``out_dir``, else beside the sheet / views."""
if rs.out_dir:
diff --git a/harness/tests/scene_gates/test_live_frames.py b/harness/tests/scene_gates/test_live_frames.py
index 451f84cb..bd2ea495 100644
--- a/harness/tests/scene_gates/test_live_frames.py
+++ b/harness/tests/scene_gates/test_live_frames.py
@@ -2,7 +2,6 @@
from __future__ import annotations
-import json
from pathlib import Path
import pytest
@@ -63,7 +62,7 @@ def test_example_scene_passes_frame_gate_and_judge_subset(starter_ws: Workspace)
assert m["framing_bbox"]["size"][0] < m["census"]["bbox"]["size"][0] # content, not the sky dome / ground
gate = frame_gate_from_renders(rs)
assert gate.gate == "scene_frames" and gate.passed, [f.message for f in gate.findings]
- # judge subset: stamped ONCE at render time (RenderView.judge + views.json), sheet built from it only
+ # judge subset: stamped ONCE at render time (RenderView.judge), sheet built from it only
assert rs.out_dir == str(out)
assert all(v.judge is not None for v in rs.views)
stamped = {(v.name, v.time_s) for v in rs.views if v.judge}
@@ -78,9 +77,6 @@ def test_example_scene_passes_frame_gate_and_judge_subset(starter_ws: Workspace)
a = Image.open(next(v.path for v in rs.views if v.name == "windmill" and v.time_s == 0.0)).convert("L")
b = Image.open(next(v.path for v in rs.views if v.name == "windmill" and v.time_s == 1.5)).convert("L")
assert sum(1 for x, y in zip(a.tobytes(), b.tobytes(), strict=True) if abs(x - y) > 12) > 100
- entries = json.loads((out / "views.json").read_text())
- assert all("judge" in e for e in entries)
- assert {(v["name"], v["time_s"]) for v in entries if v["judge"]} == stamped
assert rs.contact_sheet and Path(rs.contact_sheet).is_file()
sheet = Image.open(rs.contact_sheet)
tile_h = Image.open(rs.views[0].path).size[1]
diff --git a/harness/tests/scene_runtime/test_render_blender.py b/harness/tests/scene_runtime/test_render_blender.py
index 078992d3..48779a75 100644
--- a/harness/tests/scene_runtime/test_render_blender.py
+++ b/harness/tests/scene_runtime/test_render_blender.py
@@ -52,7 +52,6 @@ def moving(tmp_path_factory):
@needs_browser
def test_a_fixture_scene_renders_two_cameras_at_two_times(moving):
ws, rs, m = moving
- out = Path(rs.out_dir)
authored = {(v.name, v.time_s) for v in rs.views if v.name in ("Front", "Side")}
assert authored == {("Front", 0.0), ("Front", 1.5), ("Side", 0.0), ("Side", 1.5)}
for v in rs.views:
@@ -79,7 +78,6 @@ def test_a_fixture_scene_renders_two_cameras_at_two_times(moving):
assert rs.console_errors == [] and rs.contact_sheet and Path(rs.contact_sheet).is_file()
judged = {(v.name, v.time_s) for v in rs.views if v.judge}
assert ("Front", 0.0) in judged and ("overview_top", 0.0) in judged
- assert [e["judge"] for e in json.loads((out / "views.json").read_text())].count(True) == len(judged)
#: a three.js scene of the fixture (its GLB as an asset, the same Front camera): the schema reference