3D engine that AI agents drive
Find Chrome on any OS in the look harness and always close its server
Nguyen Xuan An16ce5546afad
diff --git a/bench/agent-modeling/look.mjs b/bench/agent-modeling/look.mjsindex ef3d9065..9e171436 100644--- a/bench/agent-modeling/look.mjs+++ b/bench/agent-modeling/look.mjs@@ -7,6 +7,7 @@//// node bench/agent-modeling/look.mjs <task-id> <recipe.json> [--images <directory>]// node bench/agent-modeling/look.mjs --references+import { existsSync } from 'node:fs';import { mkdir, readFile, writeFile } from 'node:fs/promises';import { join, relative, resolve } from 'node:path';import { fileURLToPath } from 'node:url';@@ -66,8 +67,10 @@ export async function withLookPage(callback, viewport = { width: IMAGE_SIZE, heiconst { createServer } = await import('vite');const server = await createServer({ root: repository, server: { host: '127.0.0.1', port: 0 }, logLevel: 'silent' });await server.listen();- const browser = await chromium.launch({ executablePath: CHROME, headless: true, args: SWIFTSHADER_ARGUMENTS });+ let browser = null;try {+ // The Windows path is this machine's Chrome; elsewhere (CI on Linux) Playwright finds the installed Chrome by channel.+ browser = await chromium.launch({ ...(existsSync(CHROME) ? { executablePath: CHROME } : { channel: 'chrome' }), headless: true, args: SWIFTSHADER_ARGUMENTS });const page = await browser.newPage({ viewport });const errors = [];page.on('pageerror', error => errors.push(error.message));@@ -77,7 +80,8 @@ export async function withLookPage(callback, viewport = { width: IMAGE_SIZE, heiif (errors.length) throw new Error(errors.join('\n'));return result;} finally {- await browser.close();+ // A failed launch must still close the server, or the test process never exits.+ if (browser) await browser.close();await server.close();}}