Skip to content

armgit / 67.js

Public Imported from GitHub
0

3D engine that AI agents drive

Skip the water mirror draw for render pass frames

Nguyen Xuan An1eec3bc470aa
diff --git a/changes/297.md b/changes/297.md
new file mode 100644
index 00000000..8b502885
--- /dev/null
+++ b/changes/297.md
@@ -0,0 +1 @@
+- Water reflection skips the mirror draw for render pass frames (`albedo`, `normal`, `emission`, `depth`, `objectId`), which never show the reflection. A pass no longer pays for a second scene draw (closes #297).
diff --git a/src/water-reflection.js b/src/water-reflection.js
index 0e9e8289..82d99026 100644
--- a/src/water-reflection.js
+++ b/src/water-reflection.js
@@ -247,7 +247,8 @@ export function attachWaterReflection(renderer, surface, { scale = WATER_REFLECT
const dispose = renderer.dispose;
const renderFrame = frame => render.call(renderer, frame);
renderer.render = frame => {
- if (!frame.reflectionTarget) {
+ // A render pass (albedo, depth, object ID...) never shows the reflection, so it skips the mirror draw.
+ if (!frame.reflectionTarget && frame.pass === undefined) {
drawMirrorImage(renderer, state, frame, renderFrame);
}
return render.call(renderer, frame);
diff --git a/tests/water-reflection.test.js b/tests/water-reflection.test.js
index 0581f11b..c0d2b3fe 100644
--- a/tests/water-reflection.test.js
+++ b/tests/water-reflection.test.js
@@ -103,3 +103,28 @@ test('the mirror image is drawn at three quarters of the canvas in each directio
assert.deepEqual(textureSizes, [[720, 405]]);
detach();
});
+
+test('a render pass frame skips the mirror image and the next lit frame draws it again', () => {
+ const context = new Proxy({}, {
+ get: (_, name) => {
+ if (name === 'checkFramebufferStatus') {
+ return () => 1;
+ }
+ if (name === 'FRAMEBUFFER_COMPLETE') {
+ return 1;
+ }
+ return typeof name === 'string' && name === name.toUpperCase() ? 0 : () => ({});
+ },
+ });
+ const renderedFrames = [];
+ const renderer = { context, canvas: { width: 960, height: 540 }, hdr: false, viewProjection: new Float32Array(16), render: frame => renderedFrames.push(frame), dispose() {} };
+ const detach = attachWaterReflection(renderer, findWaterSurface(lakeScene()));
+ const camera = { eye: [0, 20, 100], target: [0, 0, 0] };
+ const mirrorDraws = () => renderedFrames.filter(frame => frame.reflectionTarget).length;
+ renderer.render({ ...camera, pass: 'objectId' });
+ assert.equal(mirrorDraws(), 0);
+ assert.equal(renderedFrames.length, 1);
+ renderer.render(camera);
+ assert.equal(mirrorDraws(), 1);
+ detach();
+});