Skip to content

armgit / 67.js

Public Imported from GitHub
0

3D engine that AI agents drive

Accept a Checked section as how the author checked a pull request

Nguyen Xuan Anb97cc2eaccc5
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 476837db..fcf92f38 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -39,7 +39,7 @@ The `Test` workflow runs this check on every pull request, so `git push --no-ver
### Describe how you checked it
-Under **How I checked it** (or **Ran**, **Checks**, **Tests**, **Verification**), paste the commands you ran and what they printed. A line such as `npm run preflight: 14 checks ok` is enough. This applies to agents too: show the commands and their results.
+Under **How I checked it** (or **Ran**, **Checks**, **Checked**, **Tests**, **Verification**), paste the commands you ran and what they printed. A line such as `npm run preflight: 14 checks ok` is enough. This applies to agents too: show the commands and their results.
### Keep private data out
diff --git a/scripts/pr-metadata-check.mjs b/scripts/pr-metadata-check.mjs
index 0690dd33..26c73855 100644
--- a/scripts/pr-metadata-check.mjs
+++ b/scripts/pr-metadata-check.mjs
@@ -36,7 +36,7 @@ const imagePattern = /!\[[^\]]*\]\([^)]+\)|<img\b|github\.com\/user-attachments\
const benchOptOutPattern = /(?:\bno|\bwithout|not have|n't have|\bcannot|can't|can not|\bunable to)\b[^.\n]*\b(?:claude code|bench)\b|\bmaintainers?\b[^.\n]*\b(?:run|runs|running)\b[^.\n]*\bbench|\bbench\b[^.\n]*\bmaintainers?\b[^.\n]*\brun/i;
// A body that says the tool schemas did not change needs no bench table.
const schemasUnchangedPattern = /\bschemas?\b[^.\n]*\b(?:unchanged|not changed|did not change|do not change|don't change|are the same|stay the same)\b|\bno (?:tool )?schema changes?\b|\bunchanged\b[^.\n]*\bschemas?\b/i;
-const checkedHeadings = ['How I checked it', 'Ran', 'Checks', 'Tests', 'Verification', 'How I tested it'];
+const checkedHeadings = ['How I checked it', 'Ran', 'Checks', 'Checked', 'Tests', 'Verification', 'How I tested it'];
const fencedBlockPattern = /```/;
const commandLinePattern = /^\s*(?:[$>]\s*)?(?:npm|node|npx)\s+\S/m;
diff --git a/tests/pr-metadata-check.test.js b/tests/pr-metadata-check.test.js
index d5a5ebb5..7ea7a563 100644
--- a/tests/pr-metadata-check.test.js
+++ b/tests/pr-metadata-check.test.js
@@ -137,6 +137,8 @@ test('detail text in src/agent-scene-capabilities.js alone needs no bench table'
test('a section named Ran, or a fenced block, counts as how I checked it', () => {
const ran = ['## What changed', '', 'Adds a thing.', '', 'Closes #12', '', '## Ran', '', 'npm run preflight passed, 14 checks ok.', ''].join('\n');
assert.deepEqual(fixIds({ pr: pullRequest({ body: ran }), files: shippedFiles }), []);
+ const checked = ran.replace('## Ran', '## Checked');
+ assert.deepEqual(fixIds({ pr: pullRequest({ body: checked }), files: shippedFiles }), []);
const fence = '`'.repeat(3);
const fenced = ['## What changed', '', 'Closes #12', '', fence, 'node --test tests/a.test.js', '# pass 4', fence, ''].join('\n');
assert.deepEqual(fixIds({ pr: pullRequest({ body: fenced }), files: shippedFiles }), []);