Skip to content

armgit / 67.js

Public Imported from GitHub
0

3D engine that AI agents drive

Keep the unfiltered image beside the a-trous one in trace-native and number the change notes for #897 (#897)

Nguyen Xuan And00d9536c63f
diff --git a/bench/cycles-parity/trace-native.mjs b/bench/cycles-parity/trace-native.mjs
index 3e42cdcc..5ecc579e 100644
--- a/bench/cycles-parity/trace-native.mjs
+++ b/bench/cycles-parity/trace-native.mjs
@@ -233,6 +233,11 @@ async function runCli() {
const linearRgb = wavelet ? wavelet.image : (atrousRgb ?? unfilteredRgb);
const npyPath = `${options.outputPrefix}.npy`;
await writeFloat32Npy(npyPath, linearRgb, [options.height, options.width, 3]);
+ // The a-trous filter returns the unfiltered image beside the filtered one; keeping it shows that the filter leaves `rgba` alone.
+ const unfilteredNpyPath = atrousRgb ? `${options.outputPrefix}.unfiltered.npy` : null;
+ if (unfilteredNpyPath) {
+ await writeFloat32Npy(unfilteredNpyPath, unfilteredRgb, [options.height, options.width, 3]);
+ }
const setupSeconds = sceneBuildSeconds + traced.setupSeconds + traced.compileSeconds + traced.uploadSeconds + traced.accelerationBuildSeconds;
const report = {
engine: options.kernel === 'cycles' ? 'cook-render-native' : '67js-render-native',
@@ -240,6 +245,7 @@ async function runCli() {
inputSchemaVersion: nativeInput.schemaVersion ?? 1,
sceneId: description.id,
npyPath,
+ unfilteredNpyPath,
width: options.width,
height: options.height,
samples: options.samples,
diff --git a/changes/895-atrous-filter.md b/changes/897-atrous-filter.md
similarity index 83%
rename from changes/895-atrous-filter.md
rename to changes/897-atrous-filter.md
index 7710f119..48d03ddf 100644
--- a/changes/895-atrous-filter.md
+++ b/changes/897-atrous-filter.md
@@ -1 +1 @@
-- `traceNative` takes `denoise: "atrous"` for the Cook kernel and returns a second, GPU wavelet filtered image in `denoisedRgba` (biased, off by default), and `denoiseAtrous` filters any traced image with its guide buffers (#895)
+- `traceNative` takes `denoise: "atrous"` for the Cook kernel and returns a second, GPU wavelet filtered image in `denoisedRgba` (biased, off by default), and `denoiseAtrous` filters any traced image with its guide buffers (#897)
diff --git a/changes/895-env-compensation.md b/changes/897-env-compensation.md
similarity index 77%
rename from changes/895-env-compensation.md
rename to changes/897-env-compensation.md
index 2fbfb5a7..44f37d79 100644
--- a/changes/895-env-compensation.md
+++ b/changes/897-env-compensation.md
@@ -1 +1 @@
-- The Cook `cycles` kernel can sample the environment map with MIS compensation (`envCompensation: true` or a fraction from 0 to 1; `--env-compensation` in `trace-native.mjs`), which lowers the error under a sunny HDRI and is off by default (#895)
+- The Cook `cycles` kernel can sample the environment map with MIS compensation (`envCompensation: true` or a fraction from 0 to 1; `--env-compensation` in `trace-native.mjs`), which lowers the error under a sunny HDRI and is off by default (#897)
diff --git a/changes/895-path-regeneration.md b/changes/897-path-regeneration.md
similarity index 78%
rename from changes/895-path-regeneration.md
rename to changes/897-path-regeneration.md
index 890b9b92..2c014277 100644
--- a/changes/895-path-regeneration.md
+++ b/changes/897-path-regeneration.md
@@ -1 +1 @@
-- The Cook `cycles` kernel starts a pixel's next sample as soon as a path ends when you pass `pathRegeneration: true` (`--path-regeneration` in `trace-native.mjs`), which cut sampling time by 9% to 37% on four scenes with the same image (#895)
+- The Cook `cycles` kernel starts a pixel's next sample as soon as a path ends when you pass `pathRegeneration: true` (`--path-regeneration` in `trace-native.mjs`), which cut sampling time by 9% to 37% on four scenes with the same image (#897)