Skip to content

There can be more than Notion and Miro. AFFiNE(pronounced [ə‘fain]) is a next-gen knowledge base that brings planning, sorting and creating all together. Privacy first, open-source, customizable and ready to use.

fix(electron): devtools open in detach mode (#8200)

pengx1724bf1beac845
diff --git a/packages/frontend/electron/src/main/windows-manager/main-window.ts b/packages/frontend/electron/src/main/windows-manager/main-window.ts
index 076cff77c2..a05eddf885 100644
--- a/packages/frontend/electron/src/main/windows-manager/main-window.ts
+++ b/packages/frontend/electron/src/main/windows-manager/main-window.ts
@@ -258,7 +258,9 @@ export async function openUrlInHiddenWindow(urlObj: URL) {
});
if (environment.isDebug) {
- win.webContents.openDevTools();
+ win.webContents.openDevTools({
+ mode: 'detach',
+ });
}
win.on('close', e => {
diff --git a/packages/frontend/electron/src/main/windows-manager/tab-views.ts b/packages/frontend/electron/src/main/windows-manager/tab-views.ts
index 591d9044e3..14c0913bf4 100644
--- a/packages/frontend/electron/src/main/windows-manager/tab-views.ts
+++ b/packages/frontend/electron/src/main/windows-manager/tab-views.ts
@@ -815,7 +815,9 @@ export class WebContentViewsManager {
view.webContents.loadURL(shellViewUrl).catch(logger.error);
if (isDev) {
- view.webContents.openDevTools();
+ view.webContents.openDevTools({
+ mode: 'detach',
+ });
}
}
@@ -999,13 +1001,17 @@ export const showDevTools = (id?: string) => {
getCustomThemeWindow()
.then(w => {
if (w && w.isFocused()) {
- w.webContents.openDevTools();
+ w.webContents.openDevTools({
+ mode: 'detach',
+ });
} else {
const view = id
? WebContentViewsManager.instance.getViewById(id)
: WebContentViewsManager.instance.activeWorkbenchView;
if (view) {
- view.webContents.openDevTools();
+ view.webContents.openDevTools({
+ mode: 'detach',
+ });
}
}
})