Skip to content

There can be more than Notion and Miro. AFFiNE(pronounced [ə‘fain]) is a next-gen knowledge base that brings planning, sorting and creating all together. Privacy first, open-source, customizable and ready to use.

chore(core): removed obsolete TODO (#7337)

JimmFly4af6223dc348
diff --git a/packages/frontend/core/src/commands/affine-updates.tsx b/packages/frontend/core/src/commands/affine-updates.tsx
index 2f632db6f3..2d43150943 100644
--- a/packages/frontend/core/src/commands/affine-updates.tsx
+++ b/packages/frontend/core/src/commands/affine-updates.tsx
@@ -1,3 +1,4 @@
+import { notify } from '@affine/component';
import { updateReadyAtom } from '@affine/core/hooks/use-app-updater';
import { apis } from '@affine/electron-api';
import type { useI18n } from '@affine/i18n';
@@ -24,7 +25,10 @@ export function registerAffineUpdatesCommands({
preconditionStrategy: () => !!store.get(updateReadyAtom),
run() {
apis?.updater.quitAndInstall().catch(err => {
- // TODO(@JimmFly): add error toast here
+ notify.error({
+ title: 'Failed to restart to upgrade',
+ message: 'Please restart the app manually to upgrade.',
+ });
console.error(err);
});
},
diff --git a/packages/frontend/core/src/components/affine/setting-modal/workspace-setting/new-workspace-setting-detail/labels.tsx b/packages/frontend/core/src/components/affine/setting-modal/workspace-setting/new-workspace-setting-detail/labels.tsx
index 5cb6fdc3e8..45ac0374c0 100644
--- a/packages/frontend/core/src/components/affine/setting-modal/workspace-setting/new-workspace-setting-detail/labels.tsx
+++ b/packages/frontend/core/src/components/affine/setting-modal/workspace-setting/new-workspace-setting-detail/labels.tsx
@@ -81,10 +81,6 @@ export const LabelsPanel = () => {
condition: workspace.flavour === 'affine-cloud',
label: 'syncCloud',
},
- //TODO(@JimmFly): add these labels
- // { status==="synced", label: 'availableOffline' }
- // { workspace.flavour === 'affine-Docker', label: 'syncDocker' }
- // { workspace.flavour === 'self-hosted', label: 'selfHosted' }
];
return (
diff --git a/packages/frontend/core/src/components/affine/share-page-modal/share-menu/index.css.ts b/packages/frontend/core/src/components/affine/share-page-modal/share-menu/index.css.ts
index 459676cf5c..86ad7d0c7e 100644
--- a/packages/frontend/core/src/components/affine/share-page-modal/share-menu/index.css.ts
+++ b/packages/frontend/core/src/components/affine/share-page-modal/share-menu/index.css.ts
@@ -29,7 +29,6 @@ export const descriptionStyle = style({
});
export const buttonStyle = style({
marginTop: '18px',
- // todo(@JimmFly): new color scheme should be used
});
export const actionsStyle = style({
display: 'flex',
diff --git a/packages/frontend/core/src/components/page-list/collections/collection-list-item.css.ts b/packages/frontend/core/src/components/page-list/collections/collection-list-item.css.ts
index 51bfc2ae5d..994389b129 100644
--- a/packages/frontend/core/src/components/page-list/collections/collection-list-item.css.ts
+++ b/packages/frontend/core/src/components/page-list/collections/collection-list-item.css.ts
@@ -66,7 +66,6 @@ globalStyle(`[data-draggable=true][data-dragging=true] ${dndCell}:before`, {
opacity: 1,
});
-// TODO(@JimmFly): remove global style
globalStyle(`${root} > :first-child`, {
paddingLeft: '16px',
});
diff --git a/packages/frontend/core/src/components/page-list/collections/collection-list-item.tsx b/packages/frontend/core/src/components/page-list/collections/collection-list-item.tsx
index 871b22d371..73b0975366 100644
--- a/packages/frontend/core/src/components/page-list/collections/collection-list-item.tsx
+++ b/packages/frontend/core/src/components/page-list/collections/collection-list-item.tsx
@@ -109,7 +109,6 @@ export const CollectionListItem = (props: CollectionListItemProps) => {
props.title,
]);
- // TODO(@JimmFly): use getDropItemId
const { setNodeRef, attributes, listeners, isDragging } = useDraggable({
id: getDNDId('collection-list', 'collection', props.collectionId),
data: {
diff --git a/packages/frontend/core/src/components/page-list/docs/page-list-item.css.ts b/packages/frontend/core/src/components/page-list/docs/page-list-item.css.ts
index b097b481b1..560f2ba72f 100644
--- a/packages/frontend/core/src/components/page-list/docs/page-list-item.css.ts
+++ b/packages/frontend/core/src/components/page-list/docs/page-list-item.css.ts
@@ -66,7 +66,6 @@ globalStyle(`[data-draggable=true][data-dragging=true] ${dndCell}:before`, {
opacity: 1,
});
-// TODO(@JimmFly): remove global style
globalStyle(`${root} > :first-child`, {
paddingLeft: '16px',
});
diff --git a/packages/frontend/core/src/components/page-list/docs/page-list-item.tsx b/packages/frontend/core/src/components/page-list/docs/page-list-item.tsx
index 4460ccf454..0c3b07c7f3 100644
--- a/packages/frontend/core/src/components/page-list/docs/page-list-item.tsx
+++ b/packages/frontend/core/src/components/page-list/docs/page-list-item.tsx
@@ -167,7 +167,6 @@ export const PageListItem = (props: PageListItemProps) => {
props.title,
]);
- // TODO(@JimmFly): use getDropItemId
const { setNodeRef, attributes, listeners, isDragging } = useDraggable({
id: getDNDId('doc-list', 'doc', props.pageId),
data: {
diff --git a/packages/frontend/core/src/components/page-list/tags/tag-list-item.css.ts b/packages/frontend/core/src/components/page-list/tags/tag-list-item.css.ts
index db5beb0fe9..b144ea023f 100644
--- a/packages/frontend/core/src/components/page-list/tags/tag-list-item.css.ts
+++ b/packages/frontend/core/src/components/page-list/tags/tag-list-item.css.ts
@@ -65,7 +65,6 @@ globalStyle(`[data-draggable=true][data-dragging=true] ${dndCell}:before`, {
opacity: 1,
});
-// TODO(@JimmFly): remove global style
globalStyle(`${root} > :first-child`, {
paddingLeft: '16px',
});
diff --git a/packages/frontend/core/src/components/page-list/tags/tag-list-item.tsx b/packages/frontend/core/src/components/page-list/tags/tag-list-item.tsx
index 6ebbd22c6d..eed062b774 100644
--- a/packages/frontend/core/src/components/page-list/tags/tag-list-item.tsx
+++ b/packages/frontend/core/src/components/page-list/tags/tag-list-item.tsx
@@ -98,7 +98,6 @@ export const TagListItem = (props: TagListItemProps) => {
);
}, [props.color, props.onSelectedChange, props.selectable, props.selected]);
- // TODO(@JimmFly): use getDropItemId
const { setNodeRef, attributes, listeners, isDragging } = useDraggable({
id: getDNDId('tag-list', 'tag', props.tagId),
data: {
diff --git a/packages/frontend/core/src/components/page-list/types.ts b/packages/frontend/core/src/components/page-list/types.ts
index 46e079c571..e0bcad3027 100644
--- a/packages/frontend/core/src/components/page-list/types.ts
+++ b/packages/frontend/core/src/components/page-list/types.ts
@@ -74,9 +74,7 @@ export type TagListItemProps = {
export interface ItemListHeaderProps {}
// TODO(@JimmFly): a temporary solution. may need to be refactored later
-export type ItemGroupByType = 'createDate' | 'updatedDate'; // TODO(@JimmFly): can add more later
-
-// TODO(@JimmFly): a temporary solution. may need to be refactored later
+export type ItemGroupByType = 'createDate' | 'updatedDate';
export interface SortBy {
key: 'createDate' | 'updatedDate';
order: 'asc' | 'desc';
diff --git a/packages/frontend/core/src/pages/workspace/detail-page/detail-page.css.ts b/packages/frontend/core/src/pages/workspace/detail-page/detail-page.css.ts
index e8890271c7..10cb6441fc 100644
--- a/packages/frontend/core/src/pages/workspace/detail-page/detail-page.css.ts
+++ b/packages/frontend/core/src/pages/workspace/detail-page/detail-page.css.ts
@@ -22,7 +22,6 @@ export const affineDocViewport = style({
flexDirection: 'column',
userSelect: 'none',
containerName: 'viewport',
- // TODO(@JimmFly): find out what this does in bs
containerType: 'inline-size',
background: cssVar('backgroundPrimaryColor'),
'@media': {