Skip to content

There can be more than Notion and Miro. AFFiNE(pronounced [ə‘fain]) is a next-gen knowledge base that brings planning, sorting and creating all together. Privacy first, open-source, customizable and ready to use.

fix(core): unexpected double-click behavior when selecting multiple options on all doc pages (#8461)

JimmFly8d3a543a8166
diff --git a/packages/frontend/core/src/components/page-list/collections/collection-list-item.tsx b/packages/frontend/core/src/components/page-list/collections/collection-list-item.tsx
index c9a5f95dfa..f573c06c7e 100644
--- a/packages/frontend/core/src/components/page-list/collections/collection-list-item.tsx
+++ b/packages/frontend/core/src/components/page-list/collections/collection-list-item.tsx
@@ -213,6 +213,7 @@ const CollectionListItemWrapper = forwardRef(
const commonProps = useMemo(
() => ({
+ role: 'list-item',
'data-testid': 'collection-list-item',
'data-collection-id': collectionId,
'data-draggable': draggable,
diff --git a/packages/frontend/core/src/components/page-list/docs/page-list-item.tsx b/packages/frontend/core/src/components/page-list/docs/page-list-item.tsx
index 2675a47f3f..646ee66de2 100644
--- a/packages/frontend/core/src/components/page-list/docs/page-list-item.tsx
+++ b/packages/frontend/core/src/components/page-list/docs/page-list-item.tsx
@@ -345,6 +345,7 @@ const PageListItemWrapper = forwardRef(
const commonProps = useMemo(
() => ({
+ role: 'list-item',
'data-testid': 'page-list-item',
'data-page-id': pageId,
'data-draggable': draggable,
diff --git a/packages/frontend/core/src/components/page-list/list.tsx b/packages/frontend/core/src/components/page-list/list.tsx
index 6e340afc12..f2cbdea737 100644
--- a/packages/frontend/core/src/components/page-list/list.tsx
+++ b/packages/frontend/core/src/components/page-list/list.tsx
@@ -61,7 +61,9 @@ const useItemSelectionStateEffect = () => {
if (
target.tagName === 'BUTTON' ||
target.tagName === 'INPUT' ||
- (e.target as HTMLElement).closest('button, input, [role="toolbar"]')
+ (e.target as HTMLElement).closest(
+ 'button, input, [role="toolbar"], [role="list-item"]'
+ )
) {
return;
}
diff --git a/packages/frontend/core/src/components/page-list/tags/tag-list-item.tsx b/packages/frontend/core/src/components/page-list/tags/tag-list-item.tsx
index da54dc177c..1acbd18e64 100644
--- a/packages/frontend/core/src/components/page-list/tags/tag-list-item.tsx
+++ b/packages/frontend/core/src/components/page-list/tags/tag-list-item.tsx
@@ -198,6 +198,7 @@ const TagListItemWrapper = forwardRef(
const commonProps = useMemo(
() => ({
+ role: 'list-item',
'data-testid': 'tag-list-item',
'data-tag-id': tagId,
'data-draggable': draggable,