Skip to content

There can be more than Notion and Miro. AFFiNE(pronounced [ə‘fain]) is a next-gen knowledge base that brings planning, sorting and creating all together. Privacy first, open-source, customizable and ready to use.

fix(editor): preserve tag name updates on modifying tag color (#11744)

Xun Sun8ea0d788625b
diff --git a/blocksuite/affine/data-view/src/core/component/tags/multi-tag-select.ts b/blocksuite/affine/data-view/src/core/component/tags/multi-tag-select.ts
index be1383eee9..e5779c8842 100644
--- a/blocksuite/affine/data-view/src/core/component/tags/multi-tag-select.ts
+++ b/blocksuite/affine/data-view/src/core/component/tags/multi-tag-select.ts
@@ -72,7 +72,7 @@ export type TagManagerOptions = {
};
class TagManager {
- changeTag = (option: SelectTag) => {
+ changeTag = (option: Partial<SelectTag>) => {
this.ops.onOptionsChange(
this.ops.options.value.map(item => {
if (item.id === option.id) {
@@ -207,7 +207,7 @@ export class MultiTagSelect extends SignalWatcher(
initialValue: option.value,
onChange: text => {
this.tagManager.changeTag({
- ...option,
+ id: option.id,
value: text,
});
},
@@ -237,7 +237,7 @@ export class MultiTagSelect extends SignalWatcher(
isSelected: option.color === item.color,
select: () => {
this.tagManager.changeTag({
- ...option,
+ id: option.id,
color: item.color,
});
},