Skip to content

There can be more than Notion and Miro. AFFiNE(pronounced [ə‘fain]) is a next-gen knowledge base that brings planning, sorting and creating all together. Privacy first, open-source, customizable and ready to use.

fix(electron): only the active view should respond to CMD+N (#8068)

pengx17ae3b13bfb4e9
diff --git a/packages/frontend/core/src/components/root-app-sidebar/index.tsx b/packages/frontend/core/src/components/root-app-sidebar/index.tsx
index 7db22854e7..2c63d68750 100644
--- a/packages/frontend/core/src/components/root-app-sidebar/index.tsx
+++ b/packages/frontend/core/src/components/root-app-sidebar/index.tsx
@@ -11,7 +11,7 @@ import {
import { ExplorerTags } from '@affine/core/modules/explorer/views/sections/tags';
import { CMDKQuickSearchService } from '@affine/core/modules/quicksearch/services/cmdk';
import { isNewTabTrigger } from '@affine/core/utils';
-import { events } from '@affine/electron-api';
+import { apis, events } from '@affine/electron-api';
import { useI18n } from '@affine/i18n';
import type { DocMode } from '@blocksuite/blocks';
import {
@@ -122,7 +122,19 @@ export const RootAppSidebar = (): ReactElement => {
useEffect(() => {
if (environment.isDesktop) {
- return events?.applicationMenu.onNewPageAction(() => onClickNewPage());
+ return events?.applicationMenu.onNewPageAction(() => {
+ apis?.ui
+ .isActiveTab()
+ .then(isActive => {
+ if (!isActive) {
+ return;
+ }
+ onClickNewPage();
+ })
+ .catch(err => {
+ console.error(err);
+ });
+ });
}
return;
}, [onClickNewPage]);