Skip to content

There can be more than Notion and Miro. AFFiNE(pronounced [ə‘fain]) is a next-gen knowledge base that brings planning, sorting and creating all together. Privacy first, open-source, customizable and ready to use.

chore: upgrade oxlint to v0.13.2 (#8891)

Boshenc349a24e95b5
diff --git a/oxlint.json b/oxlint.json
index c845c7ced8..91053e4462 100644
--- a/oxlint.json
+++ b/oxlint.json
@@ -1,4 +1,6 @@
{
+ "$schema": "./node_modules/oxlint/configuration_schema.json",
+ "plugins": ["import", "react", "typescript", "unicorn", "promise"],
"categories": {
"correctness": "error",
"perf": "error"
@@ -7,6 +9,7 @@
// allow
"import/named": "allow",
"no-await-in-loop": "allow",
+ "promise/no-callback-in-promise": "allow",
// deny
"unicorn/prefer-array-some": "error",
"unicorn/no-useless-promise-resolve-reject": "error",
@@ -16,5 +19,13 @@
"ignoreTypes": true
}
]
- }
+ },
+ "overrides": [
+ {
+ "files": ["*.stories.tsx"],
+ "rules": {
+ "react/no-array-index-key": "off"
+ }
+ }
+ ]
}
diff --git a/package.json b/package.json
index 6631ada29c..53c7d06410 100644
--- a/package.json
+++ b/package.json
@@ -29,7 +29,7 @@
"lint:eslint:fix": "yarn lint:eslint --fix",
"lint:prettier": "prettier --ignore-unknown --cache --check .",
"lint:prettier:fix": "prettier --ignore-unknown --cache --write .",
- "lint:ox": "oxlint -c oxlint.json --deny-warnings --import-plugin",
+ "lint:ox": "oxlint -c oxlint.json --deny-warnings",
"lint": "yarn lint:eslint && yarn lint:prettier",
"lint:fix": "yarn lint:eslint:fix && yarn lint:prettier:fix",
"test": "vitest --run",
@@ -88,7 +88,7 @@
"msw": "^2.3.0",
"nx": "^20.0.3",
"nx-cloud": "^19.1.0",
- "oxlint": "0.12.0",
+ "oxlint": "0.13.2",
"prettier": "^3.3.3",
"semver": "^7.6.0",
"serve": "^14.2.1",
diff --git a/packages/backend/server/src/plugins/copilot/providers/index.ts b/packages/backend/server/src/plugins/copilot/providers/index.ts
index c7876b9bcf..e25ef693b1 100644
--- a/packages/backend/server/src/plugins/copilot/providers/index.ts
+++ b/packages/backend/server/src/plugins/copilot/providers/index.ts
@@ -94,10 +94,8 @@ export function unregisterCopilotProvider(type: CopilotProviderType) {
/// Asserts that the config is valid for any registered providers
export function assertProvidersConfigs(config: AFFiNEConfig) {
- return (
- Array.from(ASSERT_CONFIG.values()).findIndex(assertConfig =>
- assertConfig(config)
- ) !== -1
+ return Array.from(ASSERT_CONFIG.values()).some(assertConfig =>
+ assertConfig(config)
);
}
diff --git a/packages/backend/server/src/plugins/payment/service.ts b/packages/backend/server/src/plugins/payment/service.ts
index 821fde56c3..cc9fa6fcc4 100644
--- a/packages/backend/server/src/plugins/payment/service.ts
+++ b/packages/backend/server/src/plugins/payment/service.ts
@@ -64,10 +64,10 @@ export function decodeLookupKey(
];
}
-const SubscriptionActivated: Stripe.Subscription.Status[] = [
+const SubscriptionActivated: Set<Stripe.Subscription.Status> = new Set([
SubscriptionStatus.Active,
SubscriptionStatus.Trialing,
-];
+]);
export enum CouponType {
ProEarlyAccessOneYearFree = 'pro_ea_one_year_free',
@@ -750,7 +750,7 @@ export class SubscriptionService {
const [plan, recurring, variant] =
this.decodePlanFromSubscription(subscription);
- const planActivated = SubscriptionActivated.includes(subscription.status);
+ const planActivated = SubscriptionActivated.has(subscription.status);
// update features first, features modify are idempotent
// so there is no need to skip if a subscription already exists.
diff --git a/packages/frontend/admin/src/modules/ai/edit-prompt.tsx b/packages/frontend/admin/src/modules/ai/edit-prompt.tsx
index f1e1b8caeb..4d8e4992dd 100644
--- a/packages/frontend/admin/src/modules/ai/edit-prompt.tsx
+++ b/packages/frontend/admin/src/modules/ai/edit-prompt.tsx
@@ -120,7 +120,7 @@ export function EditPrompt({
<div className="px-5 py-4 overflow-y-auto space-y-[10px] flex flex-col">
<div className="text-sm font-medium">Messages</div>
{messages.map((message, index) => (
- <div key={index} className="flex flex-col gap-3">
+ <div key={message.content} className="flex flex-col gap-3">
{index !== 0 && <Separator />}
<div>
<div className="text-sm font-normal">Role</div>
diff --git a/packages/frontend/admin/src/modules/ai/prompts.tsx b/packages/frontend/admin/src/modules/ai/prompts.tsx
index 998e1a5ed0..477562a3f3 100644
--- a/packages/frontend/admin/src/modules/ai/prompts.tsx
+++ b/packages/frontend/admin/src/modules/ai/prompts.tsx
@@ -40,7 +40,7 @@ export function Prompts() {
<div className="flex flex-col rounded-md border w-full">
{list.map((item, index) => (
<PromptRow
- key={item.name.concat(index.toString())}
+ key={`${item.name}-${index}`}
item={item}
index={index}
/>
diff --git a/packages/frontend/admin/src/modules/nav/collapsible-item.tsx b/packages/frontend/admin/src/modules/nav/collapsible-item.tsx
index 62b33c6793..bac09e9c2b 100644
--- a/packages/frontend/admin/src/modules/nav/collapsible-item.tsx
+++ b/packages/frontend/admin/src/modules/nav/collapsible-item.tsx
@@ -51,9 +51,9 @@ export const CollapsibleItem = ({
</AccordionTrigger>
</NavLink>
<AccordionContent className=" flex flex-col gap-2 py-1">
- {items.map((item, index) => (
+ {items.map(item => (
<NavLink
- key={index}
+ key={item}
to={`/admin/settings/${title}#${item}`}
className={({ isActive }) => {
return isActive && activeSubTab === item
diff --git a/packages/frontend/admin/src/modules/setup/form.tsx b/packages/frontend/admin/src/modules/setup/form.tsx
index 093fb4ed7b..0114ba6e2c 100644
--- a/packages/frontend/admin/src/modules/setup/form.tsx
+++ b/packages/frontend/admin/src/modules/setup/form.tsx
@@ -213,7 +213,7 @@ export const Form = () => {
<div className="py-2 px-0 text-sm mt-16 max-lg:mt-5 relative">
{Array.from({ length: count }).map((_, index) => (
<span
- key={index}
+ key={`${index}`}
className={`inline-block w-16 h-1 rounded mr-1 ${
index <= current - 1
? 'bg-primary'
diff --git a/packages/frontend/component/src/components/auth-components/onboarding-page.tsx b/packages/frontend/component/src/components/auth-components/onboarding-page.tsx
index a366f7999f..50ba98eba4 100644
--- a/packages/frontend/component/src/components/auth-components/onboarding-page.tsx
+++ b/packages/frontend/component/src/components/auth-components/onboarding-page.tsx
@@ -159,11 +159,11 @@ export const OnboardingPage = ({
<div className={styles.optionsWrapper}>
{question.options &&
question.options.length > 0 &&
- question.options.map((option, optionIndex) => {
+ question.options.map(option => {
if (option.type === 'checkbox') {
return (
<Checkbox
- key={optionIndex}
+ key={option.label}
name={option.value}
className={styles.checkBox}
labelClassName={styles.label}
@@ -184,7 +184,7 @@ export const OnboardingPage = ({
} else if (option.type === 'input') {
return (
<Input
- key={optionIndex}
+ key={option.label}
className={styles.input}
type="text"
size="large"
diff --git a/packages/frontend/component/src/ui/date-picker/calendar/day-picker.tsx b/packages/frontend/component/src/ui/date-picker/calendar/day-picker.tsx
index 829eb4992b..b2fe93b6d5 100644
--- a/packages/frontend/component/src/ui/date-picker/calendar/day-picker.tsx
+++ b/packages/frontend/component/src/ui/date-picker/calendar/day-picker.tsx
@@ -187,23 +187,27 @@ export const DayPicker = memo(function DayPicker(
{/* Weeks in month */}
{matrix.map((week, i) => {
return (
+ // eslint-disable-next-line react/no-array-index-key
<div key={i} className={clsx(styles.monthViewRow)}>
- {week.map((cell, j) => (
- <div
- className={clsx(
- styles.monthViewBodyCell,
- monthBodyCellClassName
- )}
- key={j}
- onClick={() => onChange?.(cell.date.format(format))}
- >
- {customDayRenderer ? (
- customDayRenderer(cell)
- ) : (
- <DefaultDateCell key={j} {...cell} />
- )}
- </div>
- ))}
+ {week.map(cell => {
+ const dateValue = cell.date.format(format);
+ return (
+ <div
+ className={clsx(
+ styles.monthViewBodyCell,
+ monthBodyCellClassName
+ )}
+ key={dateValue}
+ onClick={() => onChange?.(dateValue)}
+ >
+ {customDayRenderer ? (
+ customDayRenderer(cell)
+ ) : (
+ <DefaultDateCell key={dateValue} {...cell} />
+ )}
+ </div>
+ );
+ })}
</div>
);
})}
diff --git a/packages/frontend/component/src/ui/date-picker/calendar/items.tsx b/packages/frontend/component/src/ui/date-picker/calendar/items.tsx
index 13182f589f..a2258bdb36 100644
--- a/packages/frontend/component/src/ui/date-picker/calendar/items.tsx
+++ b/packages/frontend/component/src/ui/date-picker/calendar/items.tsx
@@ -45,6 +45,7 @@ const HeaderLayout = memo(function HeaderLayout({
const isRight = index === length - 1;
return (
<div
+ // eslint-disable-next-line react/no-array-index-key
key={index}
data-length={length}
data-is-left={isLeft}
diff --git a/packages/frontend/component/src/ui/date-picker/calendar/month-picker.tsx b/packages/frontend/component/src/ui/date-picker/calendar/month-picker.tsx
index f868016ff7..1466ed2c3c 100644
--- a/packages/frontend/component/src/ui/date-picker/calendar/month-picker.tsx
+++ b/packages/frontend/component/src/ui/date-picker/calendar/month-picker.tsx
@@ -126,21 +126,24 @@ export const MonthPicker = memo(function MonthPicker(
const Body = useMemo(() => {
return (
<div className={styles.yearViewBody}>
+ {/* eslint-disable-next-line react/no-array-index-key */}
{matrix.map((row, i) => {
return (
+ // eslint-disable-next-line react/no-array-index-key
<div key={i} className={styles.yearViewRow}>
- {row.map((month, j) => {
+ {row.map(month => {
+ const monthValue = month.format('YYYY-MM');
return (
- <div key={j} className={styles.yearViewBodyCell}>
+ <div key={monthValue} className={styles.yearViewBodyCell}>
<button
- data-value={month.format('YYYY-MM')}
+ data-value={monthValue}
data-is-month-cell
className={styles.yearViewBodyCellInner}
data-selected={value && month.isSame(value, 'month')}
data-current-month={month.isSame(dayjs(), 'month')}
onClick={() => onMonthChange(month)}
tabIndex={month.isSame(monthCursor, 'month') ? 0 : -1}
- aria-label={month.format('YYYY-MM')}
+ aria-label={monthValue}
>
{monthNames.split(',')[month.month()]}
</button>
diff --git a/packages/frontend/component/src/ui/date-picker/calendar/year-picker.tsx b/packages/frontend/component/src/ui/date-picker/calendar/year-picker.tsx
index 6cd29f7c72..917c02aa5c 100644
--- a/packages/frontend/component/src/ui/date-picker/calendar/year-picker.tsx
+++ b/packages/frontend/component/src/ui/date-picker/calendar/year-picker.tsx
@@ -136,12 +136,14 @@ export const YearPicker = memo(function YearPicker(
<div className={styles.decadeViewBody}>
{matrix.map((row, i) => {
return (
+ // eslint-disable-next-line react/no-array-index-key
<div key={i} className={styles.decadeViewRow}>
- {row.map((year, j) => {
+ {row.map(year => {
const isDisabled =
year.isAfter(DATE_MAX) || year.isBefore(DATE_MIN);
+ const yearValue = year.year();
return (
- <div key={j} className={styles.decadeViewBodyCell}>
+ <div key={yearValue} className={styles.decadeViewBodyCell}>
<button
aria-disabled={isDisabled}
data-value={year.format('YYYY')}
@@ -154,7 +156,7 @@ export const YearPicker = memo(function YearPicker(
isDisabled ? undefined : () => onYearChange(year)
}
>
- {year.year()}
+ {yearValue}
</button>
</div>
);
diff --git a/packages/frontend/component/src/ui/slider/slider.tsx b/packages/frontend/component/src/ui/slider/slider.tsx
index f2b8bbf9d4..89e23a1c91 100644
--- a/packages/frontend/component/src/ui/slider/slider.tsx
+++ b/packages/frontend/component/src/ui/slider/slider.tsx
@@ -107,7 +107,7 @@ export const Slider = ({
{!!nodes &&
nodes.map((nodeValue, index) => (
<div
- key={index}
+ key={nodeValue}
className={styles.nodeStyle}
data-active={value && value[0] >= nodeValue}
data-disabled={disabled}
diff --git a/packages/frontend/core/src/components/affine/affine-error-boundary/error-basic/error-detail.tsx b/packages/frontend/core/src/components/affine/affine-error-boundary/error-basic/error-detail.tsx
index 5ac66a6fde..c2a8c2ad0c 100644
--- a/packages/frontend/core/src/components/affine/affine-error-boundary/error-basic/error-detail.tsx
+++ b/packages/frontend/core/src/components/affine/affine-error-boundary/error-basic/error-detail.tsx
@@ -75,6 +75,7 @@ export const ErrorDetail: FC<ErrorDetailProps> = props => {
}, [onButtonClick, resetError]);
const desc = descriptions.map((item, i) => (
+ // eslint-disable-next-line react/no-array-index-key
<p key={i} className={styles.text}>
{item}
</p>
diff --git a/packages/frontend/core/src/components/affine/ai-onboarding/slider.tsx b/packages/frontend/core/src/components/affine/ai-onboarding/slider.tsx
index b5499b7dfd..7f25120188 100644
--- a/packages/frontend/core/src/components/affine/ai-onboarding/slider.tsx
+++ b/packages/frontend/core/src/components/affine/ai-onboarding/slider.tsx
@@ -46,7 +46,7 @@ export const Slider = <T,>({
}}
>
{items?.map((item, index) => (
- <div key={index} className={styles.slideItem}>
+ <div key={`${item}-${index}`} className={styles.slideItem}>
{preload === undefined || Math.abs(index - activeIndex) <= preload
? itemRenderer?.(item, index)
: null}
diff --git a/packages/frontend/core/src/components/affine/onboarding/steps/edgeless-switch.tsx b/packages/frontend/core/src/components/affine/onboarding/steps/edgeless-switch.tsx
index f32534b9c0..94a8001083 100644
--- a/packages/frontend/core/src/components/affine/onboarding/steps/edgeless-switch.tsx
+++ b/packages/frontend/core/src/components/affine/onboarding/steps/edgeless-switch.tsx
@@ -210,6 +210,7 @@ export const EdgelessSwitch = ({
{
/* render blocks */
article.blocks.map((block, key) => {
+ // eslint-disable-next-line react/no-array-index-key
return <OnboardingBlock key={key} mode={mode} {...block} />;
})
}
diff --git a/packages/frontend/core/src/components/blocksuite/block-suite-editor/specs/custom/spec-patchers.tsx b/packages/frontend/core/src/components/blocksuite/block-suite-editor/specs/custom/spec-patchers.tsx
index a8d9c7f082..10dac44335 100644
--- a/packages/frontend/core/src/components/blocksuite/block-suite-editor/specs/custom/spec-patchers.tsx
+++ b/packages/frontend/core/src/components/blocksuite/block-suite-editor/specs/custom/spec-patchers.tsx
@@ -584,17 +584,17 @@ export function patchForMobile() {
// Disable some toolbar widgets for mobile.
{
di.override(WidgetViewMapIdentifier('affine:page'), () => {
- const ignoreWidgets = [
+ const ignoreWidgets = new Set([
AFFINE_FORMAT_BAR_WIDGET,
AFFINE_EMBED_CARD_TOOLBAR_WIDGET,
- ];
+ ]);
type pageRootWidgetViewMapKey = keyof typeof pageRootWidgetViewMap;
return (
Object.keys(pageRootWidgetViewMap) as pageRootWidgetViewMapKey[]
).reduce(
(acc, key) => {
- if (ignoreWidgets.includes(key)) return acc;
+ if (ignoreWidgets.has(key)) return acc;
acc[key] = pageRootWidgetViewMap[key];
return acc;
},
diff --git a/packages/frontend/core/src/components/doc-properties/icons/icons-selector.tsx b/packages/frontend/core/src/components/doc-properties/icons/icons-selector.tsx
index e92668f177..6e02a826be 100644
--- a/packages/frontend/core/src/components/doc-properties/icons/icons-selector.tsx
+++ b/packages/frontend/core/src/components/doc-properties/icons/icons-selector.tsx
@@ -26,9 +26,9 @@ const IconsSelectorPanel = ({
</div>
<Scrollable.Viewport className={styles.iconsContainerScrollable}>
<div className={styles.iconsContainer}>
- {iconRows.map((iconRow, index) => {
+ {iconRows.map(iconRow => {
return (
- <div key={index} className={styles.iconsRow}>
+ <div key={iconRow.join('-')} className={styles.iconsRow}>
{iconRow.map(iconName => {
const Icon = iconNameToComponent(iconName);
return (
diff --git a/packages/frontend/core/src/components/page-list/collections/virtualized-collection-list.tsx b/packages/frontend/core/src/components/page-list/collections/virtualized-collection-list.tsx
index f20521165d..52372ddbb4 100644
--- a/packages/frontend/core/src/components/page-list/collections/virtualized-collection-list.tsx
+++ b/packages/frontend/core/src/components/page-list/collections/virtualized-collection-list.tsx
@@ -63,8 +63,8 @@ export const VirtualizedCollectionList = ({
});
const filteredSelectedCollectionIds = useMemo(() => {
- const ids = collections.map(collection => collection.id);
- return selectedCollectionIds.filter(id => ids.includes(id));
+ const ids = new Set(collections.map(collection => collection.id));
+ return selectedCollectionIds.filter(id => ids.has(id));
}, [collections, selectedCollectionIds]);
const hideFloatingToolbar = useCallback(() => {
diff --git a/packages/frontend/core/src/components/page-list/docs/virtualized-page-list.tsx b/packages/frontend/core/src/components/page-list/docs/virtualized-page-list.tsx
index cc0204c536..0d0fb67a83 100644
--- a/packages/frontend/core/src/components/page-list/docs/virtualized-page-list.tsx
+++ b/packages/frontend/core/src/components/page-list/docs/virtualized-page-list.tsx
@@ -83,8 +83,8 @@ export const VirtualizedPageList = ({
}, [filteredPageMetas, listItem]);
const filteredSelectedPageIds = useMemo(() => {
- const ids = pageMetasToRender.map(page => page.id);
- return selectedPageIds.filter(id => ids.includes(id));
+ const ids = new Set(pageMetasToRender.map(page => page.id));
+ return selectedPageIds.filter(id => ids.has(id));
}, [pageMetasToRender, selectedPageIds]);
const hideFloatingToolbar = useCallback(() => {
diff --git a/packages/frontend/core/src/components/page-list/filter/condition.tsx b/packages/frontend/core/src/components/page-list/filter/condition.tsx
index 5987d6bdbb..f4c510b122 100644
--- a/packages/frontend/core/src/components/page-list/filter/condition.tsx
+++ b/packages/frontend/core/src/components/page-list/filter/condition.tsx
@@ -163,7 +163,7 @@ export const renderArgs = (
const value = filter.args[i];
return (
<Arg
- key={i}
+ key={`${argType.type}-${i}`}
type={argType}
value={value}
onChange={value => {
diff --git a/packages/frontend/core/src/components/page-list/scoped-atoms.tsx b/packages/frontend/core/src/components/page-list/scoped-atoms.tsx
index 44d0ccf4b7..226994695c 100644
--- a/packages/frontend/core/src/components/page-list/scoped-atoms.tsx
+++ b/packages/frontend/core/src/components/page-list/scoped-atoms.tsx
@@ -136,12 +136,12 @@ const defaultSortingFn: SorterConfig<MetaRecord<ListItem>>['sortingFn'] = (
return 0;
};
-const validKeys: Array<keyof MetaRecord<ListItem>> = [
+const validKeys: Set<keyof MetaRecord<ListItem>> = new Set([
'id',
'title',
'createDate',
'updatedDate',
-];
+]);
const sorterStateAtom = atom<SorterConfig<MetaRecord<ListItem>>>({
key: DEFAULT_SORT_KEY,
@@ -175,7 +175,7 @@ export const sorterAtom = atom(
},
(_get, set, { newSortKey }: { newSortKey: keyof MetaRecord<ListItem> }) => {
set(sorterStateAtom, sorterState => {
- if (validKeys.includes(newSortKey)) {
+ if (validKeys.has(newSortKey)) {
return {
...sorterState,
key: newSortKey,
diff --git a/packages/frontend/core/src/components/page-list/tags/virtualized-tag-list.tsx b/packages/frontend/core/src/components/page-list/tags/virtualized-tag-list.tsx
index 113916a21f..cc7d485089 100644
--- a/packages/frontend/core/src/components/page-list/tags/virtualized-tag-list.tsx
+++ b/packages/frontend/core/src/components/page-list/tags/virtualized-tag-list.tsx
@@ -36,8 +36,8 @@ export const VirtualizedTagList = ({
);
const filteredSelectedTagIds = useMemo(() => {
- const ids = tags.map(tag => tag.id);
- return selectedTagIds.filter(id => ids.includes(id));
+ const ids = new Set(tags.map(tag => tag.id));
+ return selectedTagIds.filter(id => ids.has(id));
}, [selectedTagIds, tags]);
const hideFloatingToolbar = useCallback(() => {
diff --git a/packages/frontend/core/src/components/page-list/virtualized-trash-list.tsx b/packages/frontend/core/src/components/page-list/virtualized-trash-list.tsx
index a70e60641a..8dbbffd04a 100644
--- a/packages/frontend/core/src/components/page-list/virtualized-trash-list.tsx
+++ b/packages/frontend/core/src/components/page-list/virtualized-trash-list.tsx
@@ -33,8 +33,8 @@ export const VirtualizedTrashList = () => {
const pageHeaderColsDef = usePageHeaderColsDef();
const filteredSelectedPageIds = useMemo(() => {
- const ids = filteredPageMetas.map(page => page.id);
- return selectedPageIds.filter(id => ids.includes(id));
+ const ids = new Set(filteredPageMetas.map(page => page.id));
+ return selectedPageIds.filter(id => ids.has(id));
}, [filteredPageMetas, selectedPageIds]);
const hideFloatingToolbar = useCallback(() => {
diff --git a/packages/frontend/core/src/components/tags/tag-edit-menu.tsx b/packages/frontend/core/src/components/tags/tag-edit-menu.tsx
index d9165e4318..6a835c9e76 100644
--- a/packages/frontend/core/src/components/tags/tag-edit-menu.tsx
+++ b/packages/frontend/core/src/components/tags/tag-edit-menu.tsx
@@ -87,12 +87,12 @@ const DesktopTagEditMenu = ({
<MenuSeparator />
<Scrollable.Root>
<Scrollable.Viewport className={styles.menuItemList}>
- {colors.map(({ name, value: color }, i) => (
+ {colors.map(({ name, value: color }) => (
<MenuItem
- key={i}
+ key={color}
checked={tag.color === color}
prefixIcon={
- <div key={i} className={styles.tagColorIconWrapper}>
+ <div className={styles.tagColorIconWrapper}>
<div
className={styles.tagColorIcon}
style={{
@@ -173,14 +173,14 @@ const MobileTagEditMenu = ({
/>
<ConfigModal.RowGroup title={t['Colors']()}>
- {colors.map(({ name, value: color }, i) => (
+ {colors.map(({ name, value: color }) => (
<ConfigModal.Row
- key={i}
+ key={color}
onClick={() => {
setLocalTag({ ...localTag, color });
}}
>
- <div key={i} className={styles.tagColorIconWrapper}>
+ <div className={styles.tagColorIconWrapper}>
<div
className={styles.tagColorIcon}
style={{
diff --git a/packages/frontend/core/src/desktop/dialogs/doc-info/links-row.tsx b/packages/frontend/core/src/desktop/dialogs/doc-info/links-row.tsx
index 8be18ad8bc..d2a82cea76 100644
--- a/packages/frontend/core/src/desktop/dialogs/doc-info/links-row.tsx
+++ b/packages/frontend/core/src/desktop/dialogs/doc-info/links-row.tsx
@@ -21,9 +21,9 @@ export const LinksRow = ({
title={`${label} · ${references.length}`}
className={className}
>
- {references.map((link, index) => (
+ {references.map(link => (
<AffinePageReference
- key={index}
+ key={link.docId}
pageId={link.docId}
params={'params' in link ? link.params : undefined}
className={styles.wrapper}
diff --git a/packages/frontend/core/src/mobile/components/explorer/tree/node.tsx b/packages/frontend/core/src/mobile/components/explorer/tree/node.tsx
index 4af80579c9..cecf8f6865 100644
--- a/packages/frontend/core/src/mobile/components/explorer/tree/node.tsx
+++ b/packages/frontend/core/src/mobile/components/explorer/tree/node.tsx
@@ -116,7 +116,7 @@ export const ExplorerTreeNode = ({
}}
>
<MobileMenu
- items={menuOperations.map(({ view }, index) => (
+ items={menuOperations.map(({ view, index }) => (
<Fragment key={index}>{view}</Fragment>
))}
>
diff --git a/packages/frontend/core/src/mobile/views/recent-docs/index.tsx b/packages/frontend/core/src/mobile/views/recent-docs/index.tsx
index 3db902f023..3d4f0e60f0 100644
--- a/packages/frontend/core/src/mobile/views/recent-docs/index.tsx
+++ b/packages/frontend/core/src/mobile/views/recent-docs/index.tsx
@@ -31,8 +31,8 @@ export const RecentDocs = ({ max = 5 }: { max?: number }) => {
>
<div className={styles.scroll} data-testid="recent-docs-list">
<ul className={styles.list}>
- {cardMetas.map((doc, index) => (
- <li key={index} className={styles.cardWrapper}>
+ {cardMetas.map(doc => (
+ <li key={doc.id} className={styles.cardWrapper}>
<DocCard meta={doc} />
</li>
))}
diff --git a/packages/frontend/core/src/modules/app-sidebar/views/index.tsx b/packages/frontend/core/src/modules/app-sidebar/views/index.tsx
index 4ea22eee3d..fad22d1074 100644
--- a/packages/frontend/core/src/modules/app-sidebar/views/index.tsx
+++ b/packages/frontend/core/src/modules/app-sidebar/views/index.tsx
@@ -285,6 +285,7 @@ const RandomBars = ({ count, header }: { count: number; header?: boolean }) => {
/>
) : null}
{Array.from({ length: count }).map((_, index) => (
+ // eslint-disable-next-line react/no-array-index-key
<RandomBar key={index} />
))}
</div>
diff --git a/packages/frontend/core/src/modules/app-tabs-header/views/app-tabs-header.tsx b/packages/frontend/core/src/modules/app-tabs-header/views/app-tabs-header.tsx
index c059cb812c..9d0d088623 100644
--- a/packages/frontend/core/src/modules/app-tabs-header/views/app-tabs-header.tsx
+++ b/packages/frontend/core/src/modules/app-tabs-header/views/app-tabs-header.tsx
@@ -39,7 +39,7 @@ import {
} from '../services/app-tabs-header-service';
import * as styles from './styles.css';
-const TabSupportType = ['collection', 'tag', 'doc'];
+const TabSupportType = new Set(['collection', 'tag', 'doc']);
const tabCanDrop =
(tab?: TabStatus): NonNullable<DropTargetOptions<AffineDNDData>['canDrop']> =>
@@ -53,7 +53,7 @@ const tabCanDrop =
if (
ctx.source.data.entity?.type &&
- TabSupportType.includes(ctx.source.data.entity?.type)
+ TabSupportType.has(ctx.source.data.entity?.type)
) {
return true;
}
diff --git a/packages/frontend/core/src/modules/explorer/views/tree/node.tsx b/packages/frontend/core/src/modules/explorer/views/tree/node.tsx
index c6eb3baa1f..42b8a45eea 100644
--- a/packages/frontend/core/src/modules/explorer/views/tree/node.tsx
+++ b/packages/frontend/core/src/modules/explorer/views/tree/node.tsx
@@ -383,12 +383,12 @@ export const ExplorerTreeNode = ({
e.preventDefault();
}}
>
- {inlineOperations.map(({ view }, index) => (
+ {inlineOperations.map(({ view, index }) => (
<Fragment key={index}>{view}</Fragment>
))}
{menuOperations.length > 0 && (
<Menu
- items={menuOperations.map(({ view }, index) => (
+ items={menuOperations.map(({ view, index }) => (
<Fragment key={index}>{view}</Fragment>
))}
>
diff --git a/packages/frontend/core/src/modules/quicksearch/views/cmdk.tsx b/packages/frontend/core/src/modules/quicksearch/views/cmdk.tsx
index c215cae503..20421f558b 100644
--- a/packages/frontend/core/src/modules/quicksearch/views/cmdk.tsx
+++ b/packages/frontend/core/src/modules/quicksearch/views/cmdk.tsx
@@ -314,9 +314,9 @@ const CMDKKeyBinding = ({ keyBinding }: { keyBinding: string }) => {
return (
<div className={styles.keybinding}>
- {fragments.map((fragment, index) => {
+ {fragments.map(fragment => {
return (
- <div key={index} className={styles.keybindingFragment}>
+ <div key={fragment} className={styles.keybindingFragment}>
{fragment}
</div>
);
diff --git a/packages/frontend/core/src/modules/quicksearch/views/highlight-text.tsx b/packages/frontend/core/src/modules/quicksearch/views/highlight-text.tsx
index 24ec737753..8ce2a8bfce 100644
--- a/packages/frontend/core/src/modules/quicksearch/views/highlight-text.tsx
+++ b/packages/frontend/core/src/modules/quicksearch/views/highlight-text.tsx
@@ -30,11 +30,11 @@ export const HighlightText = ({ text = '', end, start }: HighlightProps) => {
return (
<span className={styles.highlightText}>
- {parts.map((part, i) =>
+ {parts.map(part =>
typeof part === 'string' ? (
- <Fragment key={i}>{part}</Fragment>
+ <Fragment key={part}>{part}</Fragment>
) : (
- <span key={i} className={styles.highlightKeyword}>
+ <span key={part.h} className={styles.highlightKeyword}>
{part.h}
</span>
)
diff --git a/yarn.lock b/yarn.lock
index 84f044fc8a..d72c904e3a 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -690,7 +690,7 @@ __metadata:
msw: "npm:^2.3.0"
nx: "npm:^20.0.3"
nx-cloud: "npm:^19.1.0"
- oxlint: "npm:0.12.0"
+ oxlint: "npm:0.13.2"
prettier: "npm:^3.3.3"
semver: "npm:^7.6.0"
serve: "npm:^14.2.1"
@@ -9495,58 +9495,58 @@ __metadata:
languageName: node
linkType: hard
-"@oxlint/darwin-arm64@npm:0.12.0":
- version: 0.12.0
- resolution: "@oxlint/darwin-arm64@npm:0.12.0"
+"@oxlint/darwin-arm64@npm:0.13.2":
+ version: 0.13.2
+ resolution: "@oxlint/darwin-arm64@npm:0.13.2"
conditions: os=darwin & cpu=arm64
languageName: node
linkType: hard
-"@oxlint/darwin-x64@npm:0.12.0":
- version: 0.12.0
- resolution: "@oxlint/darwin-x64@npm:0.12.0"
+"@oxlint/darwin-x64@npm:0.13.2":
+ version: 0.13.2
+ resolution: "@oxlint/darwin-x64@npm:0.13.2"
conditions: os=darwin & cpu=x64
languageName: node
linkType: hard
-"@oxlint/linux-arm64-gnu@npm:0.12.0":
- version: 0.12.0
- resolution: "@oxlint/linux-arm64-gnu@npm:0.12.0"
+"@oxlint/linux-arm64-gnu@npm:0.13.2":
+ version: 0.13.2
+ resolution: "@oxlint/linux-arm64-gnu@npm:0.13.2"
conditions: os=linux & cpu=arm64 & libc=glibc
languageName: node
linkType: hard
-"@oxlint/linux-arm64-musl@npm:0.12.0":
- version: 0.12.0
- resolution: "@oxlint/linux-arm64-musl@npm:0.12.0"
+"@oxlint/linux-arm64-musl@npm:0.13.2":
+ version: 0.13.2
+ resolution: "@oxlint/linux-arm64-musl@npm:0.13.2"
conditions: os=linux & cpu=arm64 & libc=musl
languageName: node
linkType: hard
-"@oxlint/linux-x64-gnu@npm:0.12.0":
- version: 0.12.0
- resolution: "@oxlint/linux-x64-gnu@npm:0.12.0"
+"@oxlint/linux-x64-gnu@npm:0.13.2":
+ version: 0.13.2
+ resolution: "@oxlint/linux-x64-gnu@npm:0.13.2"
conditions: os=linux & cpu=x64 & libc=glibc
languageName: node
linkType: hard
-"@oxlint/linux-x64-musl@npm:0.12.0":
- version: 0.12.0
- resolution: "@oxlint/linux-x64-musl@npm:0.12.0"
+"@oxlint/linux-x64-musl@npm:0.13.2":
+ version: 0.13.2
+ resolution: "@oxlint/linux-x64-musl@npm:0.13.2"
conditions: os=linux & cpu=x64 & libc=musl
languageName: node
linkType: hard
-"@oxlint/win32-arm64@npm:0.12.0":
- version: 0.12.0
- resolution: "@oxlint/win32-arm64@npm:0.12.0"
+"@oxlint/win32-arm64@npm:0.13.2":
+ version: 0.13.2
+ resolution: "@oxlint/win32-arm64@npm:0.13.2"
conditions: os=win32 & cpu=arm64
languageName: node
linkType: hard
-"@oxlint/win32-x64@npm:0.12.0":
- version: 0.12.0
- resolution: "@oxlint/win32-x64@npm:0.12.0"
+"@oxlint/win32-x64@npm:0.13.2":
+ version: 0.13.2
+ resolution: "@oxlint/win32-x64@npm:0.13.2"
conditions: os=win32 & cpu=x64
languageName: node
linkType: hard
@@ -26744,18 +26744,18 @@ __metadata:
languageName: node
linkType: hard
-"oxlint@npm:0.12.0":
- version: 0.12.0
- resolution: "oxlint@npm:0.12.0"
- dependencies:
- "@oxlint/darwin-arm64": "npm:0.12.0"
- "@oxlint/darwin-x64": "npm:0.12.0"
- "@oxlint/linux-arm64-gnu": "npm:0.12.0"
- "@oxlint/linux-arm64-musl": "npm:0.12.0"
- "@oxlint/linux-x64-gnu": "npm:0.12.0"
- "@oxlint/linux-x64-musl": "npm:0.12.0"
- "@oxlint/win32-arm64": "npm:0.12.0"
- "@oxlint/win32-x64": "npm:0.12.0"
+"oxlint@npm:0.13.2":
+ version: 0.13.2
+ resolution: "oxlint@npm:0.13.2"
+ dependencies:
+ "@oxlint/darwin-arm64": "npm:0.13.2"
+ "@oxlint/darwin-x64": "npm:0.13.2"
+ "@oxlint/linux-arm64-gnu": "npm:0.13.2"
+ "@oxlint/linux-arm64-musl": "npm:0.13.2"
+ "@oxlint/linux-x64-gnu": "npm:0.13.2"
+ "@oxlint/linux-x64-musl": "npm:0.13.2"
+ "@oxlint/win32-arm64": "npm:0.13.2"
+ "@oxlint/win32-x64": "npm:0.13.2"
dependenciesMeta:
"@oxlint/darwin-arm64":
optional: true
@@ -26776,7 +26776,7 @@ __metadata:
bin:
oxc_language_server: bin/oxc_language_server
oxlint: bin/oxlint
- checksum: 10/5bff1a038776017ded1c4367b87d23e5a4b03ce26ad9d6968d21c77bc054d0a02c24fd6c85f58f8688181f08729a5d1900b50966bf560c50093e015cecc24a81
+ checksum: 10/6dd341961c4c1e1de7e2f3d16d0998f42961694497717c00047041611d023ae6b8c7f32b4431f1e7c37ed4fcf4e300cdb25a1bd46b55baeec4cda1b0479e6a2a
languageName: node
linkType: hard