Skip to content

There can be more than Notion and Miro. AFFiNE(pronounced [ə‘fain]) is a next-gen knowledge base that brings planning, sorting and creating all together. Privacy first, open-source, customizable and ready to use.

fix: use overflow: clip instead of js to prevent scrolling with pgup/pgdown (#6338)

pengx17d4c7d58b006a
diff --git a/packages/frontend/core/src/components/workspace/index.css.ts b/packages/frontend/core/src/components/workspace/index.css.ts
index 27d6004ffe..9674608a58 100644
--- a/packages/frontend/core/src/components/workspace/index.css.ts
+++ b/packages/frontend/core/src/components/workspace/index.css.ts
@@ -49,7 +49,7 @@ export const mainContainerStyle = style({
width: 0,
display: 'flex',
flex: 1,
- overflow: 'hidden',
+ overflow: 'clip',
maxWidth: '100%',
transition: 'margin-left 0.2s ease',
selectors: {
diff --git a/packages/frontend/core/src/pages/workspace/detail-page/detail-page.tsx b/packages/frontend/core/src/pages/workspace/detail-page/detail-page.tsx
index 93bd3b6a31..17e81f22cd 100644
--- a/packages/frontend/core/src/pages/workspace/detail-page/detail-page.tsx
+++ b/packages/frontend/core/src/pages/workspace/detail-page/detail-page.tsx
@@ -27,14 +27,13 @@ import {
} from '@toeverything/infra';
import clsx from 'clsx';
import { useSetAtom } from 'jotai';
-import type { KeyboardEventHandler, ReactElement } from 'react';
+import type { ReactElement } from 'react';
import {
memo,
useCallback,
useEffect,
useLayoutEffect,
useMemo,
- useRef,
useState,
} from 'react';
import { useParams } from 'react-router-dom';
@@ -203,17 +202,6 @@ const DetailPageImpl = memo(function DetailPageImpl() {
);
const isWindowsDesktop = environment.isDesktop && environment.isWindows;
- const scrollableRef = useRef<HTMLDivElement>(null);
- const keydownHandler: KeyboardEventHandler = useCallback(e => {
- // prevent pgup/pgdown from scrolling the page
- if (e.key === 'PageUp' || e.key === 'PageDown') {
- e.preventDefault();
- scrollableRef.current?.scrollBy({
- top: e.key === 'PageUp' ? -window.innerHeight : window.innerHeight,
- behavior: 'smooth',
- });
- }
- }, []);
return (
<>
@@ -230,8 +218,6 @@ const DetailPageImpl = memo(function DetailPageImpl() {
<TopTip pageId={currentPageId} workspace={currentWorkspace} />
<Scrollable.Root>
<Scrollable.Viewport
- ref={scrollableRef}
- onKeyDown={keydownHandler}
className={clsx(
'affine-page-viewport',
styles.affineDocViewport,