Skip to content

There can be more than Notion and Miro. AFFiNE(pronounced [ə‘fain]) is a next-gen knowledge base that brings planning, sorting and creating all together. Privacy first, open-source, customizable and ready to use.

fix(editor): edgeless note duplicated from embed-doc should be above other elements (#12028)

L-Sund57b9372aed7
diff --git a/blocksuite/affine/blocks/embed/src/embed-synced-doc-block/configs/toolbar.ts b/blocksuite/affine/blocks/embed/src/embed-synced-doc-block/configs/toolbar.ts
index d3ba26ef6b..b1789e7402 100644
--- a/blocksuite/affine/blocks/embed/src/embed-synced-doc-block/configs/toolbar.ts
+++ b/blocksuite/affine/blocks/embed/src/embed-synced-doc-block/configs/toolbar.ts
@@ -375,6 +375,7 @@ const builtinSurfaceToolbarConfig = {
DEFAULT_NOTE_WIDTH,
DEFAULT_NOTE_HEIGHT
).serialize(),
+ index: gfx.layer.generateIndex(),
displayMode: NoteDisplayMode.EdgelessOnly,
} satisfies Partial<NoteProps>,
ctx.store.root
diff --git a/tests/blocksuite/e2e/embed-synced-doc/edgeless.spec.ts b/tests/blocksuite/e2e/embed-synced-doc/edgeless.spec.ts
index ea0f795543..4571adcc5f 100644
--- a/tests/blocksuite/e2e/embed-synced-doc/edgeless.spec.ts
+++ b/tests/blocksuite/e2e/embed-synced-doc/edgeless.spec.ts
@@ -4,6 +4,8 @@ import { expect, type Page } from '@playwright/test';
import { clickView } from '../utils/actions/click.js';
import {
createNote,
+ createShapeElement,
+ getAllSortedIds,
getIds,
getSelectedBound,
getSelectedIds,
@@ -201,5 +203,21 @@ test.describe('Embed synced doc in edgeless mode', () => {
const noteBound = await getSelectedBound(page);
expect(isIntersected(embedDocBound, noteBound)).toBe(false);
});
+
+ test('edgeless note duplicated from embed-synced-doc should be above other elements', async ({
+ page,
+ }) => {
+ await createShapeElement(page, [0, 0], [100, 100]);
+ await page.locator('affine-embed-edgeless-synced-doc-block').click();
+ const toolbar = locateToolbar(page);
+ await toolbar.getByLabel('Duplicate as note').click();
+
+ const edgelessNotes = page.locator('affine-edgeless-note');
+ await expect(edgelessNotes).toHaveCount(2);
+ const duplicatedNoteId = (await getSelectedIds(page))[0];
+ const sortedIds = await getAllSortedIds(page);
+ //
+ expect(sortedIds[sortedIds.length - 1]).toBe(duplicatedNoteId);
+ });
});
});