Skip to content

There can be more than Notion and Miro. AFFiNE(pronounced [ə‘fain]) is a next-gen knowledge base that brings planning, sorting and creating all together. Privacy first, open-source, customizable and ready to use.

fix(electron): potential crash on quit (#8829)

pengx17df99e2ca9781
diff --git a/packages/frontend/apps/electron/src/main/helper-process.ts b/packages/frontend/apps/electron/src/main/helper-process.ts
index c5db28fa0a..f2b4e5a615 100644
--- a/packages/frontend/apps/electron/src/main/helper-process.ts
+++ b/packages/frontend/apps/electron/src/main/helper-process.ts
@@ -78,8 +78,12 @@ class HelperProcessManager {
renderer.postMessage('helper-connection', null, [rendererPort]);
return () => {
- helperPort.close();
- rendererPort.close();
+ try {
+ helperPort.close();
+ rendererPort.close();
+ } catch (err) {
+ logger.error('[helper] close port error', err);
+ }
};
}
diff --git a/packages/frontend/apps/electron/src/preload/electron-api.ts b/packages/frontend/apps/electron/src/preload/electron-api.ts
index 6c63db6c2f..3f0d897e5b 100644
--- a/packages/frontend/apps/electron/src/preload/electron-api.ts
+++ b/packages/frontend/apps/electron/src/preload/electron-api.ts
@@ -157,7 +157,11 @@ const createMessagePortChannel = (port: MessagePort): EventBasedChannel => {
port.start();
return () => {
port.onmessage = null;
- port.close();
+ try {
+ port.close();
+ } catch (err) {
+ console.error('[helper] close port error', err);
+ }
};
},
send(data) {