Skip to content

There can be more than Notion and Miro. AFFiNE(pronounced [ə‘fain]) is a next-gen knowledge base that brings planning, sorting and creating all together. Privacy first, open-source, customizable and ready to use.

fix(core): deleted doc should not appear in tag pages (#8143)

JimmFlye822bbd2dd80
diff --git a/packages/frontend/core/src/components/page-list/tags/tag-list-item.tsx b/packages/frontend/core/src/components/page-list/tags/tag-list-item.tsx
index 7cc6c84a68..d3be08402d 100644
--- a/packages/frontend/core/src/components/page-list/tags/tag-list-item.tsx
+++ b/packages/frontend/core/src/components/page-list/tags/tag-list-item.tsx
@@ -13,7 +13,6 @@ import * as styles from './tag-list-item.css';
const TagListTitleCell = ({
title,
- pageCount,
}: Pick<TagListItemProps, 'title' | 'pageCount'>) => {
const t = useI18n();
return (
@@ -24,12 +23,13 @@ const TagListTitleCell = ({
>
{title || t['Untitled']()}
</div>
+ {/* //TODO(@EYHN): when indexer is ready, add this back
<div
data-testid="page-list-item-preview-text"
className={styles.titleCellPreview}
>
{` · ${t['com.affine.tags.count']({ count: pageCount || 0 })}`}
- </div>
+ </div> */}
</div>
);
};
diff --git a/packages/frontend/core/src/pages/workspace/tag/index.tsx b/packages/frontend/core/src/pages/workspace/tag/index.tsx
index e38fafbf48..5aa89b27b6 100644
--- a/packages/frontend/core/src/pages/workspace/tag/index.tsx
+++ b/packages/frontend/core/src/pages/workspace/tag/index.tsx
@@ -37,7 +37,9 @@ export const TagDetail = ({ tagId }: { tagId?: string }) => {
const filteredPageMetas = useMemo(() => {
const pageIdsSet = new Set(pageIds);
- return pageMetas.filter(page => pageIdsSet.has(page.id));
+ return pageMetas
+ .filter(page => pageIdsSet.has(page.id))
+ .filter(page => !page.trash);
}, [pageIds, pageMetas]);
const isActiveView = useIsActiveView();