Skip to content

There can be more than Notion and Miro. AFFiNE(pronounced [ə‘fain]) is a next-gen knowledge base that brings planning, sorting and creating all together. Privacy first, open-source, customizable and ready to use.

fix(editor): clicking the sorting button results in an error (#10800)

zzj3720f6a62fa73728
diff --git a/blocksuite/affine/data-view/src/core/data-view.ts b/blocksuite/affine/data-view/src/core/data-view.ts
index c183bd17e0..60ccf77a00 100644
--- a/blocksuite/affine/data-view/src/core/data-view.ts
+++ b/blocksuite/affine/data-view/src/core/data-view.ts
@@ -63,9 +63,7 @@ export class DataViewRenderer extends SignalWatcher(
}
`;
- private readonly _view = signal<{
- expose: DataViewInstance;
- }>();
+ private readonly _view = signal<DataViewInstance>();
@property({ attribute: false })
accessor config!: DataViewRendererConfig;
@@ -121,7 +119,7 @@ export class DataViewRenderer extends SignalWatcher(
});
focusFirstCell = () => {
- this.view?.expose.focusFirstCell();
+ this.view?.focusFirstCell();
};
openDetailPanel = (ops: {
@@ -224,7 +222,7 @@ export class DataView {
private readonly _ref = createRef<DataViewRenderer>();
get expose() {
- return this._ref.value?.view?.expose;
+ return this._ref.value?.view;
}
render(props: DataViewRendererConfig) {
diff --git a/blocksuite/affine/data-view/src/core/view/data-view.ts b/blocksuite/affine/data-view/src/core/view/data-view.ts
index 2545a33012..109259ee9b 100644
--- a/blocksuite/affine/data-view/src/core/view/data-view.ts
+++ b/blocksuite/affine/data-view/src/core/view/data-view.ts
@@ -44,9 +44,7 @@ type DataViewComponent = UniComponent<
{
props: DataViewProps;
},
- {
- expose: DataViewInstance;
- }
+ DataViewInstance
>;
export interface DataViewRendererConfig {
diff --git a/blocksuite/affine/data-view/src/view-presets/table/pc/header/database-header-column.ts b/blocksuite/affine/data-view/src/view-presets/table/pc/header/database-header-column.ts
index fd72a699f3..94964de40c 100644
--- a/blocksuite/affine/data-view/src/view-presets/table/pc/header/database-header-column.ts
+++ b/blocksuite/affine/data-view/src/view-presets/table/pc/header/database-header-column.ts
@@ -169,8 +169,7 @@ export class DatabaseHeaderColumn extends SignalWatcher(
const sortUtils = createSortUtils(
sortTrait,
- this.closest('affine-data-view-renderer')?.view?.expose.eventTrace ??
- (() => {})
+ this.closest('affine-data-view-renderer')?.view?.eventTrace ?? (() => {})
);
const sortList = sortUtils.sortList$.value;
const existingIndex = sortList.findIndex(