ARES - authorized red-team engagement automation with dashboard, campaign scope, module orchestration, OPSEC controls, encrypted vault, and reporting.
Python active-directorycloud-securitydefensive-validationfastapigood-first-issuemitre-attackopsecreactred-teamreportingsecurity
fix: score finding confidence from evidence
Mafifrizi096bf107e64d
diff --git a/ares/core/validator.py b/ares/core/validator.pyindex 87973a5..98a885f 100644--- a/ares/core/validator.py+++ b/ares/core/validator.py@@ -176,6 +176,31 @@ async def _check_docker_socket_exploitable(return False, 0.1, "Docker socket exists but not accessible"+async def _check_ad_finding_evidence(+ finding: Finding, context: dict[str, Any]+) -> tuple[bool, float, str]:+ """Score AD findings from the evidence produced by the module itself."""+ evidence = finding.evidence+ module_id = finding.module_id++ if module_id in {"ad.asreproast", "ad.kerberoast"}:+ hash_count = int(evidence.get("hash_count", 0) or 0)+ if hash_count > 0:+ return True, 0.95, f"{hash_count} captured hash result(s)"+ return False, 0.0, "No captured hash evidence"++ if module_id == "ad.enum_spn":+ candidate_count = int(+ evidence.get("total_spns", 0)+ or len(evidence.get("accounts", []))+ )+ if candidate_count > 0:+ return True, 0.6, f"{candidate_count} SPN candidate account(s) enumerated"+ return False, 0.0, "No SPN candidate evidence"++ return False, 0.0, "Unsupported AD finding type"++# ── Default validator registry ────────────────────────────────────────────────def build_default_validator() -> FindingValidator:@@ -214,4 +239,13 @@ def build_default_validator() -> FindingValidator:),])+ for module_id in ("ad.asreproast", "ad.enum_spn", "ad.kerberoast"):+ v.register(module_id, [+ ValidationCheck(+ stage=ValidationStage.EXISTENCE,+ name="module_evidence_confidence",+ check=_check_ad_finding_evidence,+ ),+ ])+return vdiff --git a/tests/unit/core/test_core.py b/tests/unit/core/test_core.pyindex c3bcf38..f1ba3f3 100644--- a/tests/unit/core/test_core.py+++ b/tests/unit/core/test_core.py@@ -181,3 +181,41 @@ class TestValidator:result = await v.validate(f, {})assert result.confidence == 1.0assert result.passed is True++ @pytest.mark.asyncio+ async def test_ad_confidence_uses_module_evidence(self):+ from ares.core.validator import build_default_validator++ validator = build_default_validator()+ captured = Finding(+ title="AS-REP hash",+ description="Captured hash evidence",+ severity=Severity.HIGH,+ module_id="ad.asreproast",+ evidence={"hash_count": 1},+ )+ candidates = Finding(+ title="SPN candidates",+ description="Enumerated service accounts",+ severity=Severity.HIGH,+ module_id="ad.enum_spn",+ evidence={"total_spns": 2},+ )+ tgs = Finding(+ title="TGS hash",+ description="Captured TGS evidence",+ severity=Severity.CRITICAL,+ module_id="ad.kerberoast",+ evidence={"hash_count": 1},+ )++ captured_result = await validator.validate(captured, {})+ candidate_result = await validator.validate(candidates, {})+ tgs_result = await validator.validate(tgs, {})++ assert captured_result.confidence == 0.95+ assert candidates.confidence == 0.6+ assert tgs_result.confidence == 0.95+ assert captured_result.passed is True+ assert candidate_result.passed is True+ assert tgs_result.passed is Truediff --git a/tests/unit/test_cli_reporting_goal_planning.py b/tests/unit/test_cli_reporting_goal_planning.pyindex 5b3fba8..d8e30a2 100644--- a/tests/unit/test_cli_reporting_goal_planning.py+++ b/tests/unit/test_cli_reporting_goal_planning.py@@ -146,6 +146,7 @@ class TestReportGenerator:f = data["findings"][0]for key in ("id", "title", "severity", "confidence", "mitre_technique"):assert key in f, f"Missing key: {key}"+ assert f["confidence"] == campaign.findings[0].confidencedef test_generate_html_report(self):from ares.modules.reporting.report_gen import ReportGenerator