ARES - authorized red-team engagement automation with dashboard, campaign scope, module orchestration, OPSEC controls, encrypted vault, and reporting.
Python active-directorycloud-securitydefensive-validationfastapigood-first-issuemitre-attackopsecreactred-teamreportingsecurity
docs: audit batch 9 active directory discovery and posture enumeration (MOD-054 to MOD-057)
Mafifrizi0de15c43ca7a
diff --git a/AUDIT_PROGRESS.md b/AUDIT_PROGRESS.mdindex aa935c0..8f1ad02 100644--- a/AUDIT_PROGRESS.md+++ b/AUDIT_PROGRESS.md@@ -61,6 +61,10 @@ Tracking file for verified findings, reproduction tests, applied fixes, test sui| MOD-051 | cloud.identity_federation_abuse unhandled outputs federation_trusts, golden_saml_paths, oauth_tokens, pivot_paths (100% data loss) | DEFERRED | Audit verified (`identity_federation.py:77, 356-358`) | Menunggu remedi (Batch Fix Serentak Normalizer) | Keempat capability output yang dideklarasikan tidak memiliki handler di `ArtifactNormalizer`. Data pemetaan trust federasi dan Golden SAML hilang permanen dari `ArtifactStore`. || MOD-052 | cloud.aws_privesc type confusion mismatch: aws_findings with list[Finding] overwrites S3 normalizer | FIXED | PASSED (Unit tests & pipeline separation) | `ares/modules/cloud/aws_privesc.py`, `tests/unit/test_artifact_normalizer_pipeline.py` | Key output diubah dari `raw["aws_findings"]` menjadi `raw["iam_privesc_paths"]` dan deklarasi diperbarui ke `OUTPUTS = ["aws_privesc_paths", "iam_privesc_paths"]`. Output tidak lagi menimpa dictionary S3 `cloud.aws` dan mencegah kontaminasi type confusion. || MOD-053 | cloud.aws_privesc & cloud.identity_federation_abuse unvalidated AWS account/tenant scope & generic host attribution | DEFERRED | Audit verified (`aws_privesc.py:331`, `identity_federation.py:1046, 1074`) | Menunggu keputusan arsitektur (Architectural Gap) | ScopeGuard saat ini hanya memvalidasi IP/CIDR/DNS, tidak mengenali cloud identifiers (tenant_id, aws_account_id, subscription_id). Butuh perancangan CloudScopeGuard / ScopeGuard extension. |+| MOD-054 | ad.enum_spn internal key mismatch (spn_list vs spns) causing 100% SPN list evaporation | TERBUKTI (HIGH) | Audit verified (`enum_spn.py:343, 131, 237`) | Menunggu remedi (Batch Fix Serentak Normalizer) | Method `_fetch_spns_sync` mengisi key `spn_list`, namun `execute()`, `run()`, dan `ArtifactNormalizer._normalize_spns` membaca key `spns`. SPN Kerberoasting candidate strings menguap menjadi list kosong `[]` di `UserArtifact.spns`, `EvidenceRecord`, dan `ArtifactIntelEngine`. |+| MOD-055 | ad.laps_enum output type confusion on valid_credentials (int vs list) & secret evaporation in normalizer | TERBUKTI (HIGH) | Audit verified (`laps_enum.py:274-275`, `artifacts.py:796, 1002`) | Menunggu remedi (Batch Fix Serentak Normalizer) | Modul menulis integer count (`found`) ke `raw["valid_credentials"]` yang ditolak normalizer MOD-033 (`list[dict]`). Password LAPS dihilangkan dari `raw["entries"]` demi OPSEC, menyebabkan `_normalize_laps_passwords` menghasilkan `CredentialArtifact` dengan `secret=""`. |+| MOD-056 | ad.enum_users unhandled output telemetry password_policy & dual-write omission | TERBUKTI (MEDIUM) | Audit verified (`enum_users.py:227`, `artifacts.py:529`) | Menunggu remedi (Batch Fix Serentak Normalizer) | Data kebijakan password domain (`minPwdLength`, `lockoutThreshold`) tidak memiliki handler di `ArtifactNormalizer`. Modul juga belum melakukan dual-write key standar `users` ke `raw`. |+| MOD-057 | ad.enum_acl & ad.laps_enum inconsistent LDAP bind authentication formatting (bypassing build_ad_bind_plan) | TERBUKTI (MEDIUM) | Audit verified (`enum_acl.py:234`, `laps_enum.py:297`) | Menunggu remedi (Batch Fix Serentak) | Modul menggunakan konkatenasi string mentah `user=f"{domain.upper()}\\{username}"` tanpa melewati fungsi normalisasi `build_ad_bind_plan()`, berisiko memicu bind failure saat format UPN atau domain alternatif digunakan. |---@@ -173,6 +177,31 @@ Tracking file for verified findings, reproduction tests, applied fixes, test suiC. Validasi cloud identifier di layer campaign configuration- **Catatan**: Keputusan ini mempengaruhi semua cloud modules (Batch 8+) dan butuh review owner sebelum diimplementasikan.+---++## BATCH FIX SERENTAK DEFERRED NOTES (Batch 9)++### [MOD-054] Internal Key Mismatch (`spn_list` vs `spns`) on `ad.enum_spn`+- **Severity**: **HIGH**+- **Status**: **DEFERRED (Masuk batch fix serentak normalizer)**+- **Catatan**: Seluruh daftar string SPN Kerberoasting menguap menjadi list kosong karena perbedaan nama key internal. Akan difix serentak bersama normalizer alignment.++### [MOD-055] Output Type Confusion on `raw["valid_credentials"]` & Secret Evaporation on `ad.laps_enum`+- **Severity**: **HIGH**+- **Status**: **DEFERRED (Masuk batch fix serentak normalizer)**+- **Catatan**: Type mismatch (int vs list[dict]) pada `valid_credentials` dan empty secret pada normalizer LAPS. Password tersimpan di vault riil via `_vault.store()`, namun pipeline telemetry terputus.++### [MOD-056] Unhandled Output Telemetry `password_policy` on `ad.enum_users`+- **Severity**: **MEDIUM**+- **Status**: **DEFERRED (Masuk batch fix serentak normalizer)**+- **Catatan**: Parameter lockout dan panjang password tidak diserap ke `ArtifactStore`. Akan ditambahkan handler khusus policy/domain artifact.++### [MOD-057] Inconsistent LDAP Bind Authentication Formatting on `ad.enum_acl` & `ad.laps_enum`+- **Severity**: **MEDIUM**+- **Status**: **DEFERRED (Masuk batch fix serentak)**+- **Catatan**: Migrasi raw string binding ke `build_ad_bind_plan()` untuk menjamin kompatibilitas format UPN (`[email protected]`) pada seluruh modul Active Directory.++diff --git a/MODULE_AUDIT_INVENTORY.md b/MODULE_AUDIT_INVENTORY.mdindex eb019b1..44ebc2d 100644--- a/MODULE_AUDIT_INVENTORY.md+++ b/MODULE_AUDIT_INVENTORY.md@@ -374,16 +374,22 @@ Seluruh modul **TIER 1 (Critical)** dan **TIER 2 (High)** telah dikelompokkan ke- [`ares/modules/cloud/identity_federation.py`](file:///c:/Users/ASUS/Desktop/ARES/ares/modules/cloud/identity_federation.py) — *Cloud Identity Federation Abuse (`cloud.identity_federation_abuse`)* (1,190 baris)- [`ares/modules/cloud/phantom_token.py`](file:///c:/Users/ASUS/Desktop/ARES/ares/modules/cloud/phantom_token.py) — *Hybrid Entra ID PRT Hijack (`cloud.phantom_token`)* (385 baris)-### Batch 9: Active Directory Discovery & Security Posture Enumeration (TIER 2 - HIGH)+### Batch 9: Active Directory Discovery & Security Posture Enumeration (TIER 2 - HIGH) - [STATUS: AUDITED]- **Deskripsi**: Modul recon LDAP dan pembacaan read-only objek direktori Active Directory (Users, Computers, SPN, ACLs, dan LAPS password attributes).-- **Fokus Risiko Audit**: Ketahanan parsing query LDAP terhadap karakter kontrol/malformed input, kebocoran query LDAP berlebihan, validasi scope target domain controller.+- **Fokus Risiko Audit**: Ketahanan parsing query LDAP terhadap karakter kontrol/malformed input, kebocoran query LDAP berlebihan, validasi scope target domain controller, verifikasi Gate 6 vault write guard.+- **Status Audit**: **SELESAI (AUDITED)**+- **Hasil Temuan**: **4 Temuan Terkonfirmasi** (0 Critical, 2 High, 2 Medium)+ - `MOD-054` (High): Internal Key Mismatch (`spn_list` vs `spns`) pada `ad.enum_spn` menyebabkan 100% SPN list Kerberoasting menguap menjadi list kosong (`[]`) di `UserArtifact.spns`, `EvidenceRecord`, dan `ArtifactIntelEngine`.+ - `MOD-055` (High): Output Type Confusion pada `raw["valid_credentials"]` (integer count alih-alih `list[dict]`) & Secret Evaporation pada `ArtifactNormalizer._normalize_laps_passwords` (`secret=""`) pada `ad.laps_enum`.+ - `MOD-056` (Medium): Unhandled Output Telemetry `password_policy` (informasi lockout threshold hilang dari `ArtifactStore`) & ketiadaan dual-write key standar `users` pada `ad.enum_users`.+ - `MOD-057` (Medium): Inconsistent LDAP Bind Authentication Formatting pada `ad.enum_acl` dan `ad.laps_enum` (`user=f"{domain.upper()}\\{username}"` tanpa `build_ad_bind_plan`, berisiko memicu bind failure saat format UPN digunakan).- **Jumlah File**: 5 file- **Daftar File**:- - [`ares/modules/ad/enum_users.py`](file:///c:/Users/ASUS/Desktop/ARES/ares/modules/ad/enum_users.py) — *AD User Enumeration (`ad.enum_users`)* (430 baris)- - [`ares/modules/ad/enum_computers.py`](file:///c:/Users/ASUS/Desktop/ARES/ares/modules/ad/enum_computers.py) — *AD Computer Enumeration (`ad.enum_computers`)* (352 baris)- - [`ares/modules/ad/enum_spn.py`](file:///c:/Users/ASUS/Desktop/ARES/ares/modules/ad/enum_spn.py) — *AD SPN Enumeration (`ad.enum_spn`)* (384 baris)- - [`ares/modules/ad/enum_acl.py`](file:///c:/Users/ASUS/Desktop/ARES/ares/modules/ad/enum_acl.py) — *AD ACL Enumeration (`ad.enum_acl`)* (371 baris)- - [`ares/modules/ad/laps_enum.py`](file:///c:/Users/ASUS/Desktop/ARES/ares/modules/ad/laps_enum.py) — *LAPS Password Enumeration (`ad.laps_enum`)* (400 baris)+ - [`ares/modules/ad/enum_users.py`](file:///c:/Users/ASUS/Desktop/ARES/ares/modules/ad/enum_users.py) — *AD User Enumeration (`ad.enum_users`)* (431 baris)+ - [`ares/modules/ad/enum_computers.py`](file:///c:/Users/ASUS/Desktop/ARES/ares/modules/ad/enum_computers.py) — *AD Computer Enumeration (`ad.enum_computers`)* (353 baris)+ - [`ares/modules/ad/enum_spn.py`](file:///c:/Users/ASUS/Desktop/ARES/ares/modules/ad/enum_spn.py) — *AD SPN Enumeration (`ad.enum_spn`)* (385 baris)+ - [`ares/modules/ad/enum_acl.py`](file:///c:/Users/ASUS/Desktop/ARES/ares/modules/ad/enum_acl.py) — *AD ACL Enumeration (`ad.enum_acl`)* (372 baris)+ - [`ares/modules/ad/laps_enum.py`](file:///c:/Users/ASUS/Desktop/ARES/ares/modules/ad/laps_enum.py) — *LAPS Password Enumeration (`ad.laps_enum`)* (401 baris)### Batch 10: Network Reconnaissance & Service Fingerprinting (TIER 2 - HIGH)- **Deskripsi**: Modul discovery pasif dan semi-aktif jaringan (Target Fingerprinting, DNS Enumeration, HTTP Header Banner, Service Version Detection, SNMP MIB Walk).diff --git a/NORMALIZER_CONTRACT_AUDIT.md b/NORMALIZER_CONTRACT_AUDIT.mdindex bf12144..5c9b79c 100644--- a/NORMALIZER_CONTRACT_AUDIT.md+++ b/NORMALIZER_CONTRACT_AUDIT.md@@ -80,6 +80,9 @@ Tabel di bawah ini memetakan seluruh 9 capability yang memiliki handler di `ares| `pivot_paths` | `cloud.identity_federation_abuse` | — | `pivot_paths` | ❌ **MISMATCH** (MOD-051) | Tidak ada handler normalizer (`no handler`). Analisis jalur pivot lintas-cloud hilang dari `ArtifactStore`. || `aws_privesc_paths` | `cloud.aws_privesc` | — | `aws_privesc_paths` | ❌ **MISMATCH** (MOD-052) | Tidak ada handler normalizer (`no handler`). Jalur eskalasi hak akses IAM hilang dari `ArtifactStore`. || `iam_privesc_paths` | `cloud.aws_privesc` | — | `iam_privesc_paths` | ⚠️ **NEW KEY** (aws_privesc, handler pending) | Key baru pasca-fix MOD-052 untuk memisahkan output privesc IAM dari `aws_findings` milik `cloud.aws`. Handler normalizer pending. |+| `spn_list` (inner keys) | `ad.enum_spn` | `s["spns"]` OR `s["spn"]` | `s["spn_list"]` | ❌ **MISMATCH** (MOD-054) | Inner object key mismatch (`spn_list` vs `spns`), menyebabkan atribut `UserArtifact.spns` bernilai list kosong `[]`. |+| `valid_credentials` | `ad.laps_enum` | `list[dict]` | `int` (`found`) | ❌ **MISMATCH** (MOD-055) | Type confusion (integer count vs `list[dict]`). Normalizer memblokir tipe non-list sehingga menghasilkan 0 artifact. |+| `password_policy` | `ad.enum_users` | — | `password_policy` | ❌ **MISMATCH** (MOD-056) | Unhandled output telemetry (`no handler`). Data ambang lockout domain hilang dari `ArtifactStore`. |---