Skip to content

armgit / ARES

Public Imported from GitHub
0

ARES - authorized red-team engagement automation with dashboard, campaign scope, module orchestration, OPSEC controls, encrypted vault, and reporting.

feat(a11y): add global keyboard focus-visible styles and tests

Mafifrizi4e025de5a5cb
diff --git a/frontend/src/features/dashboard/KeyboardFocusVisible.test.tsx b/frontend/src/features/dashboard/KeyboardFocusVisible.test.tsx
new file mode 100644
index 0000000..297d9ba
--- /dev/null
+++ b/frontend/src/features/dashboard/KeyboardFocusVisible.test.tsx
@@ -0,0 +1,139 @@
+// @vitest-environment jsdom
+import "../../test/setup";
+import "@testing-library/jest-dom/vitest";
+import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
+import { cleanup, fireEvent, render, screen } from "@testing-library/react";
+import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
+import { MemoryRouter, Route, Routes } from "react-router-dom";
+import fs from "node:fs";
+import path from "node:path";
+
+vi.mock("../auth/authContext", () => ({
+ useAuth: () => ({
+ user: { username: "operator", role: "operator" },
+ loading: false,
+ logout: vi.fn(),
+ logoutAll: vi.fn()
+ })
+}));
+
+vi.mock("../../api/client", async () => {
+ const actual = await vi.importActual("../../api/client");
+ return {
+ ...actual,
+ api: {
+ health: vi.fn(async () => ({ status: "ok" })),
+ telemetry: vi.fn(async () => ({})),
+ campaigns: vi.fn(async () => [
+ { id: "cmp-1", name: "Campaign 1", status: "active" }
+ ]),
+ modules: vi.fn(async () => []),
+ templates: vi.fn(async () => []),
+ executionChains: vi.fn(async () => []),
+ reports: vi.fn(async () => ({ campaign_id: "", reports: [] })),
+ monthlyStats: vi.fn(async () => ({ total: 0, confirmed_findings: 0, series: [] }))
+ }
+ };
+});
+
+import { clearDashboardSession } from "./dashboardUiState";
+import { DashboardShell, OverviewPage } from "./DashboardPages";
+
+describe("Keyboard Focus Visible & Accessibility (ITEM 9)", () => {
+ beforeEach(() => {
+ localStorage.clear();
+ sessionStorage.clear();
+ clearDashboardSession();
+ vi.clearAllMocks();
+ });
+
+ afterEach(() => {
+ cleanup();
+ });
+
+ it("verifies styles.css contains the global focus-visible rules and ARES accent token", () => {
+ const cssPath = path.resolve(__dirname, "../../styles.css");
+ const cssContent = fs.readFileSync(cssPath, "utf-8");
+
+ // 1. Accent color variable defined
+ expect(cssContent).toMatch(/--ares-accent:\s*#b91c1c/i);
+
+ // 2. Global *:focus outline: none reset
+ expect(cssContent).toMatch(/\*:focus\s*\{\s*outline:\s*none;?\s*\}/);
+
+ // 3. Global *:focus-visible rule with 2px accent outline, 2px offset, and 4px border-radius
+ expect(cssContent).toMatch(
+ /\*:focus-visible\s*\{[\s\S]*?outline:\s*2px\s+solid\s+var\(--ares-accent,\s*#b91c1c\);?[\s\S]*?outline-offset:\s*2px;?[\s\S]*?border-radius:\s*4px;?[\s\S]*?\}/
+ );
+
+ // 4. Input fields custom focus-visible preserved without weird 2px outer outline
+ expect(cssContent).toMatch(
+ /\.field:focus,\s*\.field:focus-visible,\s*\.field-with-icon:focus-within\s*\{[\s\S]*?border-color:\s*#52525b;?[\s\S]*?outline:\s*1px\s+solid\s+#52525b;?[\s\S]*?outline-offset:\s*0;?[\s\S]*?\}/
+ );
+
+ // 5. Input within wrapper has outline: none on focus-visible
+ expect(cssContent).toMatch(/\.topbar-search input:focus-visible\s*\{\s*outline:\s*none;?\s*\}/);
+ expect(cssContent).toMatch(/\.field-with-icon input:focus-visible\s*\{\s*outline:\s*none;?\s*\}/);
+ expect(cssContent).toMatch(/\.topbar-scope-select:focus-visible\s*\{\s*outline:\s*none;?\s*\}/);
+
+ // 6. Search results button has focus-visible companion
+ expect(cssContent).toMatch(
+ /\.search-results button:focus-visible\s*\{[\s\S]*?outline:\s*2px\s+solid\s+var\(--ares-accent,\s*#b91c1c\);?[\s\S]*?outline-offset:\s*-2px;?[\s\S]*?\}/
+ );
+
+ // 7. Component-specific border-radius overrides
+ expect(cssContent).toMatch(/\.btn:focus-visible[\s\S]*?border-radius:\s*6px/);
+ expect(cssContent).toMatch(/\.panel:focus-visible[\s\S]*?border-radius:\s*8px/);
+ expect(cssContent).toMatch(/\.rounded-full:focus-visible[\s\S]*?border-radius:\s*999px/);
+ });
+
+ it("renders interactive elements in DashboardShell and supports keyboard focus navigation", async () => {
+ const queryClient = new QueryClient({
+ defaultOptions: { queries: { retry: false, staleTime: 0 } }
+ });
+
+ render(
+ <QueryClientProvider client={queryClient}>
+ <MemoryRouter initialEntries={["/"]}>
+ <DashboardShell>
+ <Routes>
+ <Route path="/" element={<OverviewPage />} />
+ </Routes>
+ </DashboardShell>
+ </MemoryRouter>
+ </QueryClientProvider>
+ );
+
+ // Topbar search input
+ const searchInput = screen.getByPlaceholderText(/Search campaigns, modules, reports/i);
+ expect(searchInput).toBeInTheDocument();
+
+ // Focus via keyboard
+ searchInput.focus();
+ expect(document.activeElement).toBe(searchInput);
+
+ // Topbar buttons
+ const notifBtn = screen.getByLabelText("Notifications");
+ expect(notifBtn).toBeInTheDocument();
+ notifBtn.focus();
+ expect(document.activeElement).toBe(notifBtn);
+
+ // Mouse click on button should focus element without throwing or breaking
+ fireEvent.mouseDown(notifBtn);
+ fireEvent.click(notifBtn);
+ expect(notifBtn).toBeInTheDocument();
+
+ // Topbar scope select
+ const scopeSelect = screen.getByLabelText("Active campaign scope");
+ expect(scopeSelect).toBeInTheDocument();
+ scopeSelect.focus();
+ expect(document.activeElement).toBe(scopeSelect);
+
+ // Navigation links in sidebar
+ const navLinks = screen.getAllByRole("link");
+ expect(navLinks.length).toBeGreaterThan(0);
+ const firstLink = navLinks[0];
+ firstLink.focus();
+ expect(document.activeElement).toBe(firstLink);
+ });
+});
diff --git a/frontend/src/styles.css b/frontend/src/styles.css
index 78709b9..5f6237e 100644
--- a/frontend/src/styles.css
+++ b/frontend/src/styles.css
@@ -3,6 +3,7 @@
@tailwind utilities;
:root {
+ --ares-accent: #b91c1c;
color: #f4f4f5;
background: #09090b;
font-family:
@@ -15,6 +16,16 @@
box-sizing: border-box;
}
+*:focus {
+ outline: none;
+}
+
+*:focus-visible {
+ outline: 2px solid var(--ares-accent, #b91c1c);
+ outline-offset: 2px;
+ border-radius: 4px;
+}
+
body {
margin: 0;
min-width: 320px;
@@ -343,6 +354,10 @@ button:disabled {
font-size: 0.84rem;
}
+.topbar-search input:focus-visible {
+ outline: none;
+}
+
.topbar-scope-wrap {
display: flex;
align-items: center;
@@ -353,6 +368,12 @@ button:disabled {
padding: 0.35rem 0.65rem;
color: #a1a1aa;
font-size: 0.8rem;
+ transition: border-color 120ms ease, box-shadow 120ms ease;
+}
+
+.topbar-scope-wrap:focus-within {
+ border-color: #52525b;
+ box-shadow: 0 0 0 1px #52525b;
}
.topbar-scope-select {
@@ -366,6 +387,10 @@ button:disabled {
max-width: 180px;
}
+.topbar-scope-select:focus-visible {
+ outline: none;
+}
+
.topbar-scope-select option {
background: #18181b;
color: #f4f4f5;
@@ -423,6 +448,12 @@ button:disabled {
outline: none;
}
+.search-results button:focus-visible {
+ background: #1c1c20;
+ outline: 2px solid var(--ares-accent, #b91c1c);
+ outline-offset: -2px;
+}
+
.search-results button:last-child {
border-bottom: 0;
}
@@ -1193,9 +1224,11 @@ button:disabled {
}
.field:focus,
+.field:focus-visible,
.field-with-icon:focus-within {
border-color: #52525b;
outline: 1px solid #52525b;
+ outline-offset: 0;
}
textarea.field {
@@ -1225,6 +1258,10 @@ textarea.field {
font-size: 0.84rem;
}
+.field-with-icon input:focus-visible {
+ outline: none;
+}
+
.toggle-row {
display: inline-flex;
align-items: center;
@@ -2824,4 +2861,42 @@ input:-webkit-autofill:focus {
box-shadow: 0 0 0 1000px #09090b inset, 0 0 0 1px #dc2626 !important;
}
+/* ==========================================================================
+ Keyboard Focus Visible & Accessibility Specific Overrides (Item 9)
+ Preserve component border-radii while keyboard focus-visible is active
+ ========================================================================== */
+
+.btn:focus-visible,
+.btn-compact:focus-visible,
+.icon-button:focus-visible,
+.icon-button-small:focus-visible,
+.nav-link:focus-visible,
+.topbar-status-btn:focus-visible,
+.topbar-heartbeat:focus-visible,
+.operator-trigger:focus-visible,
+.rounded-md:focus-visible,
+[class*="rounded-md"]:focus-visible {
+ border-radius: 6px;
+}
+
+.panel:focus-visible,
+.card:focus-visible,
+.notification-item:focus-visible,
+.rounded-lg:focus-visible,
+[class*="rounded-lg"]:focus-visible {
+ border-radius: 8px;
+}
+
+.rounded-full:focus-visible,
+[class*="rounded-full"]:focus-visible,
+.btn-rounded:focus-visible,
+.user-chip-avatar:focus-visible,
+.profile-avatar-light:focus-visible,
+.operator-avatar:focus-visible,
+.status-pill:focus-visible,
+.badge:focus-visible {
+ border-radius: 999px;
+}
+
+