Skip to content

armgit / ARES

Public Imported from GitHub
0

ARES - authorized red-team engagement automation with dashboard, campaign scope, module orchestration, OPSEC controls, encrypted vault, and reporting.

fix(descriptors): restore StagedCollection parameter contract and execute AST parity

Mafifrizi7b4afbb53ce6
diff --git a/ares/modules/exfil/staged_collection.py b/ares/modules/exfil/staged_collection.py
index 380d894..b045b5c 100644
--- a/ares/modules/exfil/staged_collection.py
+++ b/ares/modules/exfil/staged_collection.py
@@ -169,14 +169,11 @@ class StagedCollectionModule(BaseModule):
destination = pdict.get("destination", "")
max_files = int(pdict.get("max_files", 200))
- audit_lots_egress = bool(pdict.get("audit_lots_egress", False))
-
findings, raw = await self.run(
target=target, username=username, password=password,
key_path=key_path, platform=platform,
search_paths=search_paths, max_files=max_files,
destination=destination,
- audit_lots_egress=audit_lots_egress,
)
# Cryptographic Evidence Records with SHA-256 Merkle Provenance
diff --git a/ares/modules/params.py b/ares/modules/params.py
index c35ca0e..aef4432 100644
--- a/ares/modules/params.py
+++ b/ares/modules/params.py
@@ -834,11 +834,6 @@ class StagedCollectionParams(ModuleParams):
max_files: int = param(
"Max files to collect", required=False, default=200, ge=1, le=1000
)
- audit_lots_egress: bool = param(
- "Enable Living-off-the-Trusted-Services cloud egress audit",
- required=False,
- default=False,
- )
# ── Lateral movement modules ──────────────────────────────────────────────────
diff --git a/tests/unit/test_structured_maintenance.py b/tests/unit/test_structured_maintenance.py
index c07b3f7..4fb05e4 100644
--- a/tests/unit/test_structured_maintenance.py
+++ b/tests/unit/test_structured_maintenance.py
@@ -45,13 +45,14 @@ def _make_module(cls):
class TestStagedCollectionSafety:
"""Verifies that staged collection does not leak un-scoped egress or disable SSL validation."""
- def test_staged_collection_params_defaults_lots_egress_to_false(self):
+ def test_staged_collection_params_conforms_to_contract(self):
params = StagedCollectionParams(
target="10.0.0.1",
username="operator",
destination="/tmp/stage",
)
- assert params.audit_lots_egress is False
+ assert params.target == "10.0.0.1"
+ assert not hasattr(params, "audit_lots_egress")
@pytest.mark.asyncio
async def test_staged_collection_run_skips_lots_egress_by_default(self):