Skip to content

armgit / ARES

Public Imported from GitHub
0

ARES - authorized red-team engagement automation with dashboard, campaign scope, module orchestration, OPSEC controls, encrypted vault, and reporting.

fix(security): Gate 3 - engine validator fail-closed enforcement (SUCCESS_MECHANISM_AUDIT.md)

Mafifrizi97d01e18dc4f
diff --git a/ares/core/engine.py b/ares/core/engine.py
index 8f757fa..867dfbb 100644
--- a/ares/core/engine.py
+++ b/ares/core/engine.py
@@ -788,14 +788,36 @@ class AresEngine:
from ares.core.tracing import get_current_trace_id
trace_id = get_current_trace_id() or ""
- for f in findings:
- if not f.false_positive:
- f.validated = True
- f.module_id = f.module_id or module_id
- enrich_finding_with_cvss(f)
- if trace_id:
- f.trace_id = trace_id
- confirmed.append(f)
+ for i, f in enumerate(findings):
+ if not skip_validation and i < len(validation_results):
+ v_res = validation_results[i]
+ if v_res.should_report and v_res.confidence >= 0.4:
+ f.confidence = v_res.confidence
+ f.validated = True
+ f.module_id = f.module_id or module_id
+ enrich_finding_with_cvss(f)
+ if trace_id:
+ f.trace_id = trace_id
+ confirmed.append(f)
+ else:
+ f.false_positive = True
+ f.validated = False
+ logger.warning(
+ "finding_rejected_by_validator",
+ finding_id=f.id,
+ title=f.title,
+ severity=str(f.severity),
+ confidence=v_res.confidence,
+ reason=getattr(v_res, "reason", None) or (v_res.notes[0] if v_res.notes else "below_confidence_threshold"),
+ )
+ else:
+ if not f.false_positive:
+ f.validated = True
+ f.module_id = f.module_id or module_id
+ enrich_finding_with_cvss(f)
+ if trace_id:
+ f.trace_id = trace_id
+ confirmed.append(f)
fp_count = len(findings) - len(confirmed)
audit(
diff --git a/ares/core/validator.py b/ares/core/validator.py
index 9a5047c..a4c8347 100644
--- a/ares/core/validator.py
+++ b/ares/core/validator.py
@@ -102,8 +102,10 @@ class FindingValidator:
# Update the finding
finding.confidence = result.confidence
- finding.validated = True
- if not result.passed:
+ if result.passed:
+ finding.validated = True
+ else:
+ finding.validated = False
finding.mark_false_positive(f"Confidence too low: {final_confidence:.2f}")
logger.info(
@@ -268,12 +270,52 @@ async def _check_lateral_evidence(
ev = finding.evidence or {}
tech = ev.get("technique") or "lateral"
user = ev.get("username")
- target = ev.get("target") or finding.host
+ target = ev.get("target") or finding.host or ev.get("relay_candidates") or ev.get("ldap_targets")
privilege = ev.get("privilege", "user")
+
+ score = 0.0
+ notes: list[str] = []
+
+ # Target presence adds a small baseline score - not proof of execution
if target:
- account_str = f" as '{user}'" if user else ""
- return True, 1.0, f"Lateral movement to {target}{account_str} verified via {tech} ({privilege} privilege)"
- return False, 0.0, "Missing target host evidence in lateral movement finding"
+ score += 0.2
+ notes.append("target_present")
+
+ # Real execution evidence (stdout, session, ticket, delegation)
+ has_exec = bool(
+ ev.get("command_output")
+ or ev.get("output")
+ or ev.get("session_id")
+ or ev.get("ticket_path")
+ or ev.get("delegation_set")
+ )
+ if has_exec:
+ score += 0.6
+ notes.append("execution_evidence")
+
+ # Auth handshake, banner, or protocol audit evidence
+ has_auth = bool(
+ ev.get("auth_response")
+ or ev.get("banner")
+ or ev.get("auth_type")
+ or ev.get("sql_user")
+ or ev.get("smb_results")
+ or ev.get("relay_candidates")
+ or ev.get("ldap_unsigned_hosts")
+ or ev.get("method")
+ )
+ if has_auth:
+ score += 0.2
+ notes.append("auth_handshake_evidence")
+
+ score = min(1.0, round(score, 2))
+ passed = score >= 0.4
+
+ account_str = f" as '{user}'" if user else ""
+ target_str = str(target[0]) if isinstance(target, list) and target else str(target or "unknown")
+ if passed:
+ return True, score, f"Lateral movement to {target_str}{account_str} verified via {tech} ({', '.join(notes)}, confidence={score})"
+ return False, score, f"Insufficient lateral execution evidence for {target_str} (score={score}, required >= 0.4)"
# ── Default validator registry ────────────────────────────────────────────────