Skip to content

armgit / ARES

Public Imported from GitHub
0

ARES - authorized red-team engagement automation with dashboard, campaign scope, module orchestration, OPSEC controls, encrypted vault, and reporting.

fix(ad): mock ldap3 in sys.modules to decouple unit test from optional dependency (MOD-057)

Mafifriziaea1ca19a7ee
diff --git a/tests/unit/modules/test_ad_bind_plan_mod057.py b/tests/unit/modules/test_ad_bind_plan_mod057.py
index bb7be74..849c21d 100644
--- a/tests/unit/modules/test_ad_bind_plan_mod057.py
+++ b/tests/unit/modules/test_ad_bind_plan_mod057.py
@@ -1,5 +1,6 @@
-"""Unit test for MOD-057: normalize LDAP bind format in enum_acl and laps_enum using build_ad_bind_plan."""
-from unittest.mock import MagicMock, patch
+import sys
+import types
+from unittest.mock import MagicMock
import pytest
from ares.core.campaign import Campaign, NoiseProfile, ScopeEntry
@@ -25,6 +26,41 @@ def _make_module(cls):
return cls(settings=settings, campaign=campaign, noise=noise)
+def _install_mock_ldap3(monkeypatch):
+ """Install mock ldap3 modules in sys.modules for test environments lacking optional ldap3."""
+ ldap3_mod = types.ModuleType("ldap3")
+ ldap3_mod.AUTO_BIND_NONE = "AUTO_BIND_NONE"
+ ldap3_mod.ALL = "ALL"
+ ldap3_mod.NTLM = "NTLM"
+ ldap3_mod.SUBTREE = "SUBTREE"
+
+ mock_conn = MagicMock()
+ mock_conn.bind.return_value = True
+ mock_conn.entries = []
+ mock_conn.result = {}
+
+ mock_connection_cls = MagicMock(return_value=mock_conn)
+ mock_server_cls = MagicMock()
+ mock_tls_cls = MagicMock()
+
+ ldap3_mod.Connection = mock_connection_cls
+ ldap3_mod.Server = mock_server_cls
+ ldap3_mod.Tls = mock_tls_cls
+ ldap3_mod.CERT_NONE = 0
+
+ ldap3_core = types.ModuleType("ldap3.core")
+ ldap3_exceptions = types.ModuleType("ldap3.core.exceptions")
+ ldap3_exceptions.LDAPBindError = type("LDAPBindError", (Exception,), {})
+ ldap3_mod.core = ldap3_core
+ ldap3_core.exceptions = ldap3_exceptions
+
+ monkeypatch.setitem(sys.modules, "ldap3", ldap3_mod)
+ monkeypatch.setitem(sys.modules, "ldap3.core", ldap3_core)
+ monkeypatch.setitem(sys.modules, "ldap3.core.exceptions", ldap3_exceptions)
+
+ return mock_connection_cls, mock_conn
+
+
def test_build_ad_bind_plan_formats():
"""Verify build_ad_bind_plan handles UPN, NetBIOS, and plain username."""
# UPN
@@ -46,19 +82,13 @@ def test_build_ad_bind_plan_formats():
assert plain_plan.username_format == "plain_to_upn"
-@patch("ldap3.Connection")
-@patch("ldap3.Server")
-def test_enum_acl_uses_build_ad_bind_plan(mock_server, mock_connection):
+def test_enum_acl_uses_build_ad_bind_plan(monkeypatch):
"""MOD-057: enum_acl._enum_acls_sync uses build_ad_bind_plan rather than raw string concat."""
- conn_instance = MagicMock()
- conn_instance.bind.return_value = True
- conn_instance.entries = []
- conn_instance.result = {}
- mock_connection.return_value = conn_instance
+ mock_connection_cls, mock_conn = _install_mock_ldap3(monkeypatch)
module = _make_module(ADEnumACLModule)
- # Test with UPN: should use simple bind and [email protected], NOT CORP.LOCAL\[email protected]
+ # Test with UPN: should use simple bind and [email protected], NOT CORP.LOCAL\\[email protected]
module._enum_acls_sync(
dc="10.0.0.1",
username="[email protected]",
@@ -66,35 +96,28 @@ def test_enum_acl_uses_build_ad_bind_plan(mock_server, mock_connection):
domain="corp.local",
)
- mock_connection.assert_called()
- call_kwargs = mock_connection.call_args[1]
+ mock_connection_cls.assert_called()
+ call_kwargs = mock_connection_cls.call_args[1]
assert call_kwargs["user"] == "[email protected]"
# For UPN, simple bind is used (no NTLM in kwargs)
assert "authentication" not in call_kwargs
-@patch("ldap3.Connection")
-@patch("ldap3.Server")
-def test_laps_enum_uses_build_ad_bind_plan(mock_server, mock_connection):
+def test_laps_enum_uses_build_ad_bind_plan(monkeypatch):
"""MOD-057: laps_enum._query_laps_sync uses build_ad_bind_plan rather than raw string concat."""
- conn_instance = MagicMock()
- conn_instance.bind.return_value = True
- conn_instance.entries = []
- conn_instance.result = {}
- mock_connection.return_value = conn_instance
+ mock_connection_cls, mock_conn = _install_mock_ldap3(monkeypatch)
module = _make_module(LAPSEnumModule)
# Test with NetBIOS: should use NTLM authentication
- entries = module._query_laps_sync(
+ module._query_laps_sync(
dc="10.0.0.1",
username="CORP\\admin",
password="Password123!",
domain="corp.local",
)
- mock_connection.assert_called()
- call_kwargs = mock_connection.call_args[1]
+ mock_connection_cls.assert_called()
+ call_kwargs = mock_connection_cls.call_args[1]
assert call_kwargs["user"] == "CORP\\admin"
- from ldap3 import NTLM
- assert call_kwargs.get("authentication") == NTLM
+ assert call_kwargs.get("authentication") == "NTLM"