ARES - authorized red-team engagement automation with dashboard, campaign scope, module orchestration, OPSEC controls, encrypted vault, and reporting.
Python active-directorycloud-securitydefensive-validationfastapigood-first-issuemitre-attackopsecreactred-teamreportingsecurity
fix(robustness): cloud modules SDK pre-flight validation in validate() (MOD-065)
Mafifrizib68986e7cf76
diff --git a/ares/modules/cloud/aws.py b/ares/modules/cloud/aws.pyindex 1489fae..1e249b2 100644--- a/ares/modules/cloud/aws.py+++ b/ares/modules/cloud/aws.py@@ -47,9 +47,21 @@ class AWSEnumModule(BaseModule):async def validate(self, ctx: "Any") -> None:"""Pre-flight param checks before any network call."""+ import importlib.util+ from ares.core.errors import ModuleValidationError++ try:+ spec = importlib.util.find_spec("boto3")+ except (ModuleNotFoundError, ValueError):+ spec = None+ if spec is None:+ raise ModuleValidationError(+ f"{self.MODULE_ID} requires boto3. Install with: pip install boto3",+ module_id=self.MODULE_ID,+ )+await super().validate(ctx)from ares.core.context import ExecutionContext- from ares.core.errors import ModuleValidationErrorif not isinstance(ctx, ExecutionContext):returnparams = getattr(ctx, "params", {})diff --git a/ares/modules/cloud/azure.py b/ares/modules/cloud/azure.pyindex 8c5d0f5..c5a2788 100644--- a/ares/modules/cloud/azure.py+++ b/ares/modules/cloud/azure.py@@ -75,9 +75,21 @@ class AzureModule(BaseModule):async def validate(self, ctx: "Any") -> None:"""Pre-flight param checks before any network call."""+ import importlib.util+ from ares.core.errors import ModuleValidationError++ try:+ spec = importlib.util.find_spec("azure.identity")+ except (ModuleNotFoundError, ValueError):+ spec = None+ if spec is None:+ raise ModuleValidationError(+ f"{self.MODULE_ID} requires azure.identity. Install with: pip install ares-redteam[cloud]",+ module_id=self.MODULE_ID,+ )+await super().validate(ctx)from ares.core.context import ExecutionContext- from ares.core.errors import ModuleValidationErrorif not isinstance(ctx, ExecutionContext):returnparams = getattr(ctx, "params", {})diff --git a/ares/modules/cloud/azure_ad.py b/ares/modules/cloud/azure_ad.pyindex d0c33bc..1f56d92 100644--- a/ares/modules/cloud/azure_ad.py+++ b/ares/modules/cloud/azure_ad.py@@ -87,9 +87,21 @@ class AzureADModule(BaseModule):PARAMS_MODEL = AzureADParamsasync def validate(self, ctx: "Any") -> None:+ import importlib.util+ from ares.core.errors import ModuleValidationError++ try:+ spec = importlib.util.find_spec("msal")+ except (ModuleNotFoundError, ValueError):+ spec = None+ if spec is None:+ raise ModuleValidationError(+ f"{self.MODULE_ID} requires msal. Install with: pip install msal",+ module_id=self.MODULE_ID,+ )+await super().validate(ctx)from ares.core.context import ExecutionContext- from ares.core.errors import ModuleValidationErrorif not isinstance(ctx, ExecutionContext):returnparams = getattr(ctx, "params", {})diff --git a/ares/modules/cloud/gcp.py b/ares/modules/cloud/gcp.pyindex af2db29..430bce6 100644--- a/ares/modules/cloud/gcp.py+++ b/ares/modules/cloud/gcp.py@@ -90,9 +90,21 @@ class GCPModule(BaseModule):async def validate(self, ctx: "Any") -> None:"""Pre-flight param checks before any network call."""+ import importlib.util+ from ares.core.errors import ModuleValidationError++ try:+ spec = importlib.util.find_spec("google.cloud.resourcemanager")+ except (ModuleNotFoundError, ValueError):+ spec = None+ if spec is None:+ raise ModuleValidationError(+ f"{self.MODULE_ID} requires google.cloud.resourcemanager. Install with: pip install google-cloud-resource-manager",+ module_id=self.MODULE_ID,+ )+await super().validate(ctx)from ares.core.context import ExecutionContext- from ares.core.errors import ModuleValidationErrorif not isinstance(ctx, ExecutionContext):returnparams = getattr(ctx, "params", {})diff --git a/tests/unit/modules/test_cloud_sdk_preflight_mod065.py b/tests/unit/modules/test_cloud_sdk_preflight_mod065.pynew file mode 100644index 0000000..678ba26--- /dev/null+++ b/tests/unit/modules/test_cloud_sdk_preflight_mod065.py@@ -0,0 +1,100 @@+"""+Tests for MOD-065: Missing SDK pre-flight validation in validate()+across cloud modules: cloud.aws, cloud.azure, cloud.azure_ad, and cloud.gcp.+"""++from unittest.mock import MagicMock, patch+import pytest++from ares.core.campaign import Campaign, NoiseProfile, ScopeEntry+from ares.core.config import AresSettings+from ares.core.context import ExecutionContext+from ares.core.errors import ModuleValidationError+from ares.core.noise import NoiseController+from ares.modules.cloud.aws import AWSEnumModule+from ares.modules.cloud.azure import AzureModule+from ares.modules.cloud.azure_ad import AzureADModule+from ares.modules.cloud.gcp import GCPModule+++def _make_context_deps():+ settings = AresSettings(+ ares_secret_key="test-secret-key-32chars-minimum!!",+ ares_encryption_key="test-encryption-key-32chars-min!!",+ )+ campaign = Campaign(+ name="Cloud-SDK-Preflight-Test",+ client="Unit-Testing",+ scope=[ScopeEntry(cidr="10.0.0.0/8")],+ noise_profile=NoiseProfile.NORMAL,+ )+ noise = NoiseController(campaign)+ return settings, campaign, noise+++async def test_aws_sdk_preflight_missing():+ settings, campaign, noise = _make_context_deps()+ mod = AWSEnumModule(settings=settings, campaign=campaign, noise=noise)+ ctx = ExecutionContext(target="aws", params={"access_key": "AKIA...", "secret_key": "secret"})++ with patch("importlib.util.find_spec", return_value=None):+ with pytest.raises(ModuleValidationError) as exc_info:+ await mod.validate(ctx)++ assert "cloud.aws requires boto3" in str(exc_info.value)+ assert "pip install boto3" in str(exc_info.value)+++async def test_azure_sdk_preflight_missing():+ settings, campaign, noise = _make_context_deps()+ mod = AzureModule(settings=settings, campaign=campaign, noise=noise)+ ctx = ExecutionContext(target="azure", params={"subscription_id": "sub-123"})++ with patch("importlib.util.find_spec", return_value=None):+ with pytest.raises(ModuleValidationError) as exc_info:+ await mod.validate(ctx)++ assert "cloud.azure requires azure.identity" in str(exc_info.value)+ assert "pip install ares-redteam[cloud]" in str(exc_info.value)+++async def test_azure_ad_sdk_preflight_missing():+ settings, campaign, noise = _make_context_deps()+ mod = AzureADModule(settings=settings, campaign=campaign, noise=noise)+ ctx = ExecutionContext(target="azure_ad", params={"tenant_id": "tenant-123"})++ with patch("importlib.util.find_spec", return_value=None):+ with pytest.raises(ModuleValidationError) as exc_info:+ await mod.validate(ctx)++ assert "cloud.azure_ad requires msal" in str(exc_info.value)+ assert "pip install msal" in str(exc_info.value)+++async def test_gcp_sdk_preflight_missing():+ settings, campaign, noise = _make_context_deps()+ mod = GCPModule(settings=settings, campaign=campaign, noise=noise)+ ctx = ExecutionContext(target="gcp", params={"project_id": "test-project"})++ with patch("importlib.util.find_spec", return_value=None):+ with pytest.raises(ModuleValidationError) as exc_info:+ await mod.validate(ctx)++ assert "cloud.gcp requires google.cloud.resourcemanager" in str(exc_info.value)+ assert "pip install google-cloud-resource-manager" in str(exc_info.value)+++async def test_cloud_sdk_preflight_passes_when_installed():+ settings, campaign, noise = _make_context_deps()+ mod = AWSEnumModule(settings=settings, campaign=campaign, noise=noise)+ ctx = ExecutionContext(target="aws", params={"access_key": "AKIA...", "secret_key": "secret"})++ dummy_spec = MagicMock()+ with patch("importlib.util.find_spec", return_value=dummy_spec):+ # Should not raise ModuleValidationError for SDK+ await mod.validate(ctx)