Skip to content

armgit / ARES

Public Imported from GitHub
0

ARES - authorized red-team engagement automation with dashboard, campaign scope, module orchestration, OPSEC controls, encrypted vault, and reporting.

fix(critical): azure_ad indentation bug - UnboundLocalError and unreachable Graph API dead code (MOD-067)

Mafifrizibd2c9b40553f
diff --git a/ares/modules/cloud/azure_ad.py b/ares/modules/cloud/azure_ad.py
index 1016732..d0c33bc 100644
--- a/ares/modules/cloud/azure_ad.py
+++ b/ares/modules/cloud/azure_ad.py
@@ -235,6 +235,7 @@ class AzureADModule(BaseModule):
audit("azure_ad_attack", actor="operator", technique="T1528",
source="operator", target=f"tenant:{tenant_id[:8]}")
+ raw: dict[str, Any] = {"tenant_id": tenant_id}
loop = asyncio.get_running_loop()
# Acquire access token if not provided
@@ -280,15 +281,15 @@ class AzureADModule(BaseModule):
)
await self.noise.jitter.sleep()
raw["access_tokens"] = raw.get("access_token", "") # OUTPUTS key
- raw["azure_ad_findings"] = self._findings # OUTPUTS key
- return self._findings[:], raw
+ raw["azure_ad_findings"] = self._findings # OUTPUTS key
+ return self._findings[:], raw
# Enumeration with Graph API
if not token:
- return [], {
- "error": "No access token available. Provide client_id+client_secret or access_token.",
- "hint": "Or use technique=device_code to initiate device code flow.",
- }
+ raw["error"] = "No access token available. Provide client_id+client_secret or access_token."
+ raw["hint"] = "Or use technique=device_code to initiate device code flow."
+ raw["azure_ad_findings"] = self._findings
+ return [], raw
# Enumerate users, guests, service principals
results = await loop.run_in_executor(
@@ -358,6 +359,7 @@ class AzureADModule(BaseModule):
"high_priv_sps": [s.get("displayName", "") for s in
[s for s in sps if s.get("privileged")][:10]],
}
+ raw["azure_ad_findings"] = self._findings
await self.noise.jitter.sleep()
return self._findings[:], raw
diff --git a/tests/unit/modules/test_azure_ad_mod067.py b/tests/unit/modules/test_azure_ad_mod067.py
new file mode 100644
index 0000000..cdc2bea
--- /dev/null
+++ b/tests/unit/modules/test_azure_ad_mod067.py
@@ -0,0 +1,108 @@
+"""
+Tests for MOD-067: Azure AD indentation bug, UnboundLocalError,
+and Graph API enumeration reachability in cloud.azure_ad.
+"""
+
+import pytest
+from unittest.mock import MagicMock, patch
+from ares.core.campaign import Campaign, NoiseProfile, ScopeEntry
+from ares.core.config import AresSettings
+from ares.core.noise import NoiseController
+from ares.modules.cloud.azure_ad import AzureADModule
+
+
+def _make_module() -> AzureADModule:
+ settings = AresSettings(
+ ares_secret_key="test-secret-key-32chars-minimum!!",
+ ares_encryption_key="test-encryption-key-32chars-min!!",
+ )
+ campaign = Campaign(
+ name="Azure-AD-Test",
+ client="Unit-Testing",
+ scope=[ScopeEntry(cidr="192.168.0.0/16")],
+ noise_profile=NoiseProfile.NORMAL,
+ )
+ noise = NoiseController(campaign)
+ return AzureADModule(settings=settings, campaign=campaign, noise=noise)
+
+
+async def test_azure_ad_enumerate_no_unbound_local_error():
+ """Verify default technique='enumerate' does NOT raise UnboundLocalError when no token is present."""
+ mod = _make_module()
+ findings, raw = await mod.run(
+ tenant_id="00000000-0000-0000-0000-000000000000",
+ technique="enumerate",
+ )
+ assert isinstance(raw, dict)
+ assert raw.get("tenant_id") == "00000000-0000-0000-0000-000000000000"
+ assert "error" in raw
+ assert "azure_ad_findings" in raw
+ assert raw["azure_ad_findings"] == findings
+
+
+async def test_azure_ad_enumerate_reaches_graph_api():
+ """Verify Graph API enumeration code path is reached and executed when token is supplied."""
+ mod = _make_module()
+ mock_tenant_results = {
+ "guests": [{"userPrincipalName": "[email protected]"}],
+ "service_principals": [
+ {"displayName": "HighPrivDaemon", "privileged": True, "has_expired_secret": False}
+ ],
+ "privileged_users": [{"userPrincipalName": "[email protected]"}],
+ "user_count": 42,
+ }
+
+ with patch.object(mod, "_enumerate_tenant", return_value=mock_tenant_results) as mock_enum:
+ findings, raw = await mod.run(
+ tenant_id="11111111-2222-3333-4444-555555555555",
+ access_token="eyJ0eXAiOiJKV1QiLCJhbGciOiJSUzI1NiJ9.fake",
+ technique="enumerate",
+ )
+
+ mock_enum.assert_called_once_with(
+ "eyJ0eXAiOiJKV1QiLCJhbGciOiJSUzI1NiJ9.fake",
+ "11111111-2222-3333-4444-555555555555",
+ )
+
+ assert raw.get("tenant_id") == "11111111-2222-3333-4444-555555555555"
+ assert raw.get("technique") == "enumerate"
+ assert raw.get("user_count") == 42
+ assert raw.get("guest_count") == 1
+ assert raw.get("sp_count") == 1
+ assert "azure_ad_findings" in raw
+ assert raw["azure_ad_findings"] == findings
+
+ titles = [f.title for f in findings]
+ assert any("Guest Accounts" in t for t in titles)
+ assert any("Privileged Service Principals" in t for t in titles)
+
+
+async def test_azure_ad_device_code_technique_still_works():
+ """Verify technique='device_code' flow works properly and populates expected keys."""
+ mod = _make_module()
+ mock_dc_info = {
+ "user_code": "XYZ-9876",
+ "verification_uri": "https://microsoft.com/devicelogin",
+ "expires_in": 900,
+ "interval": 5,
+ "device_code": "mock_device_code",
+ }
+
+ with patch.object(mod, "_request_device_code", return_value=mock_dc_info) as mock_dc:
+ findings, raw = await mod.run(
+ tenant_id="99999999-8888-7777-6666-555555555555",
+ technique="device_code",
+ )
+
+ mock_dc.assert_called_once()
+ assert raw.get("technique") == "device_code"
+ assert raw.get("user_code") == "XYZ-9876"
+ assert "access_tokens" in raw
+ assert "azure_ad_findings" in raw
+ assert raw["azure_ad_findings"] == findings
+
+ titles = [f.title for f in findings]
+ assert any("Device Code Generated" in t for t in titles)