Skip to content

armgit / ARES

Public Imported from GitHub
0

ARES - authorized red-team engagement automation with dashboard, campaign scope, module orchestration, OPSEC controls, encrypted vault, and reporting.

fix(security): exfil modules correct protocol in before_request (MOD-073)

Mafifrizic8d903e5044f
diff --git a/ares/modules/exfil/secrets_scan.py b/ares/modules/exfil/secrets_scan.py
index 89ccead..95e5453 100644
--- a/ares/modules/exfil/secrets_scan.py
+++ b/ares/modules/exfil/secrets_scan.py
@@ -605,7 +605,8 @@ class SecretsScan(BaseModule):
if not username:
return [], {"error": "no_credential_username"}
- await self.before_request(target, "default")
+ protocol = "smb" if platform == "windows" else "ssh"
+ await self.before_request(target, protocol)
try:
if platform == "windows":
diff --git a/ares/modules/exfil/smb_shares.py b/ares/modules/exfil/smb_shares.py
index a83c9dc..6c8403a 100644
--- a/ares/modules/exfil/smb_shares.py
+++ b/ares/modules/exfil/smb_shares.py
@@ -253,7 +253,7 @@ class SmbSharesExfil(BaseModule):
if not username:
return [], {"error": "no_credential_username"}
- await self.before_request(target, "default")
+ await self.before_request(target, "smb")
import asyncio as _asyncio
loop = _asyncio.get_running_loop()
diff --git a/tests/unit/modules/test_exfil_protocol_scope_mod073.py b/tests/unit/modules/test_exfil_protocol_scope_mod073.py
new file mode 100644
index 0000000..065d5bb
--- /dev/null
+++ b/tests/unit/modules/test_exfil_protocol_scope_mod073.py
@@ -0,0 +1,89 @@
+"""
+Tests for MOD-073: Scope Guard / Rate Limiter protocol string in before_request().
+Verifies exfil.secrets_scan and exfil.smb_shares use explicit protocol strings ('ssh', 'smb')
+instead of the uncalibrated 'default'.
+"""
+
+from unittest.mock import AsyncMock, MagicMock, patch
+import pytest
+
+from ares.core.campaign import Campaign, NoiseProfile, ScopeEntry
+from ares.core.config import AresSettings
+from ares.core.noise import NoiseController
+from ares.modules.exfil.secrets_scan import SecretsScan
+from ares.modules.exfil.smb_shares import SmbSharesExfil
+
+
+def _make_deps():
+ settings = AresSettings(
+ ares_secret_key="test-secret-key-32chars-minimum!!",
+ ares_encryption_key="test-encryption-key-32chars-min!!",
+ )
+ campaign = Campaign(
+ name="Exfil-Protocol-Test",
+ client="Unit-Testing",
+ scope=[ScopeEntry(cidr="192.168.0.0/16")],
+ noise_profile=NoiseProfile.NORMAL,
+ )
+ noise = NoiseController(campaign)
+ return settings, campaign, noise
+
+
+async def test_secrets_scan_uses_ssh_protocol_for_linux():
+ """Verify secrets_scan passes 'ssh' to before_request for Linux scans."""
+ settings, campaign, noise = _make_deps()
+ mod = SecretsScan(settings=settings, campaign=campaign, noise=noise)
+
+ mock_before_req = AsyncMock()
+ with patch.object(mod, "before_request", mock_before_req):
+ with patch("ares.modules.exfil.secrets_scan._ssh_scan", return_value=[]):
+ await mod.run(
+ target="192.168.1.100",
+ username="root",
+ platform="linux",
+ )
+
+ mock_before_req.assert_awaited_once_with("192.168.1.100", "ssh")
+
+
+async def test_secrets_scan_uses_smb_protocol_for_windows():
+ """Verify secrets_scan passes 'smb' to before_request for Windows scans."""
+ settings, campaign, noise = _make_deps()
+ mod = SecretsScan(settings=settings, campaign=campaign, noise=noise)
+
+ mock_before_req = AsyncMock()
+ with patch.object(mod, "before_request", mock_before_req):
+ with patch("ares.modules.exfil.secrets_scan._wmi_scan", return_value=[]):
+ await mod.run(
+ target="192.168.1.101",
+ username="Administrator",
+ platform="windows",
+ )
+
+ mock_before_req.assert_awaited_once_with("192.168.1.101", "smb")
+
+
+async def test_smb_shares_uses_smb_protocol():
+ """Verify smb_shares passes 'smb' to before_request."""
+ import sys
+ settings, campaign, noise = _make_deps()
+ mod = SmbSharesExfil(settings=settings, campaign=campaign, noise=noise)
+
+ mock_before_req = AsyncMock()
+ mock_smb_module = MagicMock()
+ with patch.dict(sys.modules, {"impacket": MagicMock(), "impacket.smbconnection": mock_smb_module}):
+ with patch.object(mod, "before_request", mock_before_req):
+ with patch("asyncio.get_running_loop") as mock_loop:
+ fake_loop = MagicMock()
+ mock_loop.return_value = fake_loop
+ fake_loop.run_in_executor = AsyncMock(return_value=([], []))
+
+ await mod.run(
+ target="192.168.1.102",
+ username="Administrator",
+ )
+
+ mock_before_req.assert_awaited_once_with("192.168.1.102", "smb")