ARES - authorized red-team engagement automation with dashboard, campaign scope, module orchestration, OPSEC controls, encrypted vault, and reporting.
Python active-directorycloud-securitydefensive-validationfastapigood-first-issuemitre-attackopsecreactred-teamreportingsecurity
fix(modules): remap on-prem rate limiter buckets from cloud_api to smb/wmi/ssh (Klaster B)
Mafifrizid03a05151d03
diff --git a/ares/modules/credential/pass_the_hash.py b/ares/modules/credential/pass_the_hash.pyindex 8af821a..7a59278 100644--- a/ares/modules/credential/pass_the_hash.py+++ b/ares/modules/credential/pass_the_hash.py@@ -112,7 +112,7 @@ class PassTheHashModule(BaseModule):logger.info("pass_the_hash_attempt", target=target, username=username)audit("pass_the_hash", actor="operator", technique="T1550.002",source="operator", target=target)- await self.noise.rate_limiter.acquire("cloud_api")+ await self.noise.rate_limiter.acquire("smb")await self.noise.jitter.sleep()success = Falsediff --git a/ares/modules/exfil/staged_collection.py b/ares/modules/exfil/staged_collection.pyindex b9a3319..ffe805d 100644--- a/ares/modules/exfil/staged_collection.py+++ b/ares/modules/exfil/staged_collection.py@@ -119,7 +119,7 @@ class StagedCollectionModule(BaseModule):logger.info("staged_collection_start", target=target, paths=search_paths)audit("staged_collection", actor=username, technique="T1119",source="operator", target=target)- await self.noise.rate_limiter.acquire("cloud_api")+ await self.noise.rate_limiter.acquire("ssh")await self.noise.jitter.sleep()loop = asyncio.get_running_loop()diff --git a/ares/modules/persistence/wmi_subscription.py b/ares/modules/persistence/wmi_subscription.pyindex 5c3ef27..ac7494e 100644--- a/ares/modules/persistence/wmi_subscription.py+++ b/ares/modules/persistence/wmi_subscription.py@@ -105,7 +105,7 @@ class WMISubscriptionModule(BaseModule):logger.info("wmi_subscription_install", target=target, name=sub_name)audit("wmi_subscription", actor=username, technique="T1546.003",source="operator", target=target, detail=f"name={sub_name}")- await self.noise.rate_limiter.acquire("cloud_api")+ await self.noise.rate_limiter.acquire("wmi")await self.noise.jitter.sleep()success = Falsediff --git a/ares/modules/windows/lsa_secrets.py b/ares/modules/windows/lsa_secrets.pyindex 26ca084..87c7a42 100644--- a/ares/modules/windows/lsa_secrets.py+++ b/ares/modules/windows/lsa_secrets.py@@ -116,7 +116,7 @@ class LSASecretsModule(BaseModule):logger.info("lsa_secrets_start", target=target, username=username)audit("lsa_secrets", actor=username, source="operator",target=target, technique="T1003.002")- await self.noise.rate_limiter.acquire("cloud_api")+ await self.noise.rate_limiter.acquire("smb")await self.noise.jitter.sleep()sam_hashes: list[str] = []diff --git a/ares/modules/windows/token_impersonation.py b/ares/modules/windows/token_impersonation.pyindex 2c935ea..488e100 100644--- a/ares/modules/windows/token_impersonation.py+++ b/ares/modules/windows/token_impersonation.py@@ -104,7 +104,7 @@ class TokenImpersonationModule(BaseModule):from ares.core.logger import audit as _audit_audit("token_impersonation", actor=username, source="operator",target=target, technique="T1134.001")- await self.noise.rate_limiter.acquire("cloud_api")+ await self.noise.rate_limiter.acquire("smb")await self.noise.jitter.sleep()# Run whoami /priv via WMI to check SeImpersonatePrivilegediff --git a/tests/unit/modules/test_safety_remediation.py b/tests/unit/modules/test_safety_remediation.pyindex 47683dd..c8c67a4 100644--- a/tests/unit/modules/test_safety_remediation.py+++ b/tests/unit/modules/test_safety_remediation.py@@ -195,3 +195,45 @@ def test_aws_privesc_accepts_both_access_key_variants():ctx2 = ExecutionContext(target="aws", campaign_id="c", params={"aws_access_key": "AKIA123"})asyncio.run(mod.validate(ctx2))+++# ── 6. On-Prem Module Rate Limiter Bucket Verification ──────────────────────+[email protected]("mod_path,cls_name,expected_bucket,run_kwargs", [+ ("ares.modules.windows.token_impersonation", "TokenImpersonationModule", "smb", {"target": "10.0.0.1", "username": "admin", "password": "pwd"}),+ ("ares.modules.windows.lsa_secrets", "LSASecretsModule", "smb", {"target": "10.0.0.1", "username": "admin", "password": "pwd"}),+ ("ares.modules.persistence.wmi_subscription", "WMISubscriptionModule", "wmi", {"target": "10.0.0.1", "username": "admin", "password": "pwd", "command": "whoami"}),+ ("ares.modules.exfil.staged_collection", "StagedCollectionModule", "ssh", {"target": "10.0.0.1", "username": "admin", "key_path": "/tmp/k"}),+ ("ares.modules.credential.pass_the_hash", "PassTheHashModule", "smb", {"target": "10.0.0.1", "username": "admin", "nt_hash": "a"*32}),+])+def test_onprem_modules_rate_limiter_never_calls_cloud_api(mod_path, cls_name, expected_bucket, run_kwargs):+ """On-prem modules must use their semantic bucket (smb/wmi/ssh) and never touch cloud_api."""+ mod = __import__(mod_path, fromlist=[cls_name])+ module_cls = getattr(mod, cls_name)+ instance = make_module(module_cls)+ instance.before_request = AsyncMock()+ instance.noise.jitter.sleep = AsyncMock()+ acquire_mock = AsyncMock()+ instance.noise.rate_limiter.acquire = acquire_mock++ with patch.dict("sys.modules", {+ "impacket": MagicMock(),+ "impacket.smbconnection": MagicMock(),+ "impacket.examples.secretsdump": MagicMock(),+ "impacket.dcerpc.v5": MagicMock(),+ "impacket.dcerpc.v5.transport": MagicMock(),+ "impacket.dcerpc.v5.dcom": MagicMock(),+ "impacket.dcerpc.v5.dcomrt": MagicMock(),+ "paramiko": MagicMock(),+ }):+ # Mock inner execution loop or functions+ try:+ asyncio.run(instance.run(**run_kwargs))+ except Exception:+ pass++ assert acquire_mock.called, f"{cls_name} did not call rate_limiter.acquire"+ called_bucket = acquire_mock.call_args[0][0]+ assert called_bucket == expected_bucket, f"{cls_name} expected bucket {expected_bucket}, got {called_bucket}"+ assert called_bucket != "cloud_api", f"{cls_name} improperly used cloud_api rate limiter bucket!"+