ARES - authorized red-team engagement automation with dashboard, campaign scope, module orchestration, OPSEC controls, encrypted vault, and reporting.
Python active-directorycloud-securitydefensive-validationfastapigood-first-issuemitre-attackopsecreactred-teamreportingsecurity
fix(resource): wmi_subscription cleanup tuple bug (MOD-048)
Mafifrizie76f041db034
diff --git a/ares/modules/persistence/wmi_subscription.py b/ares/modules/persistence/wmi_subscription.pyindex f0906eb..0f9684a 100644--- a/ares/modules/persistence/wmi_subscription.py+++ b/ares/modules/persistence/wmi_subscription.py@@ -280,6 +280,7 @@ class WMISubscriptionModule(BaseModule):loop = asyncio.get_running_loop()def _install() -> tuple[bool, str]:+ dcom = Nonetry:dcom = DCOMConnection(target, username=username, password=password,domain=domain, oxidResolver=True)@@ -350,7 +351,7 @@ class WMISubscriptionModule(BaseModule):raw = {"target": target, "subscription_name": sub_name,"success": success, "error": error, "command": command}- raw["persistence_established"] = raw.get("subscription_name", "") # OUTPUTS key+ raw["persistence_established"] = sub_name if success else "" # OUTPUTS keyreturn self._findings[:], rawasync def cleanup(self, target: str, username: str, password: str,@@ -381,15 +382,18 @@ class WMISubscriptionModule(BaseModule):removed = []# Delete in reverse order: binding → consumer → filter- for cls, name_key in [- ("__FilterToConsumerBinding", None),- ("CommandLineEventConsumer", f"{subscription_name}Consumer"),- ("__EventFilter", f"{subscription_name}Filter"),+ binding_path = (+ f'__FilterToConsumerBinding.Filter="__EventFilter.Name=\\"{subscription_name}Filter\\"",'+ f'Consumer="CommandLineEventConsumer.Name=\\"{subscription_name}Consumer\\""'+ )+ for cls, obj_path, label in [+ ("__FilterToConsumerBinding", binding_path, f"{subscription_name}Binding"),+ ("CommandLineEventConsumer", f'CommandLineEventConsumer.Name="{subscription_name}Consumer"', f"{subscription_name}Consumer"),+ ("__EventFilter", f'__EventFilter.Name="{subscription_name}Filter"', f"{subscription_name}Filter"),]:try:- if name_key:- iWbemServices.DeleteInstance(f'{cls}.Name="{name_key}"')- removed.append(f"{cls}/{name_key}")+ iWbemServices.DeleteInstance(obj_path)+ removed.append(f"{cls}/{label}")except Exception:pass # already gone or never createdreturn True, f"Removed: {removed}"diff --git a/tests/unit/modules/test_wmi_subscription_cleanup.py b/tests/unit/modules/test_wmi_subscription_cleanup.pynew file mode 100644index 0000000..7426123--- /dev/null+++ b/tests/unit/modules/test_wmi_subscription_cleanup.py@@ -0,0 +1,96 @@+from __future__ import annotations++from unittest.mock import MagicMock, patch+import pytest++from ares.core.campaign import Campaign, NoiseProfile, ScopeEntry+from ares.core.config import AresSettings+from ares.core.noise import NoiseController+from ares.modules.persistence.wmi_subscription import WMISubscriptionModule+++def _make_module():+ settings = AresSettings(+ ares_secret_key="test-secret-key-min32-chars-here!!",+ ares_encryption_key="test-enc-key-min32-chars-here-xxx",+ )+ campaign = Campaign(+ name="WMI-Subscription-Test",+ operator="test_operator",+ scope=[ScopeEntry(cidr="10.0.0.0/24")],+ noise_profile=NoiseProfile.NORMAL,+ )+ noise = NoiseController(campaign)+ return WMISubscriptionModule(settings=settings, campaign=campaign, noise=noise)+++async def test_wmi_subscription_cleanup_deletes_binding_and_objects():+ """MOD-048: cleanup deletes __FilterToConsumerBinding, consumer, and filter."""+ mod = _make_module()++ mock_dcom = MagicMock()+ mock_login = MagicMock()+ mock_services = MagicMock()++ mock_dcom.CoCreateInstanceEx.return_value = MagicMock()+ mock_dcom_cls = MagicMock(return_value=mock_dcom)++ mock_wmimod = MagicMock()+ mock_wmimod.IWbemLevel1Login.return_value = mock_login+ mock_login.NTLMLogin.return_value = mock_services++ mock_modules = {+ "impacket": MagicMock(),+ "impacket.dcerpc": MagicMock(),+ "impacket.dcerpc.v5": MagicMock(),+ "impacket.dcerpc.v5.dcomrt": MagicMock(DCOMConnection=mock_dcom_cls),+ "impacket.dcerpc.v5.dcom": MagicMock(wmi=mock_wmimod),+ "impacket.dcerpc.v5.dtypes": MagicMock(NULL=None),+ }++ with patch.dict("sys.modules", mock_modules):+ res = await mod.cleanup("10.0.0.5", "admin", "pass", "corp.local", "TestPersistence")++ assert res["success"] is True+ assert "__FilterToConsumerBinding/TestPersistenceBinding" in res["message"]+ assert "CommandLineEventConsumer/TestPersistenceConsumer" in res["message"]+ assert "__EventFilter/TestPersistenceFilter" in res["message"]++ deleted_paths = [call.args[0] for call in mock_services.DeleteInstance.call_args_list]+ assert len(deleted_paths) == 3+ # Check that binding path was deleted+ assert any("__FilterToConsumerBinding.Filter=" in p and "Consumer=" in p for p in deleted_paths)+ assert any("CommandLineEventConsumer.Name=\"TestPersistenceConsumer\"" in p for p in deleted_paths)+ assert any("__EventFilter.Name=\"TestPersistenceFilter\"" in p for p in deleted_paths)+ mock_dcom.disconnect.assert_called_once()+++async def test_wmi_subscription_persistence_established_truthiness():+ """MOD-048: raw['persistence_established'] is empty string on installation failure."""+ mod = _make_module()++ mock_dcom_cls = MagicMock(side_effect=ConnectionRefusedError("Failed"))+ mock_modules = {+ "impacket": MagicMock(),+ "impacket.dcerpc": MagicMock(),+ "impacket.dcerpc.v5": MagicMock(),+ "impacket.dcerpc.v5.dcomrt": MagicMock(DCOMConnection=mock_dcom_cls),+ "impacket.dcerpc.v5.dcom": MagicMock(),+ "impacket.dcerpc.v5.dtypes": MagicMock(NULL=None),+ }++ with patch.dict("sys.modules", mock_modules):+ findings, raw = await mod.run(+ target="10.0.0.5",+ username="admin",+ password="pass",+ domain="corp.local",+ command="notepad.exe",+ subscription_name="FailSub",+ )++ assert raw["success"] is False+ assert raw["persistence_established"] == ""+ assert len(findings) == 0