ARES - authorized red-team engagement automation with dashboard, campaign scope, module orchestration, OPSEC controls, encrypted vault, and reporting.
Python active-directorycloud-securitydefensive-validationfastapigood-first-issuemitre-attackopsecreactred-teamreportingsecurity
fix(security): enforce HTTPS for marketplace modules and make cracker tempdir cross-platform
Mafifrizieb97e40a790d
diff --git a/ares/credential/cracker.py b/ares/credential/cracker.pyindex 955b9fa..ec0a927 100644--- a/ares/credential/cracker.py+++ b/ares/credential/cracker.py@@ -37,6 +37,7 @@ from __future__ import annotationsimport asyncioimport shutilimport subprocess+import tempfileimport timeimport uuidfrom dataclasses import dataclass, field@@ -112,12 +113,15 @@ class CrackingWorker:def __init__(self,vault: Any, # CredentialVault- tmpdir: str = "/tmp/ares-crack",+ tmpdir: str | Path | None = None,timeout_s: int = 3600, # 1 hour max per jobuse_gpu: bool = True,) -> None:self.vault = vault- self.tmpdir = Path(tmpdir)+ if tmpdir is not None:+ self.tmpdir = Path(tmpdir)+ else:+ self.tmpdir = Path(tempfile.gettempdir()) / "ares-crack"self.tmpdir.mkdir(parents=True, exist_ok=True, mode=0o700) # owner-only: hash files may contain sensitive dataself.timeout_s = timeout_sself.use_gpu = use_gpudiff --git a/ares/marketplace/installer.py b/ares/marketplace/installer.pyindex f7de090..c77efb3 100644--- a/ares/marketplace/installer.py+++ b/ares/marketplace/installer.py@@ -37,6 +37,7 @@ import osimport shutilimport sysimport tempfile+import urllib.parseimport urllib.requestfrom dataclasses import asdict, dataclass, fieldfrom pathlib import Path@@ -477,6 +478,14 @@ class ModuleInstaller:def _install_url(self, url: str, force: bool,verify_signature: bool = True) -> ModuleManifest:+ parsed = urllib.parse.urlsplit(url)+ if parsed.scheme != "https":+ raise ValueError(+ f"Insecure scheme {parsed.scheme!r} rejected: marketplace modules must be downloaded via HTTPS."+ )+ if not parsed.hostname or not parsed.hostname.strip():+ raise ValueError("Invalid module URL: missing hostname.")+if not verify_signature:logger.warning("marketplace_url_install_unverified",url=url,@@ -649,8 +658,10 @@ class ModuleInstaller:def _detect_source(source: str) -> str:if source.startswith(("./", "/", "../")) or Path(source).exists():return "local"- if source.startswith("https://"): # http:// rejected - MITM risk+ if source.startswith("https://"):return "url"+ if source.startswith("http://"):+ raise ValueError("Insecure HTTP scheme rejected: marketplace modules must be downloaded via HTTPS.")if source.startswith("github.com/"):return "github"return "community"diff --git a/tests/unit/test_hardening.py b/tests/unit/test_hardening.pyindex fce44b9..0116542 100644--- a/tests/unit/test_hardening.py+++ b/tests/unit/test_hardening.py@@ -636,3 +636,49 @@ class TestRegressionGuard:pytest.fail(f"REGRESSION: Circular ref {path}:{node.lineno}")+++# ═══════════════════════════════════════════════════════════════════════════════+# HARDENING: Marketplace URL Scheme Validation & Cracker Cross-Platform Tmpdir+# ═══════════════════════════════════════════════════════════════════════════════++class TestMarketplaceAndCrackerHardening:+ """Validate that marketplace installer rejects non-HTTPS URLs and cracker is cross-platform."""++ def test_marketplace_installer_rejects_insecure_http_url(self):+ from ares.marketplace.installer import ModuleInstaller+ installer = ModuleInstaller()+ with pytest.raises(ValueError, match="Insecure HTTP scheme rejected"):+ installer.install("http://insecure.example.com/malicious.py")++ def test_marketplace_installer_rejects_file_scheme(self):+ from ares.marketplace.installer import ModuleInstaller+ installer = ModuleInstaller()+ with pytest.raises(ValueError, match="Insecure scheme 'file' rejected"):+ installer._install_url("file:///etc/passwd", force=False)++ def test_marketplace_installer_rejects_url_without_hostname(self):+ from ares.marketplace.installer import ModuleInstaller+ installer = ModuleInstaller()+ with pytest.raises(ValueError, match="missing hostname"):+ installer._install_url("https://", force=False)++ def test_cracker_worker_cross_platform_tmpdir(self, tmp_path):+ import tempfile+ from unittest.mock import MagicMock+ from ares.credential.cracker import CrackingWorker++ vault = MagicMock()+ # Default without tmpdir should use tempfile.gettempdir()+ worker_default = CrackingWorker(vault=vault)+ expected_parent = Path(tempfile.gettempdir())+ assert worker_default.tmpdir.parent == expected_parent+ assert worker_default.tmpdir.name == "ares-crack"+ assert worker_default.tmpdir.exists()++ # Custom tmpdir should be honored+ custom_dir = tmp_path / "custom-crack"+ worker_custom = CrackingWorker(vault=vault, tmpdir=custom_dir)+ assert worker_custom.tmpdir == custom_dir+ assert worker_custom.tmpdir.exists()+