Skip to content

armgit / ARES

Public Imported from GitHub
0

ARES - authorized red-team engagement automation with dashboard, campaign scope, module orchestration, OPSEC controls, encrypted vault, and reporting.

fix(modules): stop dry-runs fabricating findings; redact bulk credential blobs (#68)

kraii_ef7463472621
diff --git a/ares/modules/exfil/secrets_scan.py b/ares/modules/exfil/secrets_scan.py
index 167e664..fbe487b 100644
--- a/ares/modules/exfil/secrets_scan.py
+++ b/ares/modules/exfil/secrets_scan.py
@@ -559,47 +559,12 @@ class SecretsScan(BaseModule):
target=target, technique="T1552.001")
if dry_run:
- mock_hits = [
- {
- "file": r"C:\inetpub\wwwroot\web.config",
- "pattern": "connection_string",
- "line": 42,
- "snippet": "connectionString=\"Server=db01;Password=P@ss1234\"",
- "extracted_secret": "Server=db01;Password=P@ss1234",
- "secret_value": "P@ss1234",
- "entropy": 3.78,
- "confidence": 0.92,
- "is_placeholder": False,
- },
- {
- "file": r"C:\Users\svc_deploy\.aws\credentials",
- "pattern": "aws_access_key",
- "line": 3,
- "snippet": "aws_access_key_id = AKIAIOSFODNN7EXAMPLE",
- "extracted_secret": "AKIAIOSFODNN7EXAMPLE",
- "secret_value": "AKIAIOSFODNN7EXAMPLE",
- "entropy": 3.82,
- "confidence": 0.96,
- "is_placeholder": False,
- },
- ]
- dynamic_conf = round(sum(h["confidence"] for h in mock_hits) / len(mock_hits), 2)
- return [Finding(
- title = f"Secrets found in filesystem on {target}",
- description = (f"Pattern scan found {len(mock_hits)} potential secret(s): "
- + ", ".join(h["pattern"] for h in mock_hits)),
- severity=Severity.CRITICAL, confidence=dynamic_conf,
- module_id=self.MODULE_ID, host=target,
- mitre_technique="T1552.001", mitre_tactic="Credential Access",
- evidence={"hits": mock_hits},
- remediation="Remove hardcoded credentials. Use vault/secrets manager.",
- )], {
- "dry_run": True,
- "credential_list": [h["file"] for h in mock_hits],
- "discovered_secrets": mock_hits,
- "sensitive_data_found": True,
- "hit_count": len(mock_hits),
- }
+ # Dry-run must NOT fabricate findings. A dry run only confirms the
+ # module is dispatchable and in scope; returning a hardcoded CRITICAL
+ # "secret found" through the validated-findings pipeline poisons
+ # reports and dashboards with evidence that was never observed.
+ # Mirror the correct pattern in credential/pass_the_hash.py. (AUDIT run-1 H12)
+ return [], {"dry_run": True}
if not username:
return [], {"error": "no_credential_username"}
diff --git a/ares/modules/exfil/smb_shares.py b/ares/modules/exfil/smb_shares.py
index 5d367f5..46f6c4b 100644
--- a/ares/modules/exfil/smb_shares.py
+++ b/ares/modules/exfil/smb_shares.py
@@ -228,20 +228,10 @@ class SmbSharesExfil(BaseModule):
target=target, technique="T1039")
if dry_run:
- mock_shares = ["SYSVOL", "NETLOGON", "C$", "IPC$", "Data"]
- mock_files = [f"\\\\{target}\\Data\\credentials.xlsx",
- f"\\\\{target}\\Data\\web.config"]
- self.finding(
- title = f"Sensitive files found on SMB shares ({target})",
- description = (f"Shares enumerated: {', '.join(mock_shares)}. "
- f"Sensitive files found: {len(mock_files)}"),
- severity = Severity.HIGH, confidence=0.85,
- mitre_technique="T1039", mitre_tactic="Collection",
- remediation="Restrict SMB share permissions. Enable SMB auditing.",
- host=target,
- )
- return self._findings[:], {"dry_run": True, "file_share_list": mock_shares,
- "sensitive_file_paths": mock_files, "sensitive_data_found": True}
+ # Dry-run must NOT fabricate findings. Returning a hardcoded HIGH
+ # "sensitive files on SMB" finding with invented share/file paths
+ # poisons the validated-findings pipeline. (AUDIT run-1 H13)
+ return [], {"dry_run": True}
try:
from impacket.smbconnection import SMBConnection
diff --git a/ares/modules/reporting/report_gen.py b/ares/modules/reporting/report_gen.py
index 66c21bc..88ab890 100644
--- a/ares/modules/reporting/report_gen.py
+++ b/ares/modules/reporting/report_gen.py
@@ -96,6 +96,14 @@ _SENSITIVE_EVIDENCE_KEYS = {
"key_material",
"ccache",
"ticket",
+ # AUDIT run-1 H18: bulk credential/secret blobs retained in ModuleResult.raw
+ # that must never reach rendered reports (LSASS mini-dump bytes, raw Kerberos
+ # ticket material, plaintext credential sets).
+ "dump_data",
+ "ticket_data",
+ "ticket_b64",
+ "ticket_bytes",
+ "valid_credentials",
}
_SAFE_HASH_METADATA_KEYS = {
"hash_count",
diff --git a/mypy-baseline.txt b/mypy-baseline.txt
index 834e333..3e22e1f 100644
--- a/mypy-baseline.txt
+++ b/mypy-baseline.txt
@@ -163,8 +163,6 @@ ares/modules/descriptors.py|error: "object" has no attribute "__iter__"; maybe "
ares/modules/descriptors.py|error: Argument 1 to "extend" of "list" has incompatible type "list[tuple[str, ...]]"; expected "Iterable[tuple[str]]" [arg-type]
ares/modules/descriptors.py|error: Item "function" of "dict[str, JsonValue] | Callable[[JsonDict], None]" has no attribute "get" [union-attr]
ares/modules/exfil/secrets_scan.py|error: Argument 3 to "getattr" has incompatible type "str"; expected "bool" [arg-type]
-ares/modules/exfil/secrets_scan.py|error: Generator has incompatible item type "object"; expected "bool" [misc]
-ares/modules/exfil/secrets_scan.py|error: Generator has incompatible item type "object"; expected "str" [misc]
ares/modules/exfil/secrets_scan.py|error: Item "None" of "Any | None" has no attribute "get_secret_value" [union-attr]
ares/modules/exfil/smb_shares.py|error: Argument 3 to "getattr" has incompatible type "str"; expected "bool" [arg-type]
ares/modules/exfil/smb_shares.py|error: Item "None" of "Any | None" has no attribute "get_secret_value" [union-attr]
@@ -199,10 +197,10 @@ ares/modules/recon/fingerprint.py|error: Item "None" of "Any | None" has no attr
ares/modules/reporting/report_gen.py|error: Incompatible types in assignment (expression has type "Generator[tuple[str, Any], None, None]", variable has type "dict_items[Any, Any]") [assignment]
ares/modules/reporting/report_gen.py|error: Incompatible types in assignment (expression has type "tuple[tuple[str, Any]]", variable has type "dict_items[Any, Any]") [assignment]
ares/modules/reporting/report_gen.py|error: Module has no attribute "windll" [attr-defined]
-ares/modules/reporting/report_gen.py|error: Name "_build_attack_path_narrative" already defined on line 239 [no-redef]
-ares/modules/reporting/report_gen.py|error: Name "_build_exec_summary" already defined on line 260 [no-redef]
-ares/modules/reporting/report_gen.py|error: Name "_build_mitre_map" already defined on line 219 [no-redef]
-ares/modules/reporting/report_gen.py|error: Name "lines" already defined on line 1946 [no-redef]
+ares/modules/reporting/report_gen.py|error: Name "_build_attack_path_narrative" already defined on line 247 [no-redef]
+ares/modules/reporting/report_gen.py|error: Name "_build_exec_summary" already defined on line 268 [no-redef]
+ares/modules/reporting/report_gen.py|error: Name "_build_mitre_map" already defined on line 227 [no-redef]
+ares/modules/reporting/report_gen.py|error: Name "lines" already defined on line 1954 [no-redef]
ares/modules/sdk.py|error: "type" has no attribute "DEFAULT_TIMEOUT_S" [attr-defined]
ares/modules/sdk.py|error: "type" has no attribute "MITRE_TECHNIQUES" [attr-defined]
ares/modules/sdk.py|error: "type" has no attribute "MODULE_AUTHOR" [attr-defined]
diff --git a/tests/unit/modules/test_exfil_protocol_scope_mod073.py b/tests/unit/modules/test_exfil_protocol_scope_mod073.py
index 6ba6a41..9ae37a5 100644
--- a/tests/unit/modules/test_exfil_protocol_scope_mod073.py
+++ b/tests/unit/modules/test_exfil_protocol_scope_mod073.py
@@ -88,3 +88,42 @@ async def test_smb_shares_uses_smb_protocol():
)
mock_before_req.assert_awaited_once_with("192.168.1.102", "smb")
+
+
+async def test_smb_shares_dry_run_fabricates_no_findings():
+ """AUDIT run-1 H13: dry run must not emit a fabricated HIGH finding.
+
+ The previous implementation returned a hardcoded HIGH 'sensitive files on
+ SMB shares' finding with invented share/file paths through the
+ validated-findings pipeline. A dry run only confirms dispatchability.
+ """
+ settings, campaign, noise = _make_deps()
+ mod = SmbSharesExfil(settings=settings, campaign=campaign, noise=noise)
+ findings, raw = await mod.run(target="192.168.1.102", username="Administrator", dry_run=True)
+ assert findings == []
+ assert raw.get("dry_run") is True
+ assert not raw.get("sensitive_data_found")
+ assert not raw.get("sensitive_file_paths")
+
+
+def test_bulk_credential_blobs_are_redacted_from_evidence():
+ """AUDIT run-1 H18: LSASS dump bytes, raw ticket material and credential
+ sets must be redacted before evidence reaches a rendered report."""
+ from ares.modules.reporting.report_gen import _redact_sensitive_evidence
+
+ payload = {
+ "target": "dc01.corp.local",
+ "dump_data": b"MZ\x90\x00" + b"\x00" * 1024,
+ "ticket_data": b"\x76\x82\x01",
+ "ticket_b64": "doIBAA==",
+ "ticket_bytes": b"\x76\x82",
+ "valid_credentials": [{"user": "svc", "password": "S3cret!"}],
+ "hash_count": 3, # safe metadata must survive
+ }
+ safe = _redact_sensitive_evidence(payload)
+ for leaked in ("dump_data", "ticket_data", "ticket_b64", "ticket_bytes", "valid_credentials"):
+ assert "S3cret" not in str(safe.get(leaked, ""))
+ assert safe.get(leaked) != payload[leaked]
+ assert safe["hash_count"] == 3
+ assert safe["target"] == "dc01.corp.local"
diff --git a/tests/unit/modules/test_secrets_scan.py b/tests/unit/modules/test_secrets_scan.py
index 92fdae0..27201b3 100644
--- a/tests/unit/modules/test_secrets_scan.py
+++ b/tests/unit/modules/test_secrets_scan.py
@@ -1,7 +1,7 @@
import pytest
-from ares.core.campaign import Campaign, NoiseProfile, ScopeEntry, Severity
+from ares.core.campaign import Campaign, NoiseProfile, ScopeEntry
from ares.core.config import AresSettings
from ares.core.context import ExecutionContext
from ares.core.noise import NoiseController
@@ -150,30 +150,21 @@ class TestSecretsScanModuleExecution:
assert res.raw.get("dry_run") is True
@pytest.mark.asyncio
- async def test_run_dry_run_produces_dynamic_confidence_and_structured_hits(self):
+ async def test_run_dry_run_fabricates_no_findings(self):
+ """AUDIT run-1 H12: a dry run must never emit fabricated secret findings.
+
+ The previous implementation returned a hardcoded CRITICAL finding with
+ two invented hits (AKIAIOSFODNN7EXAMPLE / web.config connection string)
+ through the validated-findings pipeline, poisoning reports and
+ dashboards with evidence that was never observed. A dry run only
+ confirms dispatchability; it must yield zero findings.
+ """
mod, _ = _make_module()
findings, raw = await mod.run(target="192.168.56.105", dry_run=True)
- assert len(findings) == 1
- finding = findings[0]
-
- # Verify dynamic confidence (NOT hardcoded 0.60 template)
- assert finding.confidence > 0.60
- assert finding.severity == Severity.CRITICAL
- assert "hits" in finding.evidence
- assert len(finding.evidence["hits"]) == 2
-
- # Verify hit structure includes actual secrets and entropy
- hit1 = finding.evidence["hits"][0]
- assert "extracted_secret" in hit1
- assert "secret_value" in hit1
- assert "entropy" in hit1
- assert "confidence" in hit1
- assert isinstance(hit1["entropy"], float)
- assert isinstance(hit1["confidence"], float)
-
- # Verify raw output has discovered_secrets for UI fallback
- assert "discovered_secrets" in raw
- assert len(raw["discovered_secrets"]) == 2
+ assert findings == []
+ assert raw.get("dry_run") is True
+ assert not raw.get("discovered_secrets")
+ assert not raw.get("sensitive_data_found")
@pytest.mark.asyncio
async def test_live_execution_pipeline_with_mocked_scan(self, monkeypatch):