Skip to content

Give your AI agent eyes to see the entire internet. Read & search Twitter, Reddit, YouTube, GitHub, Bilibili, XiaoHongShu — one CLI, zero API fees.

fix(skill): propagate install failures

Pnant37ddb8d4db73
diff --git a/agent_reach/cli.py b/agent_reach/cli.py
index fb691124..dae3b3fe 100644
--- a/agent_reach/cli.py
+++ b/agent_reach/cli.py
@@ -625,7 +625,8 @@ def _uninstall_skill():
def _cmd_skill(args):
"""Manage agent skill registration."""
if args.install:
- _install_skill()
+ if not _install_skill():
+ raise SystemExit(1)
elif args.uninstall:
_uninstall_skill()
diff --git a/tests/test_skill_command.py b/tests/test_skill_command.py
index 1bbffcb5..33733ae7 100644
--- a/tests/test_skill_command.py
+++ b/tests/test_skill_command.py
@@ -5,10 +5,11 @@ import importlib.resources
import os
import tempfile
import unittest
+from argparse import Namespace
from pathlib import Path
from unittest.mock import patch
-from agent_reach.cli import _install_skill, _uninstall_skill
+from agent_reach.cli import _cmd_skill, _install_skill, _uninstall_skill
class TestSkillCommand(unittest.TestCase):
@@ -91,6 +92,20 @@ class TestSkillCommand(unittest.TestCase):
self.assertNotIn("linkedin-scraper.", linkedin_section)
self.assertNotIn("--transport streamable-http", linkedin_section)
+ def test_localized_readmes_use_current_linkedin_server_name(self):
+ root = Path(__file__).resolve().parents[1]
+ for name in ("README_ja.md", "README_ko.md"):
+ content = (root / "docs" / name).read_text(encoding="utf-8")
+ self.assertIn("mcp-server-linkedin", content)
+ self.assertNotIn("linkedin-scraper-mcp", content)
+
+ def test_skill_install_command_exits_nonzero_when_install_fails(self):
+ with patch("agent_reach.cli._install_skill", return_value=False):
+ with self.assertRaises(SystemExit) as raised:
+ _cmd_skill(Namespace(install=True, uninstall=False))
+
+ self.assertEqual(raised.exception.code, 1)
+
def test_install_skill_creates_skill_md(self):
"""_install_skill should create SKILL.md in the first available skill dir."""
with tempfile.TemporaryDirectory() as tmpdir: