Open-source AI Security Operations Center: alert fusion, LLM-agent triage, MITRE ATT&CK investigation, and a replayable decision ledger for every agent step. Self-hostable, runs with no API keys, MIT licensed. Ships an MCP server for Claude, Cursor and Continue.
Python agentic-aiai-securityalert-triageblue-teamcybersecuritydetection-engineeringincident-responselanggraphllm-agentsmcpmitre-attackmodel-context-protocolpurple-teamsecurity-operationsself-hostedsiemsoarsocthreat-detectionthreat-intelligence
fix: actually clear the last three CodeQL findings (#700)
Beenu Aroraa392bb340327
diff --git a/scripts/generate_connector_docs.py b/scripts/generate_connector_docs.pyindex 8cf76f423..dc5dec315 100644--- a/scripts/generate_connector_docs.py+++ b/scripts/generate_connector_docs.py@@ -204,9 +204,7 @@ def render(schema, human: str) -> str:lines += [":::note Credential handling",(- f"{names} "- + ("is" if len(secret_fields) == 1 else "are")- + " encrypted at rest by the credential vault before the row is "+ f"{names} " + ("is" if len(secret_fields) == 1 else "are") + " encrypted at rest by the credential vault before the row is ""written, and decrypted only at poll time. The value is never ""logged and never returned by the API — a read of the saved ""connector shows the field as set, not its contents. See "@@ -224,20 +222,33 @@ def render(schema, human: str) -> str:"",]- lines += [- "## Setup",- "",- "1. In the console, go to **Connectors → Add connector** and pick " f"**{title}**.",- "2. Fill in the fields above and run **Test connection**. The test is " "read-only and does not save anything.",+ # Built as named strings rather than inline. Adjacent string literals+ # inside a list are implicitly concatenated, which is indistinguishable+ # from a missing comma — the reader cannot tell three list items from+ # one, and neither can a reviewer.+ step_pick = f"1. In the console, go to **Connectors → Add connector** and pick **{title}**."+ step_test = "2. Fill in the fields above and run **Test connection**. " "The test is read-only and does not save anything."+ step_save = ("3. Save. Polling starts on a jittered schedule within about a minute; "- "the connector row shows `last_sync` once the first poll completes.",- "",- ":::tip If `last_sync` stays empty",+ "the connector row shows `last_sync` once the first poll completes."+ )+ empty_sync_tip = ("The first poll is the honest signal that the credential works. A ""connector that saves cleanly and never syncs usually means the ""credential lacks a scope the vendor requires for reads — check the ""connectors service log for the vendor's own error, which is passed "- "through verbatim rather than summarised.",+ "through verbatim rather than summarised."+ )++ lines += [+ "## Setup",+ "",+ step_pick,+ step_test,+ step_save,+ "",+ ":::tip If `last_sync` stays empty",+ empty_sync_tip,":::","",HUMAN_START,@@ -283,9 +294,7 @@ def render_field_reference(schema) -> str:lines += [":::note Credential handling",(- f"{names} "- + ("is" if len(secret_fields) == 1 else "are")- + " encrypted at rest by the credential vault before the row is "+ f"{names} " + ("is" if len(secret_fields) == 1 else "are") + " encrypted at rest by the credential vault before the row is ""written, and decrypted only at poll time. The value is never ""logged and never returned by the API. See ""[credential vault](../operations/credentials.md)."diff --git a/tests/test_detection_id_stability.py b/tests/test_detection_id_stability.pyindex d52f70899..1a557885d 100644--- a/tests/test_detection_id_stability.py+++ b/tests/test_detection_id_stability.py@@ -24,9 +24,11 @@ sys.path.insert(0, str(REPO_ROOT / "scripts"))LOCK_PATH = REPO_ROOT / "detections" / "rule-ids.lock.json"-# Imported for its side effect of populating sys.modules, so the corrupt--# lock test can patch the module object without a second import style.-import generate_detections # noqa: E402,F401+# One import style for this module throughout: the tests need both the+# functions and the module object (to patch ID_LOCK), and mixing+# `import X` with `from X import y` for the same module is what+# py/import-and-import-from flags.+import generate_detections # noqa: E402@pytest.fixture(scope="module")@@ -50,9 +52,7 @@ def test_regeneration_assigns_no_new_ids(categories: dict, lock: dict[str, str])was added, and the next run would write one — which is a diff nobodyreviewed."""- from generate_detections import assign_ids-- resolved, newly = assign_ids(categories)+ resolved, newly = generate_detections.assign_ids(categories)assert not newly, (f"{len(newly)} spec(s) have no locked id: {', '.join(sorted(newly)[:8])}. "f"Run scripts/generate_detections.py and commit detections/rule-ids.lock.json."@@ -62,12 +62,10 @@ def test_regeneration_assigns_no_new_ids(categories: dict, lock: dict[str, str])def test_inserting_a_rule_does_not_renumber_the_others(categories: dict, lock: dict[str, str]) -> None:"""The exact bug. Insertion at the front used to move 81 network ids."""- from generate_detections import assign_ids-mutated = {k: list(v) for k, v in categories.items()}mutated["network"].insert(0, {"slug": "zzz-test-inserted-first"})- resolved, newly = assign_ids(mutated)+ resolved, newly = generate_detections.assign_ids(mutated)moved = {k: (lock[k], resolved[k]) for k in lock if resolved.get(k) != lock[k]}assert not moved, f"inserting one rule moved {len(moved)} existing ids: " f"{list(moved.items())[:3]}"@@ -75,11 +73,9 @@ def test_inserting_a_rule_does_not_renumber_the_others(categories: dict, lock: ddef test_a_new_rule_takes_the_next_free_number(categories: dict, lock: dict[str, str]) -> None:- from generate_detections import assign_ids-mutated = {k: list(v) for k, v in categories.items()}mutated["network"].append({"slug": "zzz-test-appended"})- resolved, _ = assign_ids(mutated)+ resolved, _ = generate_detections.assign_ids(mutated)existing = {int(v.rsplit("-", 1)[1]) for k, v in lock.items() if k.startswith("network/")}assigned = int(resolved["network/zzz-test-appended"].rsplit("-", 1)[1])@@ -91,10 +87,8 @@ def test_a_deleted_rule_does_not_recycle_its_id(lock: dict[str, str]) -> None:The lock is never pruned, so a removed rule's id stays burned."""- from generate_detections import assign_ids-reduced = {"network": [{"slug": "zzz-test-only-rule"}]}- resolved, _ = assign_ids(reduced)+ resolved, _ = generate_detections.assign_ids(reduced)burned = {v for k, v in lock.items() if k.startswith("network/")}assert resolved["network/zzz-test-only-rule"] not in burned, "a new rule was given an id that a previous rule already used"@@ -118,9 +112,7 @@ def test_a_corrupt_lock_refuses_rather_than_renumbering(tmp_path: Path, monkeypa# setattr on the module object reached through sys.modules, so the file# keeps a single import style — mixing `import X as m` with `from X# import y` for the same module is what CodeQL flags.- monkeypatch.setattr(sys.modules["generate_detections"], "ID_LOCK", bad)-- from generate_detections import load_id_lock+ monkeypatch.setattr(generate_detections, "ID_LOCK", bad)with pytest.raises(SystemExit, match="unreadable"):- load_id_lock()+ generate_detections.load_id_lock()