Skip to content

armgit / AiSOC

Public Imported from GitHub
0

Open-source AI Security Operations Center: alert fusion, LLM-agent triage, MITRE ATT&CK investigation, and a replayable decision ledger for every agent step. Self-hostable, runs with no API keys, MIT licensed. Ships an MCP server for Claude, Cursor and Continue.

style(ueba): ruff format peer_group + baseline scoring tests (#607)

Beenu Aroraca603c3da4f6
diff --git a/services/ueba/app/services/peer_group.py b/services/ueba/app/services/peer_group.py
index 864cd38cd..bdb2be0f5 100644
--- a/services/ueba/app/services/peer_group.py
+++ b/services/ueba/app/services/peer_group.py
@@ -101,11 +101,7 @@ class PeerGroupService:
# ``None`` marks a feature whose peer baseline cannot be scored; keeping
# it out means a group of uniformly-degenerate features yields no peer
# signal at all, rather than a 0.0 that halves the caller's composite.
- z_scores = [
- z
- for z in (compute_z_score(stats, f, v) for f, v in features.items())
- if z is not None
- ]
+ z_scores = [z for z in (compute_z_score(stats, f, v) for f, v in features.items()) if z is not None]
if not z_scores:
return None
diff --git a/services/ueba/tests/test_baseline_scoring.py b/services/ueba/tests/test_baseline_scoring.py
index 2865bfa48..e83d1b478 100644
--- a/services/ueba/tests/test_baseline_scoring.py
+++ b/services/ueba/tests/test_baseline_scoring.py
@@ -12,6 +12,7 @@ mean, so the RSS composite read "no signal" as "all clear"; service accounts,
batch jobs and automation users converge on a constant stream and could never
raise an anomaly.
"""
+
from __future__ import annotations
import math
@@ -35,10 +36,7 @@ def _feed(values: list[float], feature: str = "f") -> dict[str, dict[str, float]
def _scored(*z_scores: float) -> dict[str, dict[str, float]]:
"""Build a `score_features`-shaped payload carrying the given z-scores."""
- return {
- f"feature_{i}": {"value": 0.0, "mean": 0.0, "std": 1.0, "z_score": z}
- for i, z in enumerate(z_scores)
- }
+ return {f"feature_{i}": {"value": 0.0, "mean": 0.0, "std": 1.0, "z_score": z} for i, z in enumerate(z_scores)}
class TestWelfordUpdate:
@@ -87,9 +85,7 @@ class TestComputeZScoreEstablishedBaseline:
def test_scores_value_against_baseline(self):
stats = _feed([10.0, 12.0, 14.0, 11.0, 13.0])
s = stats["f"]
- assert compute_z_score(stats, "f", 20.0, min_samples=5) == pytest.approx(
- abs(20.0 - s["mean"]) / s["std"]
- )
+ assert compute_z_score(stats, "f", 20.0, min_samples=5) == pytest.approx(abs(20.0 - s["mean"]) / s["std"])
def test_deviation_is_absolute_in_both_directions(self):
stats = _feed([10.0, 12.0, 14.0, 11.0, 13.0])
@@ -100,9 +96,7 @@ class TestComputeZScoreEstablishedBaseline:
# A genuinely normal observation still scores 0.0 — this is the value
# that must stay distinct from the unscoreable None below.
stats = _feed([10.0, 12.0, 14.0, 11.0, 13.0])
- assert compute_z_score(
- stats, "f", stats["f"]["mean"], min_samples=5
- ) == pytest.approx(0.0)
+ assert compute_z_score(stats, "f", stats["f"]["mean"], min_samples=5) == pytest.approx(0.0)
def test_defaults_to_the_configured_sample_gate(self):
# Thirty observations clear settings.min_baseline_samples unaided.
@@ -169,9 +163,7 @@ class TestCompositeScore:
def test_zero_scored_features_contribute_nothing(self):
# Why dropping unscoreable features later is numerically neutral:
# RSS has no denominator, and 0**2 adds nothing to the sum.
- assert _composite_score(_scored(3.0, 4.0)) == pytest.approx(
- _composite_score(_scored(3.0, 4.0, 0.0, 0.0))
- )
+ assert _composite_score(_scored(3.0, 4.0)) == pytest.approx(_composite_score(_scored(3.0, 4.0, 0.0, 0.0)))
def test_only_unscoreable_features_score_zero(self):
assert _composite_score({"a": {"z_score": None}, "b": {"z_score": None}}) == 0.0
@@ -182,9 +174,7 @@ class TestCompositeScore:
def test_is_not_normalised_by_feature_count(self):
# Ten mild deviations outrank three identical ones.
- assert _composite_score(_scored(*([2.0] * 10))) > _composite_score(
- _scored(2.0, 2.0, 2.0)
- )
+ assert _composite_score(_scored(*([2.0] * 10))) > _composite_score(_scored(2.0, 2.0, 2.0))
class TestUnscoreableFeatures: