Skip to content

armgit / AiSOC

Public Imported from GitHub
0

Open-source AI Security Operations Center: alert fusion, LLM-agent triage, MITRE ATT&CK investigation, and a replayable decision ledger for every agent step. Self-hostable, runs with no API keys, MIT licensed. Ships an MCP server for Claude, Cursor and Continue.

fix(connectors): Datadog emergency and alert outrank critical — map them to critical too

beenuare495f3d3f69a
diff --git a/apps/docs/docs/connectors/datadog.md b/apps/docs/docs/connectors/datadog.md
index 23844e042..0adc34038 100644
--- a/apps/docs/docs/connectors/datadog.md
+++ b/apps/docs/docs/connectors/datadog.md
@@ -59,15 +59,16 @@ For `mode: logs` (the `status` / `level` attribute):
| AiSOC severity | Datadog log status |
|---|---|
-| `critical` | `critical` |
-| `high` | `emergency`, `alert` |
+| `critical` | `emergency`, `alert`, `critical` |
| `medium` | `error` |
| `low` | `warn`, `warning` |
| `info` | `notice`, `info`, `debug`, missing |
-Datadog's native `critical` status is preserved on AiSOC's five-tier
-severity ladder. The `emergency` and `alert` statuses remain `high`,
-above routine `error` logs in the alert queue.
+Datadog log statuses follow syslog ordering, in which `emergency` (0)
+and `alert` (1) outrank `critical` (2) — so all three map to AiSOC's
+top tier. Mapping `emergency` or `alert` below `critical` would invert
+the vendor's own ladder. Nothing from `mode: logs` maps to `high`;
+routine `error` logs stay at `medium`, below anything that pages.
For `mode: events` (the monitor `alert_type` attribute):
diff --git a/services/connectors/app/connectors/datadog.py b/services/connectors/app/connectors/datadog.py
index 9b1e45752..99f994614 100644
--- a/services/connectors/app/connectors/datadog.py
+++ b/services/connectors/app/connectors/datadog.py
@@ -236,8 +236,11 @@ class DatadogConnector(BaseConnector):
return [self.normalize({"_kind": "event", **ev}) for ev in events]
_LOG_LEVEL_SEVERITY = {
- "emergency": "high",
- "alert": "high",
+ # Datadog log statuses follow syslog ordering: emergency (0) and
+ # alert (1) outrank critical (2). Mapping them below `critical` would
+ # invert the vendor's own ladder, so all three share AiSOC's top tier.
+ "emergency": "critical",
+ "alert": "critical",
"critical": "critical",
"error": "medium",
"warn": "low",
diff --git a/services/connectors/tests/connectors/test_datadog.py b/services/connectors/tests/connectors/test_datadog.py
index a896d6754..01cd10e39 100644
--- a/services/connectors/tests/connectors/test_datadog.py
+++ b/services/connectors/tests/connectors/test_datadog.py
@@ -65,6 +65,16 @@ def test_normalize_log_critical_preserves_critical(fixture):
assert out["service"] == "api"
+def test_normalize_log_emergency_and_alert_outrank_critical():
+ # Syslog ordering: emergency (0) and alert (1) are MORE severe than
+ # critical (2). They must never map below critical's tier, or a paging
+ # emergency would rank under a critical log in the alert queue.
+ for status in ("emergency", "alert"):
+ out = _logs_connector().normalize({"attributes": {"status": status, "message": "m"}})
+ assert out["severity"] == "critical", status
+ assert out["raw_event"]["attributes"]["status"] == status
+
+
def test_normalize_log_error_to_medium(fixture):
assert _logs_connector().normalize(fixture["logs"][1])["severity"] == "medium"