Skip to content

armgit / AiSOC

Public Imported from GitHub
0

Open-source AI Security Operations Center: alert fusion, LLM-agent triage, MITRE ATT&CK investigation, and a replayable decision ledger for every agent step. Self-hostable, runs with no API keys, MIT licensed. Ships an MCP server for Claude, Cursor and Continue.

fix(security): resolve open CodeQL alerts (stack-trace exposure + empty-except) (#583)

Beenu Aroraed0f1fc79cc6
diff --git a/services/api/app/services/backtest.py b/services/api/app/services/backtest.py
index 8bdeed674..4be0d5928 100644
--- a/services/api/app/services/backtest.py
+++ b/services/api/app/services/backtest.py
@@ -60,6 +60,8 @@ def rows_to_events(columns: list[str], rows: list[list[Any]]) -> list[dict[str,
# keep the OCSF columns available too.
event = {**event, **parsed}
except (ValueError, TypeError):
+ # Payload isn't valid JSON — keep the event as-is rather than
+ # drop it (best-effort raw_data expansion).
pass
elif isinstance(payload, dict):
event = {**event, **payload}
diff --git a/services/api/app/services/report_builder.py b/services/api/app/services/report_builder.py
index 7e4d03d73..c1416c55e 100644
--- a/services/api/app/services/report_builder.py
+++ b/services/api/app/services/report_builder.py
@@ -10,10 +10,13 @@ and an exported PDF/HTML report.
from __future__ import annotations
+import logging
from collections.abc import Callable
from dataclasses import dataclass, field
from typing import Any
+logger = logging.getLogger(__name__)
+
WIDGET_TYPES = frozenset({"metric", "table", "timeseries", "bar", "pie", "text"})
# Whitelisted data sources a widget may bind to. Extend as new resolvers land.
DATA_SOURCES = frozenset(
@@ -100,7 +103,11 @@ def render_report(definition: ReportDefinition, resolvers: dict[str, Resolver])
else:
try:
entry["data"] = resolver(widget.params)
- except Exception as exc: # noqa: BLE001 — one bad widget shouldn't break the report
- entry["error"] = f"{type(exc).__name__}: {exc}"
+ except Exception: # noqa: BLE001 — one bad widget shouldn't break the report
+ # Log the detail server-side but never expose the raw
+ # exception (it may carry stack/internal detail) to the API
+ # caller — the widget just carries a generic error.
+ logger.warning("report widget %r resolver failed", widget.id, exc_info=True)
+ entry["error"] = "resolver failed"
rendered.append(entry)
return {"name": definition.name, "widgets": rendered}
diff --git a/services/connectors/app/connectors/splunk.py b/services/connectors/app/connectors/splunk.py
index cbc5bf070..bc14be813 100644
--- a/services/connectors/app/connectors/splunk.py
+++ b/services/connectors/app/connectors/splunk.py
@@ -211,6 +211,7 @@ class SplunkConnector(BaseConnector):
if isinstance(data, dict) and data.get("sid"):
return str(data["sid"])
except (ValueError, KeyError):
+ # Response wasn't JSON with a sid — fall through to the XML path below.
pass
# The dispatch endpoint may answer with XML (<sid>…</sid>) despite
# output_mode=json depending on Splunk version.
diff --git a/services/fusion/app/services/windowed_detection.py b/services/fusion/app/services/windowed_detection.py
index d868ae936..8caaa1b2b 100644
--- a/services/fusion/app/services/windowed_detection.py
+++ b/services/fusion/app/services/windowed_detection.py
@@ -122,6 +122,7 @@ class WindowedDetectionEngine:
if isinstance(parsed, dict):
return parsed
except (ValueError, TypeError):
+ # raw_data isn't valid JSON — fall back to the OCSF envelope.
pass
return ocsf