Skip to content

πŸ“š The open-source, offline-first Notion, Obsidian & Confluence alternative. Advanced Markdown, multi-tenant teams, OIDC/SSO, and local S3 backups. Deploy in one command.

Fix escape html panic on nil pointers

Smaug673902ae1a91b32a
diff --git a/backend/controllers/nodes.controller.go b/backend/controllers/nodes.controller.go
index 2138cbbe..7f419b92 100644
--- a/backend/controllers/nodes.controller.go
+++ b/backend/controllers/nodes.controller.go
@@ -172,7 +172,7 @@ func (ctr *Controller) CreateNode(c *gin.Context) (int, any) {
if err != nil {
return http.StatusUnauthorized, err
}
- escapedHTMLContent := utils.EscapeHTML(*node.ContentCompiled)
+ escapedHTMLContent := utils.EscapeHTML(node.ContentCompiled)
node = &models.Node{
Id: ctr.app.Snowflake.Generate(),
ParentId: node.ParentId,
@@ -246,7 +246,7 @@ func (ctr *Controller) UpdateNode(c *gin.Context) (int, any) {
node.Accessibility = dbNode.Accessibility
node.Access = dbNode.Access
}
- escapedHTMLContent := utils.EscapeHTML(*node.ContentCompiled)
+ escapedHTMLContent := utils.EscapeHTML(node.ContentCompiled)
node = &models.Node{
Id: nodeId,
ParentId: node.ParentId,
diff --git a/backend/utils/escape-html.go b/backend/utils/escape-html.go
index 74110566..a4e2fe12 100644
--- a/backend/utils/escape-html.go
+++ b/backend/utils/escape-html.go
@@ -99,6 +99,9 @@ func InitBluemonday() {
}
// EscapeHTML sanitizes user input to prevent XSS attacks
-func EscapeHTML(input string) string {
- return policy.Sanitize(input)
+func EscapeHTML(input *string) string {
+ if input == nil || *input == "" {
+ return ""
+ }
+ return policy.Sanitize(*input)
}