Skip to content

πŸ“š The open-source, offline-first Notion, Obsidian & Confluence alternative. Advanced Markdown, multi-tenant teams, OIDC/SSO, and local S3 backups. Deploy in one command.

Fix code style: remove duplicate code, simplify css

Smaug673986eadd649eec
diff --git a/frontend/app/components/AppCheck.vue b/frontend/app/components/AppCheck.vue
index d5b97610..d70933b5 100644
--- a/frontend/app/components/AppCheck.vue
+++ b/frontend/app/components/AppCheck.vue
@@ -53,8 +53,8 @@ function toggle() {
}
input:checked + .checkmark {
- border-color: var(--primary, var(--primary));
- background: var(--primary, var(--primary));
+ border-color: var(--primary);
+ background: var(--primary);
}
.label {
diff --git a/frontend/app/components/AppDotMenu.vue b/frontend/app/components/AppDotMenu.vue
index 4438a570..8118c4ab 100644
--- a/frontend/app/components/AppDotMenu.vue
+++ b/frontend/app/components/AppDotMenu.vue
@@ -1,5 +1,5 @@
<template>
- <div ref="menuRoot" class="container">
+ <div class="container">
<span class="menu-button" aria-label="Menu" @click="toggleMenu">
<svg class="menu-icon" viewBox="0 9 20 2" xmlns="http://www.w3.org/2000/svg">
<path
@@ -19,7 +19,7 @@
<script setup lang="ts">
const open = ref(false);
const emit = defineEmits(['open', 'close']);
-const menuRoot: Ref<HTMLDivElement | undefined> = ref();
+
const toggleMenu = () => {
open.value = !open.value;
emit(open.value ? 'open' : 'close');
@@ -29,7 +29,9 @@ const handleClickOutside = () => {
open.value = false;
emit('close');
};
+
const close = () => (open.value = false);
+
defineExpose({ close, opened: open });
onMounted(() => document.addEventListener('mousedown', handleClickOutside));
diff --git a/frontend/app/components/AppDrop.vue b/frontend/app/components/AppDrop.vue
index 3f7a2eb5..f9762737 100644
--- a/frontend/app/components/AppDrop.vue
+++ b/frontend/app/components/AppDrop.vue
@@ -22,9 +22,9 @@
</template>
<script setup lang="ts">
import { readableFileSize } from '~/helpers/ressources';
-const selectedFile: Ref<File | null | undefined> = ref(null);
+const selectedFile = ref<File | null>(null);
const isDragOver = ref(false);
-const fileInput: Ref<HTMLInputElement | null> = ref(null);
+const fileInput = ref<HTMLInputElement | null>(null);
const triggerFileSelect = () => fileInput.value!.click();
const handleFileSelect = (event: Event) => {
emit('select', (event.target as HTMLInputElement | null)?.files?.[0] || null);
@@ -33,8 +33,11 @@ const handleFileSelect = (event: Event) => {
const emit = defineEmits(['select']);
const handleFileDrop = (event: DragEvent) => {
if (event.dataTransfer?.files && event.dataTransfer.files.length > 0) {
- selectedFile.value = event.dataTransfer.files[0];
- emit('select', event.dataTransfer.files[0]);
+ const file = event.dataTransfer.files[0];
+ if (file) {
+ selectedFile.value = file;
+ emit('select', file);
+ }
isDragOver.value = false;
}
};
diff --git a/frontend/app/components/AppTagInput.vue b/frontend/app/components/AppTagInput.vue
index 3d6da531..b001ae86 100644
--- a/frontend/app/components/AppTagInput.vue
+++ b/frontend/app/components/AppTagInput.vue
@@ -69,12 +69,6 @@ button {
}
input {
- min-width: 80px;
- padding: 0 4px;
- border: none;
- background: transparent;
- flex: 1;
- outline: none;
flex: 1 1 150px;
min-width: 100px;
padding: 4px 8px;
diff --git a/frontend/app/components/DocumentCard.vue b/frontend/app/components/DocumentCard.vue
index 43a33278..b5d5df60 100644
--- a/frontend/app/components/DocumentCard.vue
+++ b/frontend/app/components/DocumentCard.vue
@@ -33,12 +33,13 @@
</template>
<script setup lang="ts">
-import type { Node } from '~/stores';
import DeleteDocumentModal from '~/components/Node/DeleteNodeModal.vue';
import NodeContextMenu from '~/components/Node/NodeContextMenu.vue';
+import type { Node } from '~/stores';
const props = defineProps<{ document: Node }>();
const nodesStore = useNodesStore();
+
const category = computed(() => nodesStore.getById(props.document.parent_id || ''));
useUserStore().fetchPublicUser(props.document.user_id);
const user = computed(() => useUserStore().getById(props.document.user_id || ''));
diff --git a/frontend/app/components/Loader.vue b/frontend/app/components/Loader.vue
index df36cd68..34d979e1 100644
--- a/frontend/app/components/Loader.vue
+++ b/frontend/app/components/Loader.vue
@@ -3,7 +3,6 @@
</template>
<style scoped>
-/* HTML: <div class="loader"></div> */
.loader {
width: 25px;
background: var(--c) 0% 50%, var(--c) 50% 50%, var(--c) 100% 50%;
diff --git a/frontend/app/components/MarkdownEditor/EditorPreferences.vue b/frontend/app/components/MarkdownEditor/EditorPreferences.vue
index bba01668..e5ded122 100644
--- a/frontend/app/components/MarkdownEditor/EditorPreferences.vue
+++ b/frontend/app/components/MarkdownEditor/EditorPreferences.vue
@@ -1,4 +1,3 @@
-<!-- This components is a modal for advanced editing document metadata -->
<template>
<div class="modal-content">
<h2>Editor preferences</h2>
diff --git a/frontend/app/components/NoContent.vue b/frontend/app/components/NoContent.vue
index a03256a3..dc4ccd75 100644
--- a/frontend/app/components/NoContent.vue
+++ b/frontend/app/components/NoContent.vue
@@ -1,7 +1,7 @@
<template>
- <div style=" margin: 5vh auto;text-align: center">
+ <div class="no-content">
<h1>{{ title || 'Nothing here' }}</h1>
- <img style="max-width: 300px; max-height: 300px" :src="`/empty-${colorMode.value}.png`" />
+ <img :src="`/empty-${colorMode.value}.png`" alt="" />
<p>{{ description }}</p>
<slot />
</div>
@@ -11,3 +11,15 @@
const colorMode = useColorMode();
defineProps<{ title?: string; description?: string }>();
</script>
+
+<style scoped lang="scss">
+.no-content {
+ margin: 5vh auto;
+ text-align: center;
+
+ img {
+ max-width: 300px;
+ max-height: 300px;
+ }
+}
+</style>
diff --git a/frontend/app/components/Node/NodeList.vue b/frontend/app/components/Node/NodeList.vue
index f0531055..00bdd78c 100644
--- a/frontend/app/components/Node/NodeList.vue
+++ b/frontend/app/components/Node/NodeList.vue
@@ -3,9 +3,9 @@
<header>
<h1 v-if="parent">
<Icon
- :name="parent.icon || parent?.icon || 'files'"
+ :name="parent.icon || 'files'"
display="xl"
- :class="`parent-icon ${getAppColor(parent.color || parent?.color as number, true)}`"
+ :class="`parent-icon ${getAppColor(parent.color as number, true)}`"
/>
{{ parent.name }}
</h1>
diff --git a/frontend/app/components/NodeDotMenu.vue b/frontend/app/components/NodeDotMenu.vue
index cabd0623..411f2a23 100644
--- a/frontend/app/components/NodeDotMenu.vue
+++ b/frontend/app/components/NodeDotMenu.vue
@@ -1,5 +1,5 @@
<template>
- <AppDotMenu ref="dotMenu">
+ <AppDotMenu>
<NodeContextMenu :node="node" />
</AppDotMenu>
</template>
diff --git a/frontend/app/components/NodeWorkspaceCard.vue b/frontend/app/components/NodeWorkspaceCard.vue
index 657696d6..513bc00d 100644
--- a/frontend/app/components/NodeWorkspaceCard.vue
+++ b/frontend/app/components/NodeWorkspaceCard.vue
@@ -49,35 +49,17 @@ const getWorkspaceDocCount = (workspaceId: string) => {
transition: all 0.2s;
background: var(--bg-color);
height: 100%;
+
&:hover {
transform: translateY(-2px);
box-shadow: 0 4px 16px rgba(0, 0, 0, 0.1);
}
- // Color variants
- &.blue {
- border-left: 4px solid var(--blue);
- }
- &.red {
- border-left: 4px solid var(--red);
- }
- &.green {
- border-left: 4px solid var(--green);
- }
- &.yellow {
- border-left: 4px solid var(--yellow);
- }
- &.purple {
- border-left: 4px solid var(--purple);
- }
- &.pink {
- border-left: 4px solid var(--pink);
- }
- &.teal {
- border-left: 4px solid var(--teal);
- }
- &.primary {
- border-left: 4px solid var(--primary);
+ // Color variants - generated
+ @each $color in (blue, red, green, yellow, purple, pink, teal, primary) {
+ &.#{$color} {
+ border-left: 4px solid var(--#{$color});
+ }
}
}
diff --git a/frontend/app/components/Sidebar/SidebarSkeleton.vue b/frontend/app/components/Sidebar/SidebarSkeleton.vue
index bbbc5122..74fcd286 100644
--- a/frontend/app/components/Sidebar/SidebarSkeleton.vue
+++ b/frontend/app/components/Sidebar/SidebarSkeleton.vue
@@ -1,5 +1,5 @@
<template>
- <div style="width: 100%; height: 100%">
+ <div class="skeleton-container">
<div v-if="isLoading" class="sidebar-skeleton">
<div v-for="n in 30" :key="n" class="skeleton-line" :style="{ marginRight: `${(n % 3) * 22}px` }" />
</div>
@@ -24,12 +24,15 @@
</template>
<script setup lang="ts">
-import { NuxtLink } from '#components';
-
defineProps<{ isLoading: boolean }>();
</script>
<style scoped lang="scss">
+.skeleton-container {
+ width: 100%;
+ height: 100%;
+}
+
.sidebar-skeleton {
display: flex;
padding: 0.5rem;
diff --git a/frontend/app/components/Sidebar/SidebarWorkspace.vue b/frontend/app/components/Sidebar/SidebarWorkspace.vue
index cafe32bf..860203e2 100644
--- a/frontend/app/components/Sidebar/SidebarWorkspace.vue
+++ b/frontend/app/components/Sidebar/SidebarWorkspace.vue
@@ -1,8 +1,8 @@
<template>
- <div>
- <span style="display: flex; align-items: center">
+ <div class="workspace-item">
+ <span class="workspace-name">
<Icon :name="option.meta?.icon || 'workspace'" size="22" :class="[getAppColor(option.meta?.color), 'icon']" />
- &nbsp; {{ option.text }}
+ {{ option.text }}
</span>
<span>
<Icon v-if="option.meta?.shared" name="users" />
@@ -16,13 +16,19 @@ defineProps<{ option: Workspace }>();
</script>
<style scoped lang="scss">
-div {
+.workspace-item {
display: flex;
font-weight: 500;
align-items: center;
justify-content: space-between;
}
+.workspace-name {
+ display: flex;
+ align-items: center;
+ gap: 4px;
+}
+
.icon {
padding: 1px;
border-radius: 5px;
diff --git a/frontend/app/styles/theme.scss b/frontend/app/styles/theme.scss
index 2f9f3a2f..9aa1bce0 100644
--- a/frontend/app/styles/theme.scss
+++ b/frontend/app/styles/theme.scss
@@ -1,3 +1,6 @@
+// Global element styles
+// Define styles for standard HTML elements here (for entiere app)
+
@use "./_variables.scss" as *;
a {