Skip to content

πŸ“š The open-source, offline-first Notion, Obsidian & Confluence alternative. Advanced Markdown, multi-tenant teams, OIDC/SSO, and local S3 backups. Deploy in one command.

Fix update password (generate hash) and support x-www-form-urlencoded

Smaug6739cc26137a2ac1
diff --git a/backend/controllers/users.controller.go b/backend/controllers/users.controller.go
index b5214e00..10b89b4f 100644
--- a/backend/controllers/users.controller.go
+++ b/backend/controllers/users.controller.go
@@ -203,15 +203,20 @@ func (ctr *UserControllerImpl) UpdatePassword(c *gin.Context) (int, any) {
return http.StatusBadRequest, errors.New("invalid user ID")
}
var payload struct {
- Password string `json:"password"`
+ Password string `form:"password" json:"password"`
}
- if err := c.ShouldBindJSON(&payload); err != nil {
+ if err := c.ShouldBind(&payload); err != nil {
return http.StatusBadRequest, errors.New("invalid request payload")
}
if payload.Password == "" {
return http.StatusBadRequest, errors.New("password must be provided")
}
- err = ctr.user_service.UpdatePassword(id, payload.Password)
+ // Hash the new password
+ hash, err := bcrypt.GenerateFromPassword([]byte(payload.Password), bcrypt.DefaultCost)
+ if err != nil {
+ return http.StatusInternalServerError, errors.New("failed to hash password")
+ }
+ err = ctr.user_service.UpdatePassword(id, string(hash))
if err != nil {
return http.StatusInternalServerError, err
}