Skip to content

Bring projects, wikis, and teams together with AI. AppFlowy is the AI collaborative workspace where you achieve more without losing control of your data. The leading open source Notion alternative.

fix: mobile link LR issues (#7837)

Morn1f54946a0edf
diff --git a/frontend/appflowy_flutter/lib/core/helpers/url_launcher.dart b/frontend/appflowy_flutter/lib/core/helpers/url_launcher.dart
index fd8aa03dfe..39ed4bc6bb 100644
--- a/frontend/appflowy_flutter/lib/core/helpers/url_launcher.dart
+++ b/frontend/appflowy_flutter/lib/core/helpers/url_launcher.dart
@@ -39,8 +39,9 @@ Future<bool> afLaunchUri(
);
}
- // on Linux, add http scheme to the url if it is not present
- if (UniversalPlatform.isLinux && !isURL(url, {'require_protocol': true})) {
+ // on Linux or Android, add http scheme to the url if it is not present
+ if ((UniversalPlatform.isLinux ||
+ UniversalPlatform.isAndroid) && !isURL(url, {'require_protocol': true})) {
uri = Uri.parse('https://$url');
}
diff --git a/frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/bottom_sheet_edit_link_widget.dart b/frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/bottom_sheet_edit_link_widget.dart
index 5da62a725f..c2920ef480 100644
--- a/frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/bottom_sheet_edit_link_widget.dart
+++ b/frontend/appflowy_flutter/lib/mobile/presentation/bottom_sheet/bottom_sheet_edit_link_widget.dart
@@ -186,6 +186,11 @@ class _MobileBottomSheetEditLinkWidgetState
autofocus: true,
context: context,
contentPadding: EdgeInsets.all(14),
+ textStyle: TextStyle(
+ fontSize: 16,
+ height: 20 / 16,
+ fontWeight: FontWeight.w400,
+ ),
),
VSpace(6),
searchTextField.buildResultContainer(
@@ -267,6 +272,7 @@ class _MobileBottomSheetEditLinkWidgetState
height: 48,
decoration: buildBorderDecoration(),
child: GestureDetector(
+ behavior: HitTestBehavior.opaque,
onTap: showSearchResult,
child: Padding(
padding: EdgeInsets.all(12),
@@ -291,6 +297,7 @@ class _MobileBottomSheetEditLinkWidgetState
Widget buildRemoveLink() {
if (!showRemoveLink) return SizedBox.shrink();
return GestureDetector(
+ behavior: HitTestBehavior.opaque,
onTap: () {
widget.onRemoveLink(linkInfo);
context.pop();
diff --git a/frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/link/link_search_text_field.dart b/frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/link/link_search_text_field.dart
index 7f4f8843d7..6154e68000 100644
--- a/frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/link/link_search_text_field.dart
+++ b/frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/desktop_toolbar/link/link_search_text_field.dart
@@ -70,6 +70,7 @@ class LinkSearchTextField {
bool showError = false,
required BuildContext context,
EdgeInsets contentPadding = const EdgeInsets.fromLTRB(8, 6, 8, 6),
+ TextStyle? textStyle,
}) {
return TextFormField(
autovalidateMode: AutovalidateMode.onUserInteraction,
@@ -77,7 +78,7 @@ class LinkSearchTextField {
focusNode: focusNode,
textAlign: TextAlign.left,
controller: textEditingController,
- style: TextStyle(
+ style: textStyle ?? TextStyle(
fontSize: 14,
height: 20 / 14,
fontWeight: FontWeight.w400,
diff --git a/frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mobile_toolbar_v3/basic_toolbar_item.dart b/frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mobile_toolbar_v3/basic_toolbar_item.dart
index 1fc83af267..fbb73738cf 100644
--- a/frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mobile_toolbar_v3/basic_toolbar_item.dart
+++ b/frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/mobile_toolbar_v3/basic_toolbar_item.dart
@@ -165,7 +165,7 @@ final linkToolbarItem = AppFlowyMobileToolbarItem(
return AppFlowyMobileToolbarIconItem(
editorState: editorState,
shouldListenToToggledStyle: true,
- icon: FlowySvgs.toolbar_link_m,
+ icon: FlowySvgs.m_toolbar_link_m,
onTap: () {
onMobileLinkButtonTap(editorState);
},
diff --git a/frontend/resources/flowy_icons/24x/m_toolbar_link.svg b/frontend/resources/flowy_icons/24x/m_toolbar_link.svg
index 7ee84011b9..1aef9f27cf 100644
--- a/frontend/resources/flowy_icons/24x/m_toolbar_link.svg
+++ b/frontend/resources/flowy_icons/24x/m_toolbar_link.svg
@@ -1,3 +1,3 @@
<svg width="24" height="24" viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg">
-<path d="M8.80965 15.1915L15.1908 8.81034M6.41713 11.203L4.82184 12.7983C3.05973 14.5604 3.05922 17.4176 4.82133 19.1797C6.58344 20.9418 9.44124 20.9413 11.2034 19.1792L12.7969 17.5841M11.2023 6.41672L12.7976 4.82143C14.5597 3.05931 17.4163 3.05963 19.1785 4.82174C20.9406 6.58385 20.9405 9.44083 19.1784 11.2029L17.5839 12.7982" stroke="#1E2022" stroke-width="1.5" stroke-linecap="round" stroke-linejoin="round"/>
+<path d="M14.1623 18.4876L13.4415 19.2084C11.0528 21.5972 7.18012 21.5972 4.79151 19.2084C2.40283 16.8198 2.40283 12.9469 4.79151 10.5582L5.5123 9.83727M9.83772 14.1625L14.1628 9.83727M9.83772 5.5124L10.5586 4.79158C12.9472 2.40281 16.82 2.40281 19.2085 4.79158C21.5972 7.18028 21.5972 11.0531 19.2085 13.4419L18.4877 14.1627" stroke="#21232A" stroke-width="1.5" stroke-linecap="round"/>
</svg>