Skip to content

Bring projects, wikis, and teams together with AI. AppFlowy is the AI collaborative workspace where you achieve more without losing control of your data. The leading open source Notion alternative.

fix: crashes when deleting emoji

Vincent Chan223c8cafd475
diff --git a/frontend/app_flowy/packages/flowy_editor/lib/src/service/internal_key_event_handlers/delete_text_handler.dart b/frontend/app_flowy/packages/flowy_editor/lib/src/service/internal_key_event_handlers/delete_text_handler.dart
index 1bb6872ff4..5e2fdfd453 100644
--- a/frontend/app_flowy/packages/flowy_editor/lib/src/service/internal_key_event_handlers/delete_text_handler.dart
+++ b/frontend/app_flowy/packages/flowy_editor/lib/src/service/internal_key_event_handlers/delete_text_handler.dart
@@ -25,7 +25,7 @@ FlowyKeyEventHandler deleteTextHandler = (editorState, event) {
TransactionBuilder transactionBuilder = TransactionBuilder(editorState);
if (textNodes.length == 1) {
final textNode = textNodes.first;
- final index = selection.start.offset - 1;
+ final index = textNode.delta.prevRunePosition(selection.start.offset);
if (index < 0) {
// 1. style
if (textNode.subtype != null) {
@@ -62,8 +62,8 @@ FlowyKeyEventHandler deleteTextHandler = (editorState, event) {
if (selection.isCollapsed) {
transactionBuilder.deleteText(
textNode,
- selection.start.offset - 1,
- 1,
+ index,
+ selection.start.offset - index,
);
} else {
transactionBuilder.deleteText(