Skip to content

Bring projects, wikis, and teams together with AI. AppFlowy is the AI collaborative workspace where you achieve more without losing control of your data. The leading open source Notion alternative.

test(flutter_desktop): add edit row test (#6442)

Richard Shiue23e3650570e6
diff --git a/frontend/appflowy_flutter/integration_test/desktop/database/database_field_settings_test.dart b/frontend/appflowy_flutter/integration_test/desktop/database/database_field_settings_test.dart
index 865ea15479..9b9434d3d7 100644
--- a/frontend/appflowy_flutter/integration_test/desktop/database/database_field_settings_test.dart
+++ b/frontend/appflowy_flutter/integration_test/desktop/database/database_field_settings_test.dart
@@ -1,5 +1,5 @@
import 'package:appflowy/plugins/database/grid/presentation/grid_page.dart';
-import 'package:appflowy_backend/protobuf/flowy-database2/setting_entities.pbenum.dart';
+import 'package:appflowy_backend/protobuf/flowy-database2/protobuf.dart';
import 'package:appflowy_backend/protobuf/flowy-folder/view.pbenum.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:integration_test/integration_test.dart';
@@ -10,7 +10,7 @@ import '../../shared/util.dart';
void main() {
IntegrationTestWidgetsFlutterBinding.ensureInitialized();
- group('database field settings', () {
+ group('grid field settings test:', () {
testWidgets('field visibility', (tester) async {
await tester.initializeAppFlowy();
await tester.tapAnonymousSignInButton();
@@ -50,6 +50,15 @@ void main() {
await tester.tapHidePropertyButtonInFieldEditor();
await tester.dismissRowDetailPage();
tester.noFieldWithName('New field 1');
+
+ // the field should still be sort and filter-able
+ await tester.tapDatabaseFilterButton();
+ await tester.tapCreateFilterByFieldType(
+ FieldType.RichText,
+ "New field 1",
+ );
+ await tester.tapDatabaseSortButton();
+ await tester.tapCreateSortByFieldType(FieldType.RichText, "New field 1");
});
});
}
diff --git a/frontend/appflowy_flutter/integration_test/desktop/grid/grid_edit_row_test.dart b/frontend/appflowy_flutter/integration_test/desktop/grid/grid_edit_row_test.dart
new file mode 100644
index 0000000000..64b7a40ad1
--- /dev/null
+++ b/frontend/appflowy_flutter/integration_test/desktop/grid/grid_edit_row_test.dart
@@ -0,0 +1,137 @@
+import 'package:appflowy/plugins/database/grid/presentation/widgets/filter/choicechip/checkbox.dart';
+import 'package:appflowy_backend/protobuf/flowy-database2/protobuf.dart';
+import 'package:flutter_test/flutter_test.dart';
+import 'package:integration_test/integration_test.dart';
+import 'package:time/time.dart';
+
+import '../../shared/database_test_op.dart';
+import 'grid_test_extensions.dart';
+
+void main() {
+ IntegrationTestWidgetsFlutterBinding.ensureInitialized();
+
+ group('grid edit row test:', () {
+ testWidgets('with sort configured', (tester) async {
+ await tester.openTestDatabase(v069GridFileName);
+
+ // get grid data
+ final unsorted = tester.getGridRows();
+
+ // add a sort
+ await tester.tapDatabaseSortButton();
+ await tester.tapCreateSortByFieldType(FieldType.RichText, 'Name');
+
+ final sorted = [
+ unsorted[7],
+ unsorted[8],
+ unsorted[1],
+ unsorted[9],
+ unsorted[11],
+ unsorted[10],
+ unsorted[6],
+ unsorted[12],
+ unsorted[2],
+ unsorted[0],
+ unsorted[3],
+ unsorted[5],
+ unsorted[4],
+ ];
+
+ List actual = tester.getGridRows();
+ expect(actual, orderedEquals(sorted));
+
+ await tester.editCell(
+ rowIndex: 4,
+ fieldType: FieldType.RichText,
+ input: "x",
+ );
+ await tester.pumpAndSettle(200.milliseconds);
+
+ final reSorted = [
+ unsorted[7],
+ unsorted[8],
+ unsorted[1],
+ unsorted[9],
+ unsorted[10],
+ unsorted[6],
+ unsorted[12],
+ unsorted[2],
+ unsorted[0],
+ unsorted[3],
+ unsorted[5],
+ unsorted[11],
+ unsorted[4],
+ ];
+
+ // verify grid data
+ actual = tester.getGridRows();
+ expect(actual, orderedEquals(reSorted));
+
+ // delete the sort
+ await tester.tapSortMenuInSettingBar();
+ await tester.tapDeleteAllSortsButton();
+
+ // verify grid data
+ actual = tester.getGridRows();
+ expect(actual, orderedEquals(unsorted));
+ });
+
+ testWidgets('with filter configured', (tester) async {
+ await tester.openTestDatabase(v069GridFileName);
+
+ // get grid data
+ final original = tester.getGridRows();
+
+ // create a filter
+ await tester.tapDatabaseFilterButton();
+ await tester.tapCreateFilterByFieldType(
+ FieldType.Checkbox,
+ 'Registration Complete',
+ );
+
+ final filtered = [
+ original[1],
+ original[3],
+ original[5],
+ original[6],
+ original[7],
+ original[9],
+ original[12],
+ ];
+
+ // verify grid data
+ List actual = tester.getGridRows();
+ expect(actual, orderedEquals(filtered));
+ expect(actual.length, equals(7));
+ tester.assertNumberOfRowsInGridPage(7);
+
+ await tester.tapCheckboxCellInGrid(rowIndex: 0);
+ await tester.pumpAndSettle(200.milliseconds);
+
+ // verify grid data
+ actual = tester.getGridRows();
+ expect(actual.length, equals(6));
+ tester.assertNumberOfRowsInGridPage(6);
+ final edited = [
+ original[3],
+ original[5],
+ original[6],
+ original[7],
+ original[9],
+ original[12],
+ ];
+ expect(actual, orderedEquals(edited));
+
+ // delete the filter
+ await tester.tapFilterButtonInGrid('Registration Complete');
+ await tester
+ .tapDisclosureButtonInFinder(find.byType(CheckboxFilterEditor));
+ await tester.tapDeleteFilterButtonInGrid();
+
+ // verify grid data
+ actual = tester.getGridRows();
+ expect(actual.length, equals(13));
+ tester.assertNumberOfRowsInGridPage(13);
+ });
+ });
+}
diff --git a/frontend/appflowy_flutter/integration_test/desktop_runner_3.dart b/frontend/appflowy_flutter/integration_test/desktop_runner_3.dart
index 8e2b120b21..20456b4652 100644
--- a/frontend/appflowy_flutter/integration_test/desktop_runner_3.dart
+++ b/frontend/appflowy_flutter/integration_test/desktop_runner_3.dart
@@ -10,6 +10,7 @@ import 'desktop/grid/grid_filter_and_sort_test.dart'
import 'desktop/grid/grid_reopen_test.dart' as grid_reopen_test_runner;
import 'desktop/grid/grid_reorder_row_test.dart'
as grid_reorder_row_test_runner;
+import 'desktop/grid/grid_edit_row_test.dart' as grid_edit_row_test_runner;
import 'desktop/settings/settings_runner.dart' as settings_test_runner;
import 'desktop/sidebar/sidebar_test_runner.dart' as sidebar_test_runner;
import 'desktop/uncategorized/emoji_shortcut_test.dart' as emoji_shortcut_test;
@@ -45,6 +46,7 @@ Future<void> runIntegration3OnDesktop() async {
grid_create_row_test_runner.main();
grid_reorder_row_test_runner.main();
grid_filter_and_sort_test_runner.main();
+ grid_edit_row_test_runner.main();
zoom_in_out_test.main();
document_title_test.main();
}
diff --git a/frontend/appflowy_flutter/integration_test/shared/database_test_op.dart b/frontend/appflowy_flutter/integration_test/shared/database_test_op.dart
index 45f47edf19..b4f23072ae 100644
--- a/frontend/appflowy_flutter/integration_test/shared/database_test_op.dart
+++ b/frontend/appflowy_flutter/integration_test/shared/database_test_op.dart
@@ -151,6 +151,7 @@ extension AppFlowyDatabaseTest on WidgetTester {
expect(cell, findsOneWidget);
await enterText(cell, input);
+ await testTextInput.receiveAction(TextInputAction.done);
await pumpAndSettle();
}
diff --git a/frontend/appflowy_flutter/test/bloc_test/grid_test/filter/filter_menu_test.dart b/frontend/appflowy_flutter/test/bloc_test/grid_test/filter/filter_menu_test.dart
index f1c2441d84..6958ed7b5e 100644
--- a/frontend/appflowy_flutter/test/bloc_test/grid_test/filter/filter_menu_test.dart
+++ b/frontend/appflowy_flutter/test/bloc_test/grid_test/filter/filter_menu_test.dart
@@ -134,5 +134,30 @@ void main() {
expect(filterBloc.state.fields.length, equals(3));
expect(filterBloc.state.fields.first.name, equals("New Name"));
});
+
+ test('update field type', () async {
+ final context = await gridTest.createTestGrid();
+ final filterBloc = FilterEditorBloc(
+ viewId: context.gridView.id,
+ fieldController: context.fieldController,
+ );
+ await gridResponseFuture();
+
+ final checkboxField = context.getCheckboxField();
+ filterBloc.add(FilterEditorEvent.createFilter(checkboxField));
+ await gridResponseFuture();
+ expect(filterBloc.state.filters.length, equals(1));
+
+ // edit field
+ await FieldBackendService(
+ viewId: context.gridView.id,
+ fieldId: checkboxField.id,
+ ).updateType(fieldType: FieldType.DateTime);
+ await gridResponseFuture();
+ expect(filterBloc.state.filters.length, equals(0));
+
+ expect(filterBloc.state.fields.length, equals(3));
+ expect(filterBloc.state.fields[2].fieldType, FieldType.DateTime);
+ });
});
}