Skip to content

Bring projects, wikis, and teams together with AI. AppFlowy is the AI collaborative workspace where you achieve more without losing control of your data. The leading open source Notion alternative.

fix: fix crash when selecting the last node

Lucas.Xu2f84d7e54e7b
diff --git a/frontend/app_flowy/packages/flowy_editor/lib/service/selection_service.dart b/frontend/app_flowy/packages/flowy_editor/lib/service/selection_service.dart
index 8baa54c26f..95c158f3ee 100644
--- a/frontend/app_flowy/packages/flowy_editor/lib/service/selection_service.dart
+++ b/frontend/app_flowy/packages/flowy_editor/lib/service/selection_service.dart
@@ -313,13 +313,9 @@ class _FlowySelectionState extends State<FlowySelection>
panStartOffsetWithScrollDyGap.translate(0, panStartScrollDy! - dy);
}
- final sortedNodes =
- editorState.document.root.children.toList(growable: false);
- final first = _lowerBound(
- sortedNodes, panStartOffsetWithScrollDyGap, 0, sortedNodes.length)
- .selectable;
- final last = _upperBound(sortedNodes, panEndOffset!, 0, sortedNodes.length)
- .selectable;
+ final first =
+ _lowerBoundInDocument(panStartOffsetWithScrollDyGap).selectable;
+ final last = _upperBoundInDocument(panEndOffset!).selectable;
// compute the selection in range.
if (first != null && last != null) {
@@ -518,13 +514,13 @@ class _FlowySelectionState extends State<FlowySelection>
Node _lowerBoundInDocument(Offset offset) {
final sortedNodes =
editorState.document.root.children.toList(growable: false);
- return _lowerBound(sortedNodes, offset, 0, sortedNodes.length);
+ return _lowerBound(sortedNodes, offset, 0, sortedNodes.length - 1);
}
Node _upperBoundInDocument(Offset offset) {
final sortedNodes =
editorState.document.root.children.toList(growable: false);
- return _upperBound(sortedNodes, offset, 0, sortedNodes.length);
+ return _upperBound(sortedNodes, offset, 0, sortedNodes.length - 1);
}
/// TODO: Supports multi-level nesting,