Bring projects, wikis, and teams together with AI. AppFlowy is the AI collaborative workspace where you achieve more without losing control of your data. The leading open source Notion alternative.
Dart blogconfluence-alternativecontent-managementcontent-servicesdocumentationflutternote-takingnotion-alternativeproject-managementtask-managementteam-collaborationwiki
feat: implement remove subtype if text node is empty when pressing enter key
Lucas.Xu397f43cbe132
diff --git a/frontend/app_flowy/packages/flowy_editor/lib/service/internal_key_event_handlers/enter_in_edge_of_text_node_handler.dart b/frontend/app_flowy/packages/flowy_editor/lib/service/internal_key_event_handlers/enter_in_edge_of_text_node_handler.dartindex 5b49907138..ccdfcad5dc 100644--- a/frontend/app_flowy/packages/flowy_editor/lib/service/internal_key_event_handlers/enter_in_edge_of_text_node_handler.dart+++ b/frontend/app_flowy/packages/flowy_editor/lib/service/internal_key_event_handlers/enter_in_edge_of_text_node_handler.dart@@ -29,25 +29,46 @@ FlowyKeyEventHandler enterInEdgeOfTextNodeHandler = (editorState, event) {final textNode = nodes.first as TextNode;if (textNode.selectable!.end() == selection.end) {- final needCopyAttributes = StyleKey.globalStyleKeys- .where((key) => key != StyleKey.heading)- .contains(textNode.subtype);- TransactionBuilder(editorState)- ..insertNode(- textNode.path.next,- textNode.copyWith(- children: LinkedList(),- delta: Delta([TextInsert('')]),- attributes: needCopyAttributes ? textNode.attributes : {},- ),- )- ..afterSelection = Selection.collapsed(- Position(- path: textNode.path.next,- offset: 0,- ),- )- ..commit();+ if (textNode.subtype != null && textNode.delta.length == 0) {+ TransactionBuilder(editorState)+ ..deleteNode(textNode)+ ..insertNode(+ textNode.path,+ textNode.copyWith(+ children: LinkedList(),+ delta: Delta([TextInsert('')]),+ attributes: {},+ ),+ )+ ..afterSelection = Selection.collapsed(+ Position(+ path: textNode.path,+ offset: 0,+ ),+ )+ ..commit();+ } else {+ final needCopyAttributes = StyleKey.globalStyleKeys+ .where((key) => key != StyleKey.heading)+ .contains(textNode.subtype);+ TransactionBuilder(editorState)+ ..insertNode(+ textNode.path.next,+ textNode.copyWith(+ children: LinkedList(),+ delta: Delta([TextInsert('')]),+ attributes: needCopyAttributes ? textNode.attributes : {},+ ),+ )+ ..afterSelection = Selection.collapsed(+ Position(+ path: textNode.path.next,+ offset: 0,+ ),+ )+ ..commit();+ }+return KeyEventResult.handled;} else if (textNode.selectable!.start() == selection.start) {TransactionBuilder(editorState)