Skip to content

Bring projects, wikis, and teams together with AI. AppFlowy is the AI collaborative workspace where you achieve more without losing control of your data. The leading open source Notion alternative.

fix: should not notify the parent node when the subtype is not changed

Lucas.Xu49fb0470ab70
diff --git a/frontend/app_flowy/packages/appflowy_editor/lib/src/document/node.dart b/frontend/app_flowy/packages/appflowy_editor/lib/src/document/node.dart
index 81e87399b1..63e6525754 100644
--- a/frontend/app_flowy/packages/appflowy_editor/lib/src/document/node.dart
+++ b/frontend/app_flowy/packages/appflowy_editor/lib/src/document/node.dart
@@ -93,12 +93,14 @@ class Node extends ChangeNotifier with LinkedListEntry<Node> {
}
void updateAttributes(Attributes attributes) {
- bool shouldNotifyParent = _attributes['subtype'] != attributes['subtype'];
-
+ final oldAttributes = {..._attributes};
_attributes = composeAttributes(_attributes, attributes) ?? {};
+
// Notifies the new attributes
// if attributes contains 'subtype', should notify parent to rebuild node
// else, just notify current node.
+ bool shouldNotifyParent =
+ _attributes['subtype'] != oldAttributes['subtype'];
shouldNotifyParent ? parent?.notifyListeners() : notifyListeners();
}