Skip to content

Bring projects, wikis, and teams together with AI. AppFlowy is the AI collaborative workspace where you achieve more without losing control of your data. The leading open source Notion alternative.

feat(flutter_desktop): clickable url links in row detail (#5916)

Sean Siders59f79be29087
diff --git a/frontend/appflowy_flutter/lib/plugins/database/widgets/cell/desktop_row_detail/desktop_row_detail_url_cell.dart b/frontend/appflowy_flutter/lib/plugins/database/widgets/cell/desktop_row_detail/desktop_row_detail_url_cell.dart
index 82b1055356..00d7372027 100644
--- a/frontend/appflowy_flutter/lib/plugins/database/widgets/cell/desktop_row_detail/desktop_row_detail_url_cell.dart
+++ b/frontend/appflowy_flutter/lib/plugins/database/widgets/cell/desktop_row_detail/desktop_row_detail_url_cell.dart
@@ -5,6 +5,7 @@ import 'package:appflowy/plugins/database/widgets/row/cells/cell_container.dart'
import 'package:appflowy/plugins/database/application/cell/bloc/url_cell_bloc.dart';
import 'package:easy_localization/easy_localization.dart';
import 'package:flutter/material.dart';
+import 'package:flutter/services.dart';
import '../editable_cell_skeleton/url.dart';
@@ -18,13 +19,82 @@ class DesktopRowDetailURLSkin extends IEditableURLCellSkin {
TextEditingController textEditingController,
URLCellDataNotifier cellDataNotifier,
) {
- return TextField(
+ return LinkTextField(
controller: textEditingController,
focusNode: focusNode,
+ );
+ }
+
+ @override
+ List<GridCellAccessoryBuilder> accessoryBuilder(
+ GridCellAccessoryBuildContext context,
+ URLCellDataNotifier cellDataNotifier,
+ ) {
+ return [
+ accessoryFromType(
+ GridURLCellAccessoryType.visitURL,
+ cellDataNotifier,
+ ),
+ ];
+ }
+}
+
+class LinkTextField extends StatefulWidget {
+ const LinkTextField({
+ super.key,
+ required this.controller,
+ required this.focusNode,
+ });
+
+ final TextEditingController controller;
+ final FocusNode focusNode;
+
+ @override
+ State<LinkTextField> createState() => _LinkTextFieldState();
+}
+
+class _LinkTextFieldState extends State<LinkTextField> {
+ bool isLinkClickable = false;
+
+ @override
+ void initState() {
+ super.initState();
+ HardwareKeyboard.instance.addHandler(_handleGlobalKeyEvent);
+ }
+
+ @override
+ void dispose() {
+ HardwareKeyboard.instance.removeHandler(_handleGlobalKeyEvent);
+ super.dispose();
+ }
+
+ bool _handleGlobalKeyEvent(KeyEvent event) {
+ final keyboard = HardwareKeyboard.instance;
+ final canOpenLink = event is KeyDownEvent &&
+ (keyboard.isControlPressed || keyboard.isMetaPressed);
+ if (canOpenLink != isLinkClickable) {
+ setState(() => isLinkClickable = canOpenLink);
+ }
+
+ return false;
+ }
+
+ @override
+ Widget build(BuildContext context) {
+ return TextField(
+ mouseCursor:
+ isLinkClickable ? SystemMouseCursors.click : SystemMouseCursors.text,
+ controller: widget.controller,
+ focusNode: widget.focusNode,
style: Theme.of(context).textTheme.bodyMedium?.copyWith(
color: Theme.of(context).colorScheme.primary,
decoration: TextDecoration.underline,
),
+ onTap: () {
+ if (isLinkClickable) {
+ openUrlCellLink(widget.controller.text);
+ }
+ },
decoration: InputDecoration(
contentPadding: const EdgeInsets.symmetric(horizontal: 8, vertical: 9),
border: InputBorder.none,
@@ -40,17 +110,4 @@ class DesktopRowDetailURLSkin extends IEditableURLCellSkin {
),
);
}
-
- @override
- List<GridCellAccessoryBuilder> accessoryBuilder(
- GridCellAccessoryBuildContext context,
- URLCellDataNotifier cellDataNotifier,
- ) {
- return [
- accessoryFromType(
- GridURLCellAccessoryType.visitURL,
- cellDataNotifier,
- ),
- ];
- }
}