Skip to content

Bring projects, wikis, and teams together with AI. AppFlowy is the AI collaborative workspace where you achieve more without losing control of your data. The leading open source Notion alternative.

test: add view selector tests (#7900)

Richard Shiue7f7657edc81e
diff --git a/frontend/appflowy_flutter/lib/ai/service/view_selector_cubit.dart b/frontend/appflowy_flutter/lib/ai/service/view_selector_cubit.dart
index 00d0320a06..2fa259d96e 100644
--- a/frontend/appflowy_flutter/lib/ai/service/view_selector_cubit.dart
+++ b/frontend/appflowy_flutter/lib/ai/service/view_selector_cubit.dart
@@ -1,3 +1,4 @@
+import 'package:appflowy/startup/startup.dart';
import 'package:appflowy/workspace/application/view/view_ext.dart';
import 'package:appflowy/workspace/application/view/view_service.dart';
import 'package:appflowy/workspace/presentation/home/menu/view/view_item.dart';
@@ -120,15 +121,18 @@ class ViewSelectorCubit extends Cubit<ViewSelectorState> {
selectedSourceIds.addAll(newSelectedSourceIds);
}
- void refreshSources(List<ViewPB> spaceViews, ViewPB? currentSpace) async {
+ Future<void> refreshSources(
+ List<ViewPB> spaceViews,
+ ViewPB? currentSpace,
+ ) async {
filterTextController.clear();
final newSources = await Future.wait(
spaceViews.map((view) => _recursiveBuild(view, null)),
);
- for (final source in newSources) {
- _restrictSelectionIfNecessary(source.children);
- }
+
+ _restrictSelectionIfNecessary(newSources);
+
if (currentSpace != null) {
newSources
.firstWhereOrNull((e) => e.view.id == currentSpace.id)
@@ -165,8 +169,13 @@ class ViewSelectorCubit extends Cubit<ViewSelectorState> {
ViewSelectedStatus selectedStatus = ViewSelectedStatus.unselected;
final isThisSourceSelected = selectedSourceIds.contains(view.id);
- final childrenViews =
- await ViewBackendService.getChildViews(viewId: view.id).toNullable();
+ final List<ViewPB>? childrenViews;
+ if (integrationMode().isTest) {
+ childrenViews = view.childViews;
+ } else {
+ childrenViews =
+ await ViewBackendService.getChildViews(viewId: view.id).toNullable();
+ }
int selectedCount = 0;
final children = <ViewSelectorItem>[];
diff --git a/frontend/appflowy_flutter/lib/ai/widgets/prompt_input/select_sources_bottom_sheet.dart b/frontend/appflowy_flutter/lib/ai/widgets/prompt_input/select_sources_bottom_sheet.dart
index 9ee7040574..149482eda0 100644
--- a/frontend/appflowy_flutter/lib/ai/widgets/prompt_input/select_sources_bottom_sheet.dart
+++ b/frontend/appflowy_flutter/lib/ai/widgets/prompt_input/select_sources_bottom_sheet.dart
@@ -1,3 +1,5 @@
+import 'dart:async';
+
import 'package:appflowy/generated/flowy_svgs.g.dart';
import 'package:appflowy/generated/locale_keys.g.dart';
import 'package:appflowy/mobile/presentation/base/flowy_search_text_field.dart';
@@ -102,9 +104,12 @@ class _PromptInputMobileSelectSourcesButtonState
],
),
onTap: () async {
- context
- .read<ViewSelectorCubit>()
- .refreshSources(state.spaces, state.currentSpace);
+ unawaited(
+ context
+ .read<ViewSelectorCubit>()
+ .refreshSources(state.spaces, state.currentSpace),
+ );
+
await showMobileBottomSheet<void>(
context,
backgroundColor: Theme.of(context).colorScheme.surface,
diff --git a/frontend/appflowy_flutter/lib/plugins/ai_chat/presentation/chat_message_selector_banner.dart b/frontend/appflowy_flutter/lib/plugins/ai_chat/presentation/chat_message_selector_banner.dart
index 1f06be1b5f..96485d500c 100644
--- a/frontend/appflowy_flutter/lib/plugins/ai_chat/presentation/chat_message_selector_banner.dart
+++ b/frontend/appflowy_flutter/lib/plugins/ai_chat/presentation/chat_message_selector_banner.dart
@@ -185,9 +185,11 @@ class _SaveToPageButtonState extends State<SaveToPageButton> {
await updateSelection(documentId);
} else {
if (spaceView != null) {
- context
- .read<ViewSelectorCubit>()
- .refreshSources([spaceView], spaceView);
+ unawaited(
+ context
+ .read<ViewSelectorCubit>()
+ .refreshSources([spaceView], spaceView),
+ );
}
popoverController.show();
}
diff --git a/frontend/appflowy_flutter/lib/plugins/ai_chat/presentation/message/ai_message_action_bar.dart b/frontend/appflowy_flutter/lib/plugins/ai_chat/presentation/message/ai_message_action_bar.dart
index 96c7d70a5d..a1f3307187 100644
--- a/frontend/appflowy_flutter/lib/plugins/ai_chat/presentation/message/ai_message_action_bar.dart
+++ b/frontend/appflowy_flutter/lib/plugins/ai_chat/presentation/message/ai_message_action_bar.dart
@@ -578,9 +578,11 @@ class _SaveToPageButtonState extends State<SaveToPageButton> {
} else {
widget.onOverrideVisibility?.call(true);
if (spaceView != null) {
- context
- .read<ViewSelectorCubit>()
- .refreshSources([spaceView], spaceView);
+ unawaited(
+ context
+ .read<ViewSelectorCubit>()
+ .refreshSources([spaceView], spaceView),
+ );
}
popoverController.show();
}
diff --git a/frontend/appflowy_flutter/lib/workspace/application/view/view_ext.dart b/frontend/appflowy_flutter/lib/workspace/application/view/view_ext.dart
index de38a63230..8907784c06 100644
--- a/frontend/appflowy_flutter/lib/workspace/application/view/view_ext.dart
+++ b/frontend/appflowy_flutter/lib/workspace/application/view/view_ext.dart
@@ -298,6 +298,21 @@ extension ViewExtension on ViewPB {
return PageStyleFontLayout.normal;
}
}
+
+ @visibleForTesting
+ set isSpace(bool value) {
+ try {
+ if (extra.isEmpty) {
+ extra = jsonEncode({ViewExtKeys.isSpaceKey: value});
+ } else {
+ final ext = jsonDecode(extra);
+ ext[ViewExtKeys.isSpaceKey] = value;
+ extra = jsonEncode(ext);
+ }
+ } catch (e) {
+ extra = jsonEncode({ViewExtKeys.isSpaceKey: value});
+ }
+ }
}
extension ViewLayoutExtension on ViewLayoutPB {
diff --git a/frontend/appflowy_flutter/test/bloc_test/view_selector_test.dart b/frontend/appflowy_flutter/test/bloc_test/view_selector_test.dart
new file mode 100644
index 0000000000..6ac16c5397
--- /dev/null
+++ b/frontend/appflowy_flutter/test/bloc_test/view_selector_test.dart
@@ -0,0 +1,363 @@
+import 'package:appflowy/ai/service/view_selector_cubit.dart';
+import 'package:appflowy/workspace/application/view/view_ext.dart';
+import 'package:appflowy/workspace/presentation/home/menu/view/view_item.dart';
+import 'package:appflowy_backend/protobuf/flowy-folder/protobuf.dart';
+import 'package:bloc_test/bloc_test.dart';
+import 'package:flutter/foundation.dart';
+import 'package:flutter_test/flutter_test.dart';
+
+void main() {
+ ViewPB testView(
+ String id,
+ String name,
+ ViewLayoutPB layout, [
+ bool isSpace = false,
+ List<ViewPB> children = const [],
+ ]) {
+ return ViewPB()
+ ..id = id
+ ..name = name
+ ..layout = layout
+ ..isSpace = isSpace
+ ..childViews.addAll(children);
+ }
+
+ List<ViewPB> createTestViews() {
+ return [
+ testView('1', 'View 1', ViewLayoutPB.Document, true, [
+ testView('1-1', 'View 1-1', ViewLayoutPB.Document),
+ testView('1-2', 'View 1-2', ViewLayoutPB.Document),
+ ]),
+ testView('2', 'View 2', ViewLayoutPB.Document, false, [
+ testView('2-1', 'View 2-1', ViewLayoutPB.Document),
+ testView('2-2', 'View 2-2', ViewLayoutPB.Grid),
+ testView('2-3', 'View 2-3', ViewLayoutPB.Document, false, [
+ testView('2-3-1', 'View 2-3-1', ViewLayoutPB.Document),
+ ]),
+ ]),
+ testView('3', 'View 3', ViewLayoutPB.Document, true, [
+ testView('3-1', 'View 3-1', ViewLayoutPB.Grid, false, [
+ testView('3-1-1', 'View 3-1-1', ViewLayoutPB.Board),
+ ]),
+ ]),
+ testView('4', 'View 4', ViewLayoutPB.Document, true, [
+ testView('4-1', 'View 4-1', ViewLayoutPB.Chat),
+ testView('4-2', 'View 4-2', ViewLayoutPB.Document, false, [
+ testView('4-2-1', 'View 4-2-1', ViewLayoutPB.Document),
+ testView('4-2-2', 'View 4-2-2', ViewLayoutPB.Document),
+ ]),
+ ]),
+ ];
+ }
+
+ Map<String, ViewSelectedStatus> getSelectedStatus(
+ List<ViewSelectorItem> items,
+ ) {
+ return {
+ for (final item in items) item.view.id: item.selectedStatus,
+ for (final item in items)
+ if (item.children.isNotEmpty) ...getSelectedStatus(item.children),
+ };
+ }
+
+ group('ViewSelectorCubit test:', () {
+ blocTest<ViewSelectorCubit, ViewSelectorState>(
+ 'initial state',
+ build: () => ViewSelectorCubit(
+ getIgnoreViewType: (_) => IgnoreViewType.none,
+ maxSelectedParentPageCount: 1,
+ ),
+ act: (_) {},
+ verify: (cubit) {
+ final s = cubit.state;
+ expect(s.visibleSources, isEmpty);
+ expect(s.selectedSources, isEmpty);
+ },
+ );
+
+ blocTest<ViewSelectorCubit, ViewSelectorState>(
+ 'update sources',
+ build: () => ViewSelectorCubit(
+ getIgnoreViewType: (_) => IgnoreViewType.none,
+ maxSelectedParentPageCount: 1,
+ ),
+ act: (cubit) async {
+ final views = createTestViews();
+ await cubit.refreshSources(views, views.first);
+ },
+ verify: (cubit) {
+ final s = cubit.state;
+ expect(s.visibleSources.length, 4);
+ expect(s.visibleSources[0].isExpanded, isTrue);
+ expect(s.visibleSources[0].children.length, 2);
+ expect(s.visibleSources[1].children.length, 3);
+ expect(s.visibleSources[2].children.length, 1);
+ expect(s.visibleSources[3].children.length, 2);
+ expect(s.selectedSources.isEmpty, isTrue);
+ },
+ );
+
+ blocTest<ViewSelectorCubit, ViewSelectorState>(
+ 'update sources multiple times',
+ build: () => ViewSelectorCubit(
+ getIgnoreViewType: (_) => IgnoreViewType.none,
+ maxSelectedParentPageCount: 1,
+ ),
+ act: (cubit) async {
+ final views = createTestViews();
+ await cubit.refreshSources([], null);
+ await cubit.refreshSources(views, null);
+ await cubit.refreshSources([], null);
+ },
+ expect: () => [
+ predicate<ViewSelectorState>(
+ (s) => s.visibleSources.isEmpty && s.selectedSources.isEmpty,
+ ),
+ predicate<ViewSelectorState>(
+ (s) => s.visibleSources.isNotEmpty && s.selectedSources.isEmpty,
+ ),
+ predicate<ViewSelectorState>(
+ (s) => s.visibleSources.isEmpty && s.selectedSources.isEmpty,
+ ),
+ ],
+ );
+
+ blocTest<ViewSelectorCubit, ViewSelectorState>(
+ 'update selected sources',
+ build: () => ViewSelectorCubit(
+ getIgnoreViewType: (_) => IgnoreViewType.none,
+ maxSelectedParentPageCount: 100,
+ ),
+ act: (cubit) async {
+ final views = createTestViews();
+ cubit.updateSelectedSources([
+ '2-3-1',
+ '3-1',
+ '3-1-1',
+ '4-2',
+ '4-2-1',
+ ]);
+ await cubit.refreshSources(views, null);
+ },
+ skip: 1,
+ expect: () => [
+ predicate<ViewSelectorState>((s) {
+ final lengthCheck =
+ s.visibleSources.length == 4 && s.selectedSources.length == 3;
+
+ final expected = {
+ '1': ViewSelectedStatus.unselected,
+ '1-1': ViewSelectedStatus.unselected,
+ '1-2': ViewSelectedStatus.unselected,
+ '2': ViewSelectedStatus.partiallySelected,
+ '2-1': ViewSelectedStatus.unselected,
+ '2-2': ViewSelectedStatus.unselected,
+ '2-3': ViewSelectedStatus.partiallySelected,
+ '2-3-1': ViewSelectedStatus.selected,
+ '3': ViewSelectedStatus.partiallySelected,
+ '3-1': ViewSelectedStatus.selected,
+ '3-1-1': ViewSelectedStatus.selected,
+ '4': ViewSelectedStatus.partiallySelected,
+ '4-1': ViewSelectedStatus.unselected,
+ '4-2': ViewSelectedStatus.partiallySelected,
+ '4-2-1': ViewSelectedStatus.selected,
+ '4-2-2': ViewSelectedStatus.unselected,
+ };
+
+ final actual = getSelectedStatus(s.visibleSources);
+
+ return lengthCheck && mapEquals(expected, actual);
+ }),
+ ],
+ );
+
+ blocTest<ViewSelectorCubit, ViewSelectorState>(
+ 'select a source 1',
+ build: () => ViewSelectorCubit(
+ getIgnoreViewType: (_) => IgnoreViewType.none,
+ maxSelectedParentPageCount: 100,
+ ),
+ act: (cubit) async {
+ final views = createTestViews();
+ await cubit.refreshSources(views, null);
+ cubit.toggleSelectedStatus(
+ cubit.state.visibleSources[1].children[2].children[0], // '2-3-1',
+ false,
+ );
+ },
+ skip: 1,
+ expect: () => [
+ predicate<ViewSelectorState>((s) {
+ return getSelectedStatus(s.visibleSources)
+ .values
+ .every((value) => value == ViewSelectedStatus.unselected);
+ }),
+ predicate<ViewSelectorState>((s) {
+ final selectedStatusMap = getSelectedStatus(s.visibleSources);
+ return selectedStatusMap['2-3'] ==
+ ViewSelectedStatus.partiallySelected &&
+ selectedStatusMap['2-3-1'] == ViewSelectedStatus.selected;
+ }),
+ ],
+ );
+
+ blocTest<ViewSelectorCubit, ViewSelectorState>(
+ 'select a source 2',
+ build: () => ViewSelectorCubit(
+ getIgnoreViewType: (_) => IgnoreViewType.none,
+ maxSelectedParentPageCount: 100,
+ ),
+ act: (cubit) async {
+ final views = createTestViews();
+ await cubit.refreshSources(views, null);
+ cubit.toggleSelectedStatus(
+ cubit.state.visibleSources[1].children[2], // '2-3',
+ false,
+ );
+ cubit.toggleSelectedStatus(
+ cubit.state.visibleSources[1].children[2].children[0], // '2-3-1',
+ false,
+ );
+ },
+ skip: 2,
+ expect: () => [
+ predicate<ViewSelectorState>((s) {
+ final selectedStatusMap = getSelectedStatus(s.visibleSources);
+ return selectedStatusMap['2-3'] == ViewSelectedStatus.selected &&
+ selectedStatusMap['2-3-1'] == ViewSelectedStatus.selected;
+ }),
+ predicate<ViewSelectorState>((s) {
+ final selectedStatusMap = getSelectedStatus(s.visibleSources);
+ return selectedStatusMap['2-3'] ==
+ ViewSelectedStatus.partiallySelected &&
+ selectedStatusMap['2-3-1'] == ViewSelectedStatus.unselected;
+ }),
+ ],
+ );
+
+ blocTest<ViewSelectorCubit, ViewSelectorState>(
+ 'select a source 3',
+ build: () => ViewSelectorCubit(
+ getIgnoreViewType: (_) => IgnoreViewType.none,
+ maxSelectedParentPageCount: 100,
+ ),
+ act: (cubit) async {
+ final views = createTestViews();
+ cubit.updateSelectedSources(['2-3', '2-3-1']);
+ await cubit.refreshSources(views, null);
+ cubit.toggleSelectedStatus(
+ cubit.state.visibleSources[1].children[2], // '2-3',
+ false,
+ );
+ },
+ skip: 1,
+ expect: () => [
+ predicate<ViewSelectorState>((s) {
+ final selectedStatusMap = getSelectedStatus(s.visibleSources);
+ return selectedStatusMap['2-3'] == ViewSelectedStatus.selected &&
+ selectedStatusMap['2-3-1'] == ViewSelectedStatus.selected;
+ }),
+ predicate<ViewSelectorState>((s) {
+ final selectedStatusMap = getSelectedStatus(s.visibleSources);
+ return selectedStatusMap['2-3'] == ViewSelectedStatus.unselected &&
+ selectedStatusMap['2-3-1'] == ViewSelectedStatus.unselected;
+ }),
+ ],
+ );
+
+ blocTest<ViewSelectorCubit, ViewSelectorState>(
+ 'select a source 4',
+ build: () => ViewSelectorCubit(
+ getIgnoreViewType: (_) => IgnoreViewType.none,
+ maxSelectedParentPageCount: 100,
+ ),
+ act: (cubit) async {
+ final views = createTestViews();
+ cubit.updateSelectedSources(['4-2', '4-2-1']);
+ await cubit.refreshSources(views, null);
+ cubit.toggleSelectedStatus(
+ cubit.state.visibleSources[3].children[1].children[1], // 4-2-2,
+ false,
+ );
+ },
+ skip: 1,
+ expect: () => [
+ predicate<ViewSelectorState>((s) {
+ final selectedStatusMap = getSelectedStatus(s.visibleSources);
+ return selectedStatusMap['4-2'] ==
+ ViewSelectedStatus.partiallySelected &&
+ selectedStatusMap['4-2-1'] == ViewSelectedStatus.selected &&
+ selectedStatusMap['4-2-2'] == ViewSelectedStatus.unselected;
+ }),
+ predicate<ViewSelectorState>((s) {
+ final selectedStatusMap = getSelectedStatus(s.visibleSources);
+ return selectedStatusMap['4-2'] == ViewSelectedStatus.selected &&
+ selectedStatusMap['4-2-1'] == ViewSelectedStatus.selected &&
+ selectedStatusMap['4-2-2'] == ViewSelectedStatus.selected;
+ }),
+ ],
+ );
+
+ blocTest<ViewSelectorCubit, ViewSelectorState>(
+ 'select a source 5',
+ build: () => ViewSelectorCubit(
+ getIgnoreViewType: (_) => IgnoreViewType.none,
+ maxSelectedParentPageCount: 100,
+ ),
+ act: (cubit) async {
+ final views = createTestViews();
+ cubit.updateSelectedSources(['4-2', '4-2-1']);
+ await cubit.refreshSources(views, null);
+ cubit.toggleSelectedStatus(
+ cubit.state.visibleSources[3].children[1], // 4-2
+ false,
+ );
+ },
+ verify: (cubit) {
+ final selectedStatusMap = getSelectedStatus(cubit.state.visibleSources);
+ expect(selectedStatusMap['4-2'], ViewSelectedStatus.unselected);
+ expect(selectedStatusMap['4-2-1'], ViewSelectedStatus.unselected);
+ expect(selectedStatusMap['4-2-2'], ViewSelectedStatus.unselected);
+ },
+ );
+
+ blocTest<ViewSelectorCubit, ViewSelectorState>(
+ 'cannot select more than maximum selection limit',
+ build: () => ViewSelectorCubit(
+ getIgnoreViewType: (_) => IgnoreViewType.none,
+ maxSelectedParentPageCount: 2,
+ ),
+ act: (cubit) async {
+ final views = createTestViews();
+ cubit.updateSelectedSources(['1-1', '2-1']);
+ await cubit.refreshSources(views, null);
+ },
+ verify: (cubit) {
+ final s = cubit.state;
+ expect(s.visibleSources[0].children[0].isDisabled, isFalse);
+ expect(s.visibleSources[0].children[1].isDisabled, isFalse);
+ expect(s.visibleSources[1].children[0].isDisabled, isFalse);
+ expect(s.visibleSources[1].children[1].isDisabled, isFalse);
+ expect(s.visibleSources[2].children[0].isDisabled, isTrue);
+ },
+ );
+
+ blocTest<ViewSelectorCubit, ViewSelectorState>(
+ 'filter sources correctly',
+ build: () => ViewSelectorCubit(
+ getIgnoreViewType: (_) => IgnoreViewType.none,
+ maxSelectedParentPageCount: 1,
+ ),
+ act: (cubit) async {
+ final views = createTestViews();
+ await cubit.refreshSources(views, null);
+ cubit.filterTextController.text = 'View 1';
+ },
+ verify: (cubit) {
+ final s = cubit.state;
+ expect(s.visibleSources.length, 1);
+ expect(s.visibleSources[0].children.length, 2);
+ },
+ );
+ });
+}